Title: [283457] trunk/Source/WebKit
- Revision
- 283457
- Author
- [email protected]
- Date
- 2021-10-02 18:36:51 -0700 (Sat, 02 Oct 2021)
Log Message
Replace WKProcessPoolWeakObserver (Direct) category with (direct) property attribute
<https://webkit.org/b/231119>
Reviewed by Anders Carlsson.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(-[WKProcessPoolWeakObserver initWithWeakPtr:]):
- Merge WKProcessPoolWeakObserver (Direct) category into primary
interface, and use the (direct) property attribute instead.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (283456 => 283457)
--- trunk/Source/WebKit/ChangeLog 2021-10-03 00:24:58 UTC (rev 283456)
+++ trunk/Source/WebKit/ChangeLog 2021-10-03 01:36:51 UTC (rev 283457)
@@ -1,3 +1,15 @@
+2021-10-02 David Kilzer <[email protected]>
+
+ Replace WKProcessPoolWeakObserver (Direct) category with (direct) property attribute
+ <https://webkit.org/b/231119>
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (-[WKProcessPoolWeakObserver initWithWeakPtr:]):
+ - Merge WKProcessPoolWeakObserver (Direct) category into primary
+ interface, and use the (direct) property attribute instead.
+
2021-10-02 Chris Dumez <[email protected]>
REGRESSION (r275455): ASSERTION FAILED: process->hasOneRef() seen with TestWebKitAPI.WKProcessPool.WarmInitialProcess
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (283456 => 283457)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2021-10-03 00:24:58 UTC (rev 283456)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2021-10-03 01:36:51 UTC (rev 283457)
@@ -139,15 +139,12 @@
@interface WKProcessPoolWeakObserver : NSObject {
WeakPtr<WebKit::WebProcessPool> m_weakPtr;
}
+@property (nonatomic, readonly, direct) RefPtr<WebKit::WebProcessPool> pool;
- (instancetype)init NS_UNAVAILABLE;
- (instancetype)initWithWeakPtr:(WeakPtr<WebKit::WebProcessPool>&&)weakPtr NS_DESIGNATED_INITIALIZER;
@end
NS_DIRECT_MEMBERS
-@interface WKProcessPoolWeakObserver (Direct)
-@property (nonatomic, readonly) RefPtr<WebKit::WebProcessPool> pool;
-@end
-
@implementation WKProcessPoolWeakObserver
- (instancetype)initWithWeakPtr:(WeakPtr<WebKit::WebProcessPool>&&)weakPtr
{
@@ -155,10 +152,7 @@
m_weakPtr = WTFMove(weakPtr);
return self;
}
-@end
-NS_DIRECT_MEMBERS
-@implementation WKProcessPoolWeakObserver (Direct)
- (RefPtr<WebKit::WebProcessPool>)pool
{
return m_weakPtr.get();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
