Title: [106472] trunk
- Revision
- 106472
- Author
- [email protected]
- Date
- 2012-02-01 09:58:57 -0800 (Wed, 01 Feb 2012)
Log Message
[GTK] editing/inserting/4960120-2.html flaky crash
https://bugs.webkit.org/show_bug.cgi?id=76815
Reviewed by Martin Robinson.
Source/WebCore:
Check if the node for the first parent object not ignoring
accessibility is null before using it. This might happen with
certain kind of accessibility objects, such as the root one (the
scroller containing the webArea object as its only child).
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(objectFocusedAndCaretOffsetUnignored): Add missing null check.
LayoutTests:
* platform/gtk/test_expectations.txt: Unskipping tests that
shouldn't be crashing from now on.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (106471 => 106472)
--- trunk/LayoutTests/ChangeLog 2012-02-01 17:41:27 UTC (rev 106471)
+++ trunk/LayoutTests/ChangeLog 2012-02-01 17:58:57 UTC (rev 106472)
@@ -1,3 +1,13 @@
+2012-02-01 Mario Sanchez Prada <[email protected]>
+
+ [GTK] editing/inserting/4960120-2.html flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=76815
+
+ Reviewed by Martin Robinson.
+
+ * platform/gtk/test_expectations.txt: Unskipping tests that
+ shouldn't be crashing from now on.
+
2012-02-01 Yury Semikhatsky <[email protected]>
Web Inspector: debugger reports wrong sources when paused in inline script on page reload
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (106471 => 106472)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-02-01 17:41:27 UTC (rev 106471)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-02-01 17:58:57 UTC (rev 106472)
@@ -10,8 +10,6 @@
BUGWK68859 DEBUG : fast/dynamic/crash-paint-no-documentElement-renderer.html = CRASH
BUGWK76814 DEBUG : fast/xmlhttprequest/xmlhttprequest-get.xhtml = CRASH
-BUGWK76815 DEBUG : editing/inserting/4960120-2.html = CRASH
-BUGWK76815 DEBUG : editing/execCommand/19455.html = CRASH
// Flaky tests
Modified: trunk/Source/WebCore/ChangeLog (106471 => 106472)
--- trunk/Source/WebCore/ChangeLog 2012-02-01 17:41:27 UTC (rev 106471)
+++ trunk/Source/WebCore/ChangeLog 2012-02-01 17:58:57 UTC (rev 106472)
@@ -1,3 +1,18 @@
+2012-02-01 Mario Sanchez Prada <[email protected]>
+
+ [GTK] editing/inserting/4960120-2.html flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=76815
+
+ Reviewed by Martin Robinson.
+
+ Check if the node for the first parent object not ignoring
+ accessibility is null before using it. This might happen with
+ certain kind of accessibility objects, such as the root one (the
+ scroller containing the webArea object as its only child).
+
+ * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
+ (objectFocusedAndCaretOffsetUnignored): Add missing null check.
+
2012-02-01 Antti Koivisto <[email protected]>
Make CSSMappedAttributeDeclaration have CSSMutableStyleDeclaration instead of being one
Modified: trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp (106471 => 106472)
--- trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp 2012-02-01 17:41:27 UTC (rev 106471)
+++ trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp 2012-02-01 17:58:57 UTC (rev 106472)
@@ -1035,6 +1035,13 @@
if (!startNode)
startNode = firstUnignoredParent->node();
+ // Check if the node for the first parent object not ignoring
+ // accessibility is null again before using it. This might happen
+ // with certain kind of accessibility objects, such as the root
+ // one (the scroller containing the webArea object).
+ if (!startNode)
+ return 0;
+
VisiblePosition startPosition = VisiblePosition(positionBeforeNode(startNode), DOWNSTREAM);
VisiblePosition endPosition = firstUnignoredParent->selection().visibleEnd();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
