Title: [106368] trunk/Source/_javascript_Core
Revision
106368
Author
[email protected]
Date
2012-01-31 10:06:23 -0800 (Tue, 31 Jan 2012)

Log Message

Vector<T>::operator== shouldn't require T to have operator!=
https://bugs.webkit.org/show_bug.cgi?id=77448

Reviewed by Andreas Kling.

Change VectorComparer::compare to use !(a == b) instead of a != b since
it makes more sense for Vector::operator== to use the element's operator==.

* wtf/Vector.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106367 => 106368)


--- trunk/Source/_javascript_Core/ChangeLog	2012-01-31 17:40:50 UTC (rev 106367)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-31 18:06:23 UTC (rev 106368)
@@ -1,3 +1,15 @@
+2012-01-31  Anders Carlsson  <[email protected]>
+
+        Vector<T>::operator== shouldn't require T to have operator!=
+        https://bugs.webkit.org/show_bug.cgi?id=77448
+
+        Reviewed by Andreas Kling.
+
+        Change VectorComparer::compare to use !(a == b) instead of a != b since
+        it makes more sense for Vector::operator== to use the element's operator==.
+
+        * wtf/Vector.h:
+
 2012-01-30  Oliver Hunt  <[email protected]>
 
         get_by_val_arguments is broken in the interpreter

Modified: trunk/Source/_javascript_Core/wtf/Vector.h (106367 => 106368)


--- trunk/Source/_javascript_Core/wtf/Vector.h	2012-01-31 17:40:50 UTC (rev 106367)
+++ trunk/Source/_javascript_Core/wtf/Vector.h	2012-01-31 18:06:23 UTC (rev 106368)
@@ -194,7 +194,7 @@
         static bool compare(const T* a, const T* b, size_t size)
         {
             for (size_t i = 0; i < size; ++i)
-                if (a[i] != b[i])
+                if (!(a[i] == b[i]))
                     return false;
             return true;
         }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to