Title: [280888] trunk/Tools
Revision
280888
Author
[email protected]
Date
2021-08-11 00:46:55 -0700 (Wed, 11 Aug 2021)

Log Message

[WPE] Handle escape key in wpeKeySymForKeyRef
https://bugs.webkit.org/show_bug.cgi?id=228981

Reviewed by Carlos Garcia Campos.

Some dialog tests were failing due to "escape" key ref being
translated to the 'e' keysym.

Covered by existing tests.

* WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
(WTR::wpeKeySymForKeyRef):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (280887 => 280888)


--- trunk/Tools/ChangeLog	2021-08-11 07:43:42 UTC (rev 280887)
+++ trunk/Tools/ChangeLog	2021-08-11 07:46:55 UTC (rev 280888)
@@ -1,3 +1,18 @@
+2021-08-11  Lauro Moura  <[email protected]>
+
+        [WPE] Handle escape key in wpeKeySymForKeyRef
+        https://bugs.webkit.org/show_bug.cgi?id=228981
+
+        Reviewed by Carlos Garcia Campos.
+
+        Some dialog tests were failing due to "escape" key ref being
+        translated to the 'e' keysym.
+
+        Covered by existing tests.
+
+        * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
+        (WTR::wpeKeySymForKeyRef):
+
 2021-08-10  Jonathan Bedard  <[email protected]>
 
         [webkitpy] Stop relying on device.plist for simulated device state

Modified: trunk/Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp (280887 => 280888)


--- trunk/Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp	2021-08-11 07:43:42 UTC (rev 280887)
+++ trunk/Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp	2021-08-11 07:46:55 UTC (rev 280888)
@@ -290,6 +290,8 @@
         return WPE_KEY_F11;
     if (WKStringIsEqualToUTF8CString(keyRef, "F12"))
         return WPE_KEY_F12;
+    if (WKStringIsEqualToUTF8CString(keyRef, "escape"))
+        return WPE_KEY_Escape;
 
     size_t bufferSize = WKStringGetMaximumUTF8CStringSize(keyRef);
     auto buffer = makeUniqueArray<char>(bufferSize);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to