Title: [279718] releases/WebKitGTK/webkit-2.32
- Revision
- 279718
- Author
- carlo...@webkit.org
- Date
- 2021-07-08 01:43:25 -0700 (Thu, 08 Jul 2021)
Log Message
Merge r279039 - [MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
https://bugs.webkit.org/show_bug.cgi?id=191419
Patch by Philippe Normand <pnorm...@igalia.com> on 2021-06-18
Reviewed by Michael Catanzaro.
Source/WebCore:
When MSE is used the player receives broken audio fragments, perhaps because the server
expects the client to repair them. Not much we can do about this on GStreamer side though,
so behave as a Chrome UserAgent and then MSE is not used, the player receives an MP3 stream.
* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):
Tools:
* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST): Add a test for the soundcloud quirk.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (279717 => 279718)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-07-08 08:18:23 UTC (rev 279717)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-07-08 08:43:25 UTC (rev 279718)
@@ -1,3 +1,17 @@
+2021-06-18 Philippe Normand <pnorm...@igalia.com>
+
+ [MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
+ https://bugs.webkit.org/show_bug.cgi?id=191419
+
+ Reviewed by Michael Catanzaro.
+
+ When MSE is used the player receives broken audio fragments, perhaps because the server
+ expects the client to repair them. Not much we can do about this on GStreamer side though,
+ so behave as a Chrome UserAgent and then MSE is not used, the player receives an MP3 stream.
+
+ * platform/UserAgentQuirks.cpp:
+ (WebCore::urlRequiresChromeBrowser):
+
2021-05-21 Chris Lord <cl...@igalia.com>
[GTK] REGRESSION: Broken scrolling on element.io with async scrolling
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/platform/UserAgentQuirks.cpp (279717 => 279718)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/platform/UserAgentQuirks.cpp 2021-07-08 08:18:23 UTC (rev 279717)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/platform/UserAgentQuirks.cpp 2021-07-08 08:43:25 UTC (rev 279718)
@@ -62,6 +62,10 @@
if (domain == "docs.google.com")
return true;
+ // soundcloud.com serves broken MSE audio fragments with WebKitGTK's standard user agent.
+ if (baseDomain == "soundcloud.com")
+ return true;
+
return false;
}
Modified: releases/WebKitGTK/webkit-2.32/Tools/ChangeLog (279717 => 279718)
--- releases/WebKitGTK/webkit-2.32/Tools/ChangeLog 2021-07-08 08:18:23 UTC (rev 279717)
+++ releases/WebKitGTK/webkit-2.32/Tools/ChangeLog 2021-07-08 08:43:25 UTC (rev 279718)
@@ -1,3 +1,13 @@
+2021-06-18 Philippe Normand <pnorm...@igalia.com>
+
+ [MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
+ https://bugs.webkit.org/show_bug.cgi?id=191419
+
+ Reviewed by Michael Catanzaro.
+
+ * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+ (TestWebKitAPI::TEST): Add a test for the soundcloud quirk.
+
2021-05-05 Carlos Garcia Campos <cgar...@igalia.com>
[SOUP] Wrong cookie timestamp in case of long expire time
Modified: releases/WebKitGTK/webkit-2.32/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (279717 => 279718)
--- releases/WebKitGTK/webkit-2.32/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp 2021-07-08 08:18:23 UTC (rev 279717)
+++ releases/WebKitGTK/webkit-2.32/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp 2021-07-08 08:43:25 UTC (rev 279718)
@@ -86,6 +86,7 @@
assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
assertUserAgentForURLHasChromeBrowserQuirk("http://auth.mayohr.com/");
assertUserAgentForURLHasChromeBrowserQuirk("http://bankofamerica.com/");
+ assertUserAgentForURLHasChromeBrowserQuirk("http://soundcloud.com/");
assertUserAgentForURLHasFirefoxBrowserQuirk("http://bugzilla.redhat.com/");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
