Title: [279669] trunk
- Revision
- 279669
- Author
- cdu...@apple.com
- Date
- 2021-07-07 14:12:29 -0700 (Wed, 07 Jul 2021)
Log Message
IDBIndex.keyPath should keep returning the same object
https://bugs.webkit.org/show_bug.cgi?id=227758
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline WPT tests that are now passing.
* web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt:
* web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt:
Source/WebCore:
IDBIndex.keyPath should keep returning the same object to match other browser
engines (Gecko and Blink).
No new tests, rebaselined existing tests.
* Modules/indexeddb/IDBIndex.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279668 => 279669)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-07-07 21:12:29 UTC (rev 279669)
@@ -1,3 +1,15 @@
+2021-07-07 Chris Dumez <cdu...@apple.com>
+
+ IDBIndex.keyPath should keep returning the same object
+ https://bugs.webkit.org/show_bug.cgi?id=227758
+
+ Reviewed by Geoffrey Garen.
+
+ Rebaseline WPT tests that are now passing.
+
+ * web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt:
+ * web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt:
+
2021-07-07 Alex Christensen <achristen...@webkit.org>
Allow setting empty hosts of URLs with non-special schemes
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt (279668 => 279669)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt 2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt 2021-07-07 21:12:29 UTC (rev 279669)
@@ -1,3 +1,3 @@
-FAIL IDBIndex's keyPath attribute returns the same object. assert_equals: Same object instance is returned each time keyPath is inspected expected ["a", "b"] but got ["a", "b"]
+PASS IDBIndex's keyPath attribute returns the same object.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt (279668 => 279669)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt 2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt 2021-07-07 21:12:29 UTC (rev 279669)
@@ -1,3 +1,3 @@
-FAIL IDBIndex's keyPath attribute returns the same object. assert_equals: Same object instance is returned each time keyPath is inspected expected ["a", "b"] but got ["a", "b"]
+PASS IDBIndex's keyPath attribute returns the same object.
Modified: trunk/Source/WebCore/ChangeLog (279668 => 279669)
--- trunk/Source/WebCore/ChangeLog 2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/Source/WebCore/ChangeLog 2021-07-07 21:12:29 UTC (rev 279669)
@@ -1,3 +1,17 @@
+2021-07-07 Chris Dumez <cdu...@apple.com>
+
+ IDBIndex.keyPath should keep returning the same object
+ https://bugs.webkit.org/show_bug.cgi?id=227758
+
+ Reviewed by Geoffrey Garen.
+
+ IDBIndex.keyPath should keep returning the same object to match other browser
+ engines (Gecko and Blink).
+
+ No new tests, rebaselined existing tests.
+
+ * Modules/indexeddb/IDBIndex.idl:
+
2021-07-07 Alex Christensen <achristen...@webkit.org>
Allow setting empty hosts of URLs with non-special schemes
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl (279668 => 279669)
--- trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl 2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl 2021-07-07 21:12:29 UTC (rev 279669)
@@ -36,7 +36,7 @@
] interface IDBIndex {
attribute DOMString name;
[SameObject] readonly attribute IDBObjectStore objectStore;
- readonly attribute IDBKeyPath? keyPath;
+ [SameObject, CachedAttribute] readonly attribute IDBKeyPath keyPath;
readonly attribute boolean multiEntry;
readonly attribute boolean unique;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
