Title: [279654] trunk/Source/_javascript_Core
- Revision
- 279654
- Author
- ysuz...@apple.com
- Date
- 2021-07-07 12:08:20 -0700 (Wed, 07 Jul 2021)
Log Message
[JSC] Do not allocate JITWorklist if JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=227734
Reviewed by Mark Lam.
Previously, this code was doing,
if (Options::useJIT())
DFG::iterateCodeBlocksForGC(visitor, m_vm, func);
But r278082 changed it to
JITWorklist::ensureGlobalWorklist().iterateCodeBlocksForGC(visitor, m_vm, func);
As a result, we are always allocating JITWorklist even JIT is not enabled.
This patch fixes the behavior not to allocate JITWorklist.
* heap/Heap.cpp:
(JSC::Heap::iterateExecutingAndCompilingCodeBlocks):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (279653 => 279654)
--- trunk/Source/_javascript_Core/ChangeLog 2021-07-07 18:44:55 UTC (rev 279653)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-07-07 19:08:20 UTC (rev 279654)
@@ -1,3 +1,25 @@
+2021-07-07 Yusuke Suzuki <ysuz...@apple.com>
+
+ [JSC] Do not allocate JITWorklist if JIT is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=227734
+
+ Reviewed by Mark Lam.
+
+ Previously, this code was doing,
+
+ if (Options::useJIT())
+ DFG::iterateCodeBlocksForGC(visitor, m_vm, func);
+
+ But r278082 changed it to
+
+ JITWorklist::ensureGlobalWorklist().iterateCodeBlocksForGC(visitor, m_vm, func);
+
+ As a result, we are always allocating JITWorklist even JIT is not enabled.
+ This patch fixes the behavior not to allocate JITWorklist.
+
+ * heap/Heap.cpp:
+ (JSC::Heap::iterateExecutingAndCompilingCodeBlocks):
+
2021-07-06 Yusuke Suzuki <ysuz...@apple.com>
r270214 broke testb3 on arm64e
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (279653 => 279654)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2021-07-07 18:44:55 UTC (rev 279653)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2021-07-07 19:08:20 UTC (rev 279654)
@@ -647,7 +647,8 @@
{
m_codeBlocks->iterateCurrentlyExecuting(func);
#if ENABLE(JIT)
- JITWorklist::ensureGlobalWorklist().iterateCodeBlocksForGC(visitor, m_vm, func);
+ if (Options::useJIT())
+ JITWorklist::ensureGlobalWorklist().iterateCodeBlocksForGC(visitor, m_vm, func);
#else
UNUSED_PARAM(visitor);
#endif // ENABLE(JIT)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
