Title: [278436] trunk/PerformanceTests
Revision
278436
Author
s...@apple.com
Date
2021-06-03 17:31:45 -0700 (Thu, 03 Jun 2021)

Log Message

[MotionMark] Controller.filterOutOutliers() sorts the frameLengths array incorrectly
https://bugs.webkit.org/show_bug.cgi?id=226605

Reviewed by Myles C. Maxfield.

Controller.filterOutOutliers must pass a compare function to Array.sort()
because it filters an array of numbers.

* MotionMark/tests/resources/main.js:
(filterOutOutliers):

Modified Paths

Diff

Modified: trunk/PerformanceTests/ChangeLog (278435 => 278436)


--- trunk/PerformanceTests/ChangeLog	2021-06-04 00:20:22 UTC (rev 278435)
+++ trunk/PerformanceTests/ChangeLog	2021-06-04 00:31:45 UTC (rev 278436)
@@ -1,3 +1,16 @@
+2021-06-03  Said Abou-Hallawa  <s...@apple.com>
+
+        [MotionMark] Controller.filterOutOutliers() sorts the frameLengths array incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=226605
+
+        Reviewed by Myles C. Maxfield.
+
+        Controller.filterOutOutliers must pass a compare function to Array.sort()
+        because it filters an array of numbers.
+
+        * MotionMark/tests/resources/main.js:
+        (filterOutOutliers):
+
 2021-06-03  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         [MotionMark] Update version number of local development version of the benchmark to match the currently-being-released version

Modified: trunk/PerformanceTests/MotionMark/tests/resources/main.js (278435 => 278436)


--- trunk/PerformanceTests/MotionMark/tests/resources/main.js	2021-06-04 00:20:22 UTC (rev 278435)
+++ trunk/PerformanceTests/MotionMark/tests/resources/main.js	2021-06-04 00:31:45 UTC (rev 278436)
@@ -115,7 +115,7 @@
         if (array.length == 0)
             return [];
 
-        array.sort();
+        array.sort((a, b) => a - b);
         var q1 = array[Math.min(Math.round(array.length * 1 / 4), array.length - 1)];
         var q3 = array[Math.min(Math.round(array.length * 3 / 4), array.length - 1)];
         var interquartileRange = q3 - q1;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to