Title: [106066] trunk/Tools
Revision
106066
Author
[email protected]
Date
2012-01-26 17:14:06 -0800 (Thu, 26 Jan 2012)

Log Message

Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
https://bugs.webkit.org/show_bug.cgi?id=77164

Reviewed by Dirk Pranke.

http://trac.webkit.org/changeset/106035 depends on builder_name being
falsey by default. There's other code that requires it to be iterable
by default. So, make it be the empty string.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (106065 => 106066)


--- trunk/Tools/ChangeLog	2012-01-27 01:08:15 UTC (rev 106065)
+++ trunk/Tools/ChangeLog	2012-01-27 01:14:06 UTC (rev 106066)
@@ -1,3 +1,17 @@
+2012-01-26  Ojan Vafai  <[email protected]>
+
+        Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
+        https://bugs.webkit.org/show_bug.cgi?id=77164
+
+        Reviewed by Dirk Pranke.
+
+        http://trac.webkit.org/changeset/106035 depends on builder_name being
+        falsey by default. There's other code that requires it to be iterable
+        by default. So, make it be the empty string.
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+        (parse_args):
+
 2012-01-26  Ryosuke Niwa  <[email protected]>
 
         run-perf-test should include relative file paths in test names

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (106065 => 106066)


--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2012-01-27 01:08:15 UTC (rev 106065)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2012-01-27 01:14:06 UTC (rev 106066)
@@ -435,7 +435,7 @@
     # FIXME: Move these into json_results_generator.py
     results_json_options = [
         optparse.make_option("--master-name", help="The name of the buildbot master."),
-        optparse.make_option("--builder-name", default="DUMMY_BUILDER_NAME",
+        optparse.make_option("--builder-name", default="",
             help=("The name of the builder shown on the waterfall running "
                   "this script e.g. WebKit.")),
         optparse.make_option("--build-name", default="DUMMY_BUILD_NAME",
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to