Title: [106059] trunk/Source/WebCore
- Revision
- 106059
- Author
- [email protected]
- Date
- 2012-01-26 16:07:11 -0800 (Thu, 26 Jan 2012)
Log Message
IndexedDB: WebCore::IDBKey objects are leaked
https://bugs.webkit.org/show_bug.cgi?id=77114
Reviewed by Tony Chang.
Fixing memory leaks, no new tests.
* storage/IDBKey.h:
(WebCore::IDBKey::createInvalid):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createArray):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (106058 => 106059)
--- trunk/Source/WebCore/ChangeLog 2012-01-27 00:03:23 UTC (rev 106058)
+++ trunk/Source/WebCore/ChangeLog 2012-01-27 00:07:11 UTC (rev 106059)
@@ -1,3 +1,19 @@
+2012-01-26 Joshua Bell <[email protected]>
+
+ IndexedDB: WebCore::IDBKey objects are leaked
+ https://bugs.webkit.org/show_bug.cgi?id=77114
+
+ Reviewed by Tony Chang.
+
+ Fixing memory leaks, no new tests.
+
+ * storage/IDBKey.h:
+ (WebCore::IDBKey::createInvalid):
+ (WebCore::IDBKey::createNumber):
+ (WebCore::IDBKey::createString):
+ (WebCore::IDBKey::createDate):
+ (WebCore::IDBKey::createArray):
+
2012-01-25 Cris Neckar <[email protected]>
Add a scheme registry for CORS requests. Allow simple CORS requests to be made to registered schemes.
Modified: trunk/Source/WebCore/storage/IDBKey.h (106058 => 106059)
--- trunk/Source/WebCore/storage/IDBKey.h 2012-01-27 00:03:23 UTC (rev 106058)
+++ trunk/Source/WebCore/storage/IDBKey.h 2012-01-27 00:07:11 UTC (rev 106059)
@@ -41,14 +41,14 @@
static PassRefPtr<IDBKey> createInvalid()
{
- RefPtr<IDBKey> idbKey(new IDBKey());
+ RefPtr<IDBKey> idbKey = adoptRef(new IDBKey());
idbKey->m_type = InvalidType;
return idbKey.release();
}
static PassRefPtr<IDBKey> createNumber(double number)
{
- RefPtr<IDBKey> idbKey(new IDBKey());
+ RefPtr<IDBKey> idbKey = adoptRef(new IDBKey());
idbKey->m_type = NumberType;
idbKey->m_number = number;
idbKey->m_sizeEstimate += sizeof(double);
@@ -57,7 +57,7 @@
static PassRefPtr<IDBKey> createString(const String& string)
{
- RefPtr<IDBKey> idbKey(new IDBKey());
+ RefPtr<IDBKey> idbKey = adoptRef(new IDBKey());
idbKey->m_type = StringType;
idbKey->m_string = string;
idbKey->m_sizeEstimate += string.length() * sizeof(UChar);
@@ -66,7 +66,7 @@
static PassRefPtr<IDBKey> createDate(double date)
{
- RefPtr<IDBKey> idbKey(new IDBKey());
+ RefPtr<IDBKey> idbKey = adoptRef(new IDBKey());
idbKey->m_type = DateType;
idbKey->m_date = date;
idbKey->m_sizeEstimate += sizeof(double);
@@ -75,7 +75,7 @@
static PassRefPtr<IDBKey> createArray(const KeyArray& array)
{
- RefPtr<IDBKey> idbKey(new IDBKey());
+ RefPtr<IDBKey> idbKey = adoptRef(new IDBKey());
idbKey->m_type = ArrayType;
idbKey->m_array = array;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes