Title: [277896] trunk
Revision
277896
Author
dp...@igalia.com
Date
2021-05-21 16:04:16 -0700 (Fri, 21 May 2021)

Log Message

Set CanvasImageSmoothing.imageSmoothingQuality value to 'low' as default
https://bugs.webkit.org/show_bug.cgi?id=225952

Reviewed by Sam Weinig.

Source/WebCore:

Covered by existing tests:
  - inspector/canvas/recording-2d-frameCount.html
  - inspector/canvas/recording-2d-full.html
  - inspector/canvas/recording-2d-memoryLimit.html
  - inspector/canvas/recording-2d-saves.html
  - inspector/canvas/recording-html-2d.html

* html/canvas/CanvasRenderingContext2DBase.cpp:

LayoutTests:

Defined by spec:
https://html.spec.whatwg.org/multipage/canvas.html#canvasimagesmoothing

* platform/gtk/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (277895 => 277896)


--- trunk/LayoutTests/ChangeLog	2021-05-21 22:46:29 UTC (rev 277895)
+++ trunk/LayoutTests/ChangeLog	2021-05-21 23:04:16 UTC (rev 277896)
@@ -1,3 +1,15 @@
+2021-05-21  Diego Pino Garcia  <dp...@igalia.com>
+
+        Set CanvasImageSmoothing.imageSmoothingQuality value to 'low' as default
+        https://bugs.webkit.org/show_bug.cgi?id=225952
+
+        Reviewed by Sam Weinig.
+
+        Defined by spec:
+        https://html.spec.whatwg.org/multipage/canvas.html#canvasimagesmoothing
+
+        * platform/gtk/TestExpectations:
+
 2021-05-21  Jonathan Bedard  <jbed...@apple.com>
 
         [LayoutTests] Delete unused LayoutTests/svg resources

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (277895 => 277896)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2021-05-21 22:46:29 UTC (rev 277895)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2021-05-21 23:04:16 UTC (rev 277896)
@@ -1224,9 +1224,6 @@
 webkit.org/b/197507 imported/blink/compositing/repaint/end-of-opacity-transition.html [ Timeout Pass ]
 webkit.org/b/197507 imported/blink/css3/calc/transition-asan-crash.html [ Timeout Pass ]
 
-webkit.org/b/175662 inspector/canvas/recording-2d-frameCount.html [ Failure ]
-webkit.org/b/175662 inspector/canvas/recording-2d-full.html [ Failure ]
-webkit.org/b/175662 inspector/canvas/recording-2d-memoryLimit.html [ Failure ]
 
 webkit.org/b/197713 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-image-cache.https.html [ Pass Failure ]
 
@@ -2053,7 +2050,6 @@
 
 webkit.org/b/195259 compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html [ ImageOnlyFailure ]
 
-webkit.org/b/195712 inspector/canvas/recording-html-2d.html [ Failure ]
 
 webkit.org/b/196061 editing/pasteboard/smart-paste-paragraph-001.html [ Failure ]
 webkit.org/b/196061 editing/pasteboard/smart-paste-paragraph-002.html [ Failure ]
@@ -2119,7 +2115,6 @@
 
 webkit.org/b/223980 editing/deleting/insert-in-orphaned-selection-crash.html [ Failure ]
 
-webkit.org/b/223981 inspector/canvas/recording-2d-saves.html [ Failure ]
 
 webkit.org/b/224062 webgl/1.0.3/conformance/glsl/misc/shaders-with-missing-varyings.html [ Failure ]
 webkit.org/b/224062 webgl/1.0.3/conformance/glsl/misc/shaders-with-varyings.html [ Failure ]

Modified: trunk/Source/WebCore/ChangeLog (277895 => 277896)


--- trunk/Source/WebCore/ChangeLog	2021-05-21 22:46:29 UTC (rev 277895)
+++ trunk/Source/WebCore/ChangeLog	2021-05-21 23:04:16 UTC (rev 277896)
@@ -1,3 +1,19 @@
+2021-05-21  Diego Pino Garcia  <dp...@igalia.com>
+
+        Set CanvasImageSmoothing.imageSmoothingQuality value to 'low' as default
+        https://bugs.webkit.org/show_bug.cgi?id=225952
+
+        Reviewed by Sam Weinig.
+
+        Covered by existing tests:
+          - inspector/canvas/recording-2d-frameCount.html
+          - inspector/canvas/recording-2d-full.html
+          - inspector/canvas/recording-2d-memoryLimit.html
+          - inspector/canvas/recording-2d-saves.html
+          - inspector/canvas/recording-html-2d.html
+
+        * html/canvas/CanvasRenderingContext2DBase.cpp:
+
 2021-05-21  Chris Dumez  <cdu...@apple.com>
 
         Adopt CheckedLock in ScrollingTree and fix threading bug

Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp (277895 => 277896)


--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp	2021-05-21 22:46:29 UTC (rev 277895)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp	2021-05-21 23:04:16 UTC (rev 277896)
@@ -82,11 +82,7 @@
 
 WTF_MAKE_ISO_ALLOCATED_IMPL(CanvasRenderingContext2DBase);
 
-#if USE(CG)
 static constexpr ImageSmoothingQuality defaultSmoothingQuality = ImageSmoothingQuality::Low;
-#else
-static constexpr ImageSmoothingQuality defaultSmoothingQuality = ImageSmoothingQuality::Medium;
-#endif
 
 const int CanvasRenderingContext2DBase::DefaultFontSize = 10;
 const char* const CanvasRenderingContext2DBase::DefaultFontFamily = "sans-serif";
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to