Title: [277868] trunk
- Revision
- 277868
- Author
- commit-qu...@webkit.org
- Date
- 2021-05-21 10:16:20 -0700 (Fri, 21 May 2021)
Log Message
grid track size should reject unitless length
https://bugs.webkit.org/show_bug.cgi?id=189137
Patch by Rob Buis <rb...@igalia.com> on 2021-05-21
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Update improved test result.
* web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt:
Source/WebCore:
Reject unitless length's for grid track sizes in quirks mode.
Behavior matches Chrome and Firefox.
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeGridBreadth):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (277867 => 277868)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-05-21 17:07:44 UTC (rev 277867)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-05-21 17:16:20 UTC (rev 277868)
@@ -1,3 +1,14 @@
+2021-05-21 Rob Buis <rb...@igalia.com>
+
+ grid track size should reject unitless length
+ https://bugs.webkit.org/show_bug.cgi?id=189137
+
+ Reviewed by Sergio Villar Senin.
+
+ Update improved test result.
+
+ * web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt:
+
2021-05-20 Alexey Shvayka <shvaikal...@gmail.com>
[WebIDL] Remove [ImplicitThis] and [CustomProxyToJSObject] extended attributes
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt (277867 => 277868)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt 2021-05-21 17:07:44 UTC (rev 277867)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt 2021-05-21 17:16:20 UTC (rev 277868)
@@ -10,10 +10,10 @@
PASS Property column-rule-width does not support quirky length
PASS Property column-width does not support quirky length
PASS Property flex-basis does not support quirky length
-FAIL Property grid-auto-columns does not support quirky length assert_equals: expected "567px" but got "1234px"
-FAIL Property grid-auto-rows does not support quirky length assert_equals: expected "567px" but got "1234px"
-FAIL Property grid-template-columns does not support quirky length assert_equals: expected "567px" but got "1234px"
-FAIL Property grid-template-rows does not support quirky length assert_equals: expected "567px" but got "1234px"
+PASS Property grid-auto-columns does not support quirky length
+PASS Property grid-auto-rows does not support quirky length
+PASS Property grid-template-columns does not support quirky length
+PASS Property grid-template-rows does not support quirky length
PASS Property inline-size does not support quirky length
PASS Property inset does not support quirky length
PASS Property inset-block does not support quirky length
Modified: trunk/Source/WebCore/ChangeLog (277867 => 277868)
--- trunk/Source/WebCore/ChangeLog 2021-05-21 17:07:44 UTC (rev 277867)
+++ trunk/Source/WebCore/ChangeLog 2021-05-21 17:16:20 UTC (rev 277868)
@@ -1,3 +1,17 @@
+2021-05-21 Rob Buis <rb...@igalia.com>
+
+ grid track size should reject unitless length
+ https://bugs.webkit.org/show_bug.cgi?id=189137
+
+ Reviewed by Sergio Villar Senin.
+
+ Reject unitless length's for grid track sizes in quirks mode.
+
+ Behavior matches Chrome and Firefox.
+
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::consumeGridBreadth):
+
2021-05-21 Jer Noble <jer.no...@apple.com>
[Cocoa] Last few seconds of 'audio/webm; codecs=vorbis' appended to a SampleBuffer are not played
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (277867 => 277868)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-05-21 17:07:44 UTC (rev 277867)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-05-21 17:16:20 UTC (rev 277868)
@@ -3440,7 +3440,7 @@
return nullptr;
return CSSPrimitiveValue::create(range.consumeIncludingWhitespace().numericValue(), CSSUnitType::CSS_FR);
}
- return consumeLengthOrPercent(range, cssParserMode, ValueRange::NonNegative, UnitlessQuirk::Allow);
+ return consumeLengthOrPercent(range, cssParserMode, ValueRange::NonNegative);
}
static RefPtr<CSSValue> consumeGridTrackSize(CSSParserTokenRange& range, CSSParserMode cssParserMode)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
