Title: [277759] trunk/Source/_javascript_Core
- Revision
- 277759
- Author
- mark....@apple.com
- Date
- 2021-05-19 15:39:45 -0700 (Wed, 19 May 2021)
Log Message
Speed up debug validation in CacheableIdentifier::createFromIdentifierOwnedByCodeBlock().
https://bugs.webkit.org/show_bug.cgi?id=225948
Not reviewed.
Build fix after r277727.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::hasIdentifier):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (277758 => 277759)
--- trunk/Source/_javascript_Core/ChangeLog 2021-05-19 22:30:16 UTC (rev 277758)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-05-19 22:39:45 UTC (rev 277759)
@@ -1,5 +1,17 @@
2021-05-19 Mark Lam <mark....@apple.com>
+ Speed up debug validation in CacheableIdentifier::createFromIdentifierOwnedByCodeBlock().
+ https://bugs.webkit.org/show_bug.cgi?id=225948
+
+ Not reviewed.
+
+ Build fix after r277727.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::hasIdentifier):
+
+2021-05-19 Mark Lam <mark....@apple.com>
+
Ripping out broken Baseline JIT rare case profiling.
https://bugs.webkit.org/show_bug.cgi?id=225983
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (277758 => 277759)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2021-05-19 22:30:16 UTC (rev 277758)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2021-05-19 22:39:45 UTC (rev 277759)
@@ -2887,8 +2887,12 @@
{
UnlinkedCodeBlock* unlinkedCode = m_unlinkedCode.get();
size_t unlinkedIdentifiers = unlinkedCode->numberOfIdentifiers();
+#if ENABLE(DFG_JIT)
size_t numberOfDFGIdentifiers = this->numberOfDFGIdentifiers();
size_t numberOfIdentifiers = unlinkedIdentifiers + numberOfDFGIdentifiers;
+#else
+ size_t numberOfIdentifiers = unlinkedIdentifiers;
+#endif
if (numberOfIdentifiers > 100) {
if (m_cachedIdentifierUids.size() != numberOfIdentifiers) {
@@ -2900,6 +2904,7 @@
const Identifier& identifier = unlinkedCode->identifier(index);
cachedIdentifierUids.add(identifier.impl());
}
+#if ENABLE(DFG_JIT)
if (numberOfDFGIdentifiers) {
ASSERT(JITCode::isOptimizingJIT(jitType()));
auto& dfgIdentifiers = m_jitCode->dfgCommon()->m_dfgIdentifiers;
@@ -2908,6 +2913,7 @@
cachedIdentifierUids.add(identifier.impl());
}
}
+#endif
WTF::storeStoreFence();
m_cachedIdentifierUids = WTFMove(cachedIdentifierUids);
}
@@ -2919,6 +2925,7 @@
if (identifier.impl() == uid)
return true;
}
+#if ENABLE(DFG_JIT)
ASSERT(JITCode::isOptimizingJIT(jitType()));
auto& dfgIdentifiers = m_jitCode->dfgCommon()->m_dfgIdentifiers;
for (unsigned index = 0; index < numberOfDFGIdentifiers; ++index) {
@@ -2926,6 +2933,7 @@
if (identifier.impl() == uid)
return true;
}
+#endif
return false;
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
