Title: [276176] trunk
- Revision
- 276176
- Author
- [email protected]
- Date
- 2021-04-16 15:50:31 -0700 (Fri, 16 Apr 2021)
Log Message
Disable app-bound request API tests on specific OS versions
https://bugs.webkit.org/show_bug.cgi?id=223692
<rdar://problem/75787288>
Reviewed by Brent Fulgham.
Source/WTF:
* wtf/PlatformEnableCocoa.h:
Tools:
These test rely on internal additions only available on certain OS
versions. We should disable them on other versions.
* TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (276175 => 276176)
--- trunk/Source/WTF/ChangeLog 2021-04-16 22:28:44 UTC (rev 276175)
+++ trunk/Source/WTF/ChangeLog 2021-04-16 22:50:31 UTC (rev 276176)
@@ -1,3 +1,13 @@
+2021-04-16 Kate Cheney <[email protected]>
+
+ Disable app-bound request API tests on specific OS versions
+ https://bugs.webkit.org/show_bug.cgi?id=223692
+ <rdar://problem/75787288>
+
+ Reviewed by Brent Fulgham.
+
+ * wtf/PlatformEnableCocoa.h:
+
2021-04-16 Alex Christensen <[email protected]>
Disable ApplicationCache with linkedOnOrAfter check
Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (276175 => 276176)
--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-04-16 22:28:44 UTC (rev 276175)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-04-16 22:50:31 UTC (rev 276176)
@@ -657,3 +657,9 @@
#if !defined(ENABLE_NOTIFY_FILTERING) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000
#define ENABLE_NOTIFY_FILTERING 1
#endif
+
+#if !defined(ENABLE_APP_BOUND_REQUESTS) \
+ && ((PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) \
+ || ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000)))
+#define ENABLE_APP_BOUND_REQUESTS 1
+#endif
Modified: trunk/Tools/ChangeLog (276175 => 276176)
--- trunk/Tools/ChangeLog 2021-04-16 22:28:44 UTC (rev 276175)
+++ trunk/Tools/ChangeLog 2021-04-16 22:50:31 UTC (rev 276176)
@@ -1,3 +1,16 @@
+2021-04-16 Kate Cheney <[email protected]>
+
+ Disable app-bound request API tests on specific OS versions
+ https://bugs.webkit.org/show_bug.cgi?id=223692
+ <rdar://problem/75787288>
+
+ Reviewed by Brent Fulgham.
+
+ These test rely on internal additions only available on certain OS
+ versions. We should disable them on other versions.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
+
2021-04-16 Alex Christensen <[email protected]>
Disable ApplicationCache with linkedOnOrAfter check
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm (276175 => 276176)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm 2021-04-16 22:28:44 UTC (rev 276175)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm 2021-04-16 22:50:31 UTC (rev 276176)
@@ -1420,7 +1420,7 @@
#endif // ENABLE(APP_BOUND_DOMAINS)
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && ENABLE(APP_BOUND_REQUESTS)
TEST(InAppBrowserPrivacy, AppBoundRequest)
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
