Title: [276166] trunk/LayoutTests
- Revision
- 276166
- Author
- [email protected]
- Date
- 2021-04-16 13:55:48 -0700 (Fri, 16 Apr 2021)
Log Message
[BigSur wk1] svg/canvas/canvas-global-alpha-svg.html is flakey failing
https://bugs.webkit.org/show_bug.cgi?id=221559
<rdar://problem/74104075>
Reviewed by Daniel Bates.
By default, aliasing is applied when drawing the SVGImage to the canvas
through CanvasRenderingContext2D::drawImage() and when drawing the canvas
itself to DOM container through ImageBuffer::draw(). Because the test
includes only rectangles, we need to make sure the edges of the SVG image
and the canvas in this test get pixelated. This will match the expected
page which uses DOM objects to mimic the SVG and canvas drawing
Make sure the test is ended only after the SVG image is fully loaded.
* platform/ios/TestExpectations:
* platform/mac-wk1/TestExpectations:
* svg/canvas/canvas-global-alpha-svg.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (276165 => 276166)
--- trunk/LayoutTests/ChangeLog 2021-04-16 20:54:58 UTC (rev 276165)
+++ trunk/LayoutTests/ChangeLog 2021-04-16 20:55:48 UTC (rev 276166)
@@ -1,3 +1,24 @@
+2021-04-16 Said Abou-Hallawa <[email protected]>
+
+ [BigSur wk1] svg/canvas/canvas-global-alpha-svg.html is flakey failing
+ https://bugs.webkit.org/show_bug.cgi?id=221559
+ <rdar://problem/74104075>
+
+ Reviewed by Daniel Bates.
+
+ By default, aliasing is applied when drawing the SVGImage to the canvas
+ through CanvasRenderingContext2D::drawImage() and when drawing the canvas
+ itself to DOM container through ImageBuffer::draw(). Because the test
+ includes only rectangles, we need to make sure the edges of the SVG image
+ and the canvas in this test get pixelated. This will match the expected
+ page which uses DOM objects to mimic the SVG and canvas drawing
+
+ Make sure the test is ended only after the SVG image is fully loaded.
+
+ * platform/ios/TestExpectations:
+ * platform/mac-wk1/TestExpectations:
+ * svg/canvas/canvas-global-alpha-svg.html:
+
2021-04-16 Robert Jenner <[email protected]>
N[ wk2 ] media/presentationmodechanged-fired-once.html is a flakey timeout
Modified: trunk/LayoutTests/platform/ios/TestExpectations (276165 => 276166)
--- trunk/LayoutTests/platform/ios/TestExpectations 2021-04-16 20:54:58 UTC (rev 276165)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2021-04-16 20:55:48 UTC (rev 276166)
@@ -1133,7 +1133,6 @@
# Difference of less 0.03% between images.
svg/as-image/svg-image-with-data-uri-from-canvas.html [ ImageOnlyFailure ]
-svg/canvas/canvas-global-alpha-svg.html [ ImageOnlyFailure ]
svg/clip-path/clip-path-line-use-before-defined.svg [ ImageOnlyFailure ]
# SVG
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (276165 => 276166)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-04-16 20:54:58 UTC (rev 276165)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-04-16 20:55:48 UTC (rev 276166)
@@ -1256,8 +1256,6 @@
webkit.org/b/221506 [ BigSur ] svg/clip-path/resource-clipper-multiple-repaints.html [ Pass ImageOnlyFailure ]
-webkit.org/b/221559 [ BigSur ] svg/canvas/canvas-global-alpha-svg.html [ Pass ImageOnlyFailure ]
-
webkit.org/b/222493 [ BigSur ] platform/mac-bigsur/media/media-source/media-source-webm-vp8-malformed-header.html [ Skip ]
webkit.org/b/221819 [ Debug ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html [ Pass Failure ]
Modified: trunk/LayoutTests/svg/canvas/canvas-global-alpha-svg.html (276165 => 276166)
--- trunk/LayoutTests/svg/canvas/canvas-global-alpha-svg.html 2021-04-16 20:54:58 UTC (rev 276165)
+++ trunk/LayoutTests/svg/canvas/canvas-global-alpha-svg.html 2021-04-16 20:55:48 UTC (rev 276166)
@@ -1,8 +1,16 @@
<!DOCTYPE html>
<html>
+<style>
+ canvas, svg {
+ image-rendering: pixelated;
+ }
+</style>
<body>
<canvas id="canvas"></canvas>
- <script>
+ <script>
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
var canvas = document.getElementById("canvas");
canvas.width = 150;
canvas.height = 150;
@@ -15,7 +23,9 @@
var svgImage = new Image();
svgImage._onload_ = function() {
context.globalAlpha = 0.2;
- context.drawImage(svgImage, 25, 25);
+ context.drawImage(svgImage, 25, 25);
+ if (window.testRunner)
+ testRunner.notifyDone();
};
svgImage.src = "" \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
