Title: [105835] trunk/Tools
- Revision
- 105835
- Author
- [email protected]
- Date
- 2012-01-24 17:03:34 -0800 (Tue, 24 Jan 2012)
Log Message
webkitpy: new-run-webkit-httpd is broken
https://bugs.webkit.org/show_bug.cgi?id=76963
Reviewed by Adam Barth.
r105674 broke new-run-webkit-httpd, since options.chromium
doesn't exist any more. We didn't catch this because we don't
run the integration tests by default anywhere :(.
* Scripts/new-run-webkit-httpd:
(run):
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (105834 => 105835)
--- trunk/Tools/ChangeLog 2012-01-25 00:56:23 UTC (rev 105834)
+++ trunk/Tools/ChangeLog 2012-01-25 01:03:34 UTC (rev 105835)
@@ -1,3 +1,18 @@
+2012-01-24 Dirk Pranke <[email protected]>
+
+ webkitpy: new-run-webkit-httpd is broken
+ https://bugs.webkit.org/show_bug.cgi?id=76963
+
+ Reviewed by Adam Barth.
+
+ r105674 broke new-run-webkit-httpd, since options.chromium
+ doesn't exist any more. We didn't catch this because we don't
+ run the integration tests by default anywhere :(.
+
+ * Scripts/new-run-webkit-httpd:
+ (run):
+ (main):
+
2012-01-24 Adam Barth <[email protected]>
garden-o-matic pixel zoomer should let you look at every pixel of the image
Modified: trunk/Tools/Scripts/new-run-webkit-httpd (105834 => 105835)
--- trunk/Tools/Scripts/new-run-webkit-httpd 2012-01-25 00:56:23 UTC (rev 105834)
+++ trunk/Tools/Scripts/new-run-webkit-httpd 2012-01-25 01:03:34 UTC (rev 105835)
@@ -60,7 +60,8 @@
# meaningful.
raise 'Specifying port requires also a root.'
host = Host()
- port_obj = host.port_factory.get(options=options)
+ # FIXME: Make this work with other ports as well.
+ port_obj = host.port_factory.get(port_name='chromium', options=options)
httpd = http_server.Lighttpd(port_obj,
tempfile.gettempdir(),
port=options.port,
@@ -91,9 +92,6 @@
help='Absolute path to LayoutTests root')
options, args = option_parser.parse_args()
- # FIXME: Make this work with other ports as well.
- options.chromium = True
-
run(options)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
