Title: [105793] trunk/Tools
- Revision
- 105793
- Author
- [email protected]
- Date
- 2012-01-24 13:20:47 -0800 (Tue, 24 Jan 2012)
Log Message
r105674 broke check-webkit-style for chromium's test_expectations.
Unreviewed, build fix.
We now need to pass in a platform name of 'chromium' if we want
the chromium port; options.chromium is no longer recognized. I
will follow this patch up with a separate patch that has a test,
but this at least fixes the build.
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_exepectations_path):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (105792 => 105793)
--- trunk/Tools/ChangeLog 2012-01-24 21:18:50 UTC (rev 105792)
+++ trunk/Tools/ChangeLog 2012-01-24 21:20:47 UTC (rev 105793)
@@ -1,3 +1,17 @@
+2012-01-24 Dirk Pranke <[email protected]>
+
+ r105674 broke check-webkit-style for chromium's test_expectations.
+
+ Unreviewed, build fix.
+
+ We now need to pass in a platform name of 'chromium' if we want
+ the chromium port; options.chromium is no longer recognized. I
+ will follow this patch up with a separate patch that has a test,
+ but this at least fixes the build.
+
+ * Scripts/webkitpy/style/checkers/test_expectations.py:
+ (TestExpectationsChecker._determine_port_from_exepectations_path):
+
2012-01-20 Ojan Vafai <[email protected]>
check-webkit-style of the chromium test_expectations.txt file takes too long
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations.py (105792 => 105793)
--- trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations.py 2012-01-24 21:18:50 UTC (rev 105792)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations.py 2012-01-24 21:20:47 UTC (rev 105793)
@@ -49,15 +49,11 @@
def _determine_port_from_exepectations_path(self, host, expectations_path):
try:
- # I believe what this is trying to do is "when the port name is chromium,
- # get the chromium-port for this platform". Unclear why that's needed??
port_name = expectations_path.split(host.filesystem.sep)[-2]
if not port_name:
return None
# Pass a configuration to avoid calling default_configuration() when initializing the port (takes 0.5 seconds on a Mac Pro!).
- if port_name == "chromium":
- return host.port_factory.get(options=DummyOptions(chromium=True, configuration="Release"))
return host.port_factory.get(port_name, options=DummyOptions(configuration="Release"))
except Exception, e:
_log.warn("Exception while getting port for path %s" % expectations_path)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
