Title: [105761] trunk/Source/WebCore
- Revision
- 105761
- Author
- [email protected]
- Date
- 2012-01-24 11:25:00 -0800 (Tue, 24 Jan 2012)
Log Message
[Refactoring] Remove finish() from all CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=76918
Reviewed by Darin Adler.
Now finish() is empty in all CodeGenerator*.pm. This patch removes them.
No tests. No change in behavior.
* bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
* bindings/scripts/CodeGeneratorCPP.pm:
* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (105760 => 105761)
--- trunk/Source/WebCore/ChangeLog 2012-01-24 19:07:34 UTC (rev 105760)
+++ trunk/Source/WebCore/ChangeLog 2012-01-24 19:25:00 UTC (rev 105761)
@@ -1,3 +1,22 @@
+2012-01-24 Kentaro Hara <[email protected]>
+
+ [Refactoring] Remove finish() from all CodeGenerator*.pm
+ https://bugs.webkit.org/show_bug.cgi?id=76918
+
+ Reviewed by Darin Adler.
+
+ Now finish() is empty in all CodeGenerator*.pm. This patch removes them.
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGenerator.pm:
+ (ProcessDocument):
+ * bindings/scripts/CodeGeneratorCPP.pm:
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ * bindings/scripts/CodeGeneratorV8.pm:
+
2012-01-24 Vsevolod Vlasov <[email protected]>
Web Inspector: incorrect highlight position when searching in console
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (105760 => 105761)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-01-24 19:07:34 UTC (rev 105760)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-01-24 19:25:00 UTC (rev 105761)
@@ -147,8 +147,6 @@
print "Generating $useGenerator bindings code for IDL interface \"" . $class->name . "\"...\n" if $verbose;
$codeGenerator->GenerateInterface($class, $defines);
}
-
- $codeGenerator->finish();
}
sub FileNamePrefix
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm (105760 => 105761)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm 2012-01-24 19:07:34 UTC (rev 105760)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm 2012-01-24 19:25:00 UTC (rev 105761)
@@ -107,11 +107,6 @@
return $reference;
}
-sub finish
-{
- my $object = shift;
-}
-
# Params: 'domClass' struct
sub GenerateInterface
{
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (105760 => 105761)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2012-01-24 19:07:34 UTC (rev 105760)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2012-01-24 19:25:00 UTC (rev 105761)
@@ -51,9 +51,6 @@
bless($reference, $object);
}
-sub finish {
-}
-
my $licenceTemplate = << "EOF";
/*
This file is part of the WebKit open source project.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (105760 => 105761)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-01-24 19:07:34 UTC (rev 105760)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-01-24 19:25:00 UTC (rev 105761)
@@ -88,12 +88,6 @@
return $reference;
}
-# FIXME(haraken): finish() will be soon removed from all CodeGenerators.
-sub finish
-{
- my $object = shift;
-}
-
sub leftShift($$) {
my ($value, $distance) = @_;
return (($value << $distance) & 0xFFFFFFFF);
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (105760 => 105761)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2012-01-24 19:07:34 UTC (rev 105760)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2012-01-24 19:25:00 UTC (rev 105761)
@@ -208,11 +208,6 @@
return $reference;
}
-sub finish
-{
- my $object = shift;
-}
-
sub ReadPublicInterfaces
{
my $class = shift;
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (105760 => 105761)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-01-24 19:07:34 UTC (rev 105760)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-01-24 19:25:00 UTC (rev 105761)
@@ -85,12 +85,6 @@
return $reference;
}
-# FIXME(haraken): finish() will be soon removed from all CodeGenerators.
-sub finish
-{
- my $object = shift;
-}
-
# Params: 'domClass' struct
sub GenerateInterface
{
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
