Title: [273724] trunk
- Revision
- 273724
- Author
- hironori.fu...@sony.com
- Date
- 2021-03-01 22:59:14 -0800 (Mon, 01 Mar 2021)
Log Message
[GTK] Web inspector related tests very slow or timeout in debug mode
https://bugs.webkit.org/show_bug.cgi?id=208000
Reviewed by Carlos Garcia Campos.
Source/WebKit:
setTimeout was very slow in the inspector page because it was
throttled by 1 second due to that the page is hidden. Mac port
disables HiddenPageDOMTimerThrottlingEnabled for the inspector
page under testing. Do the same for GTK port.
* UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateFrontendPage):
setHiddenPageDOMTimerThrottlingEnabled(false) if under test.
LayoutTests:
* platform/gtk/TestExpectations: Unmarked tests for Bug 149916 and Bug 208000.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (273723 => 273724)
--- trunk/LayoutTests/ChangeLog 2021-03-02 05:00:55 UTC (rev 273723)
+++ trunk/LayoutTests/ChangeLog 2021-03-02 06:59:14 UTC (rev 273724)
@@ -1,3 +1,12 @@
+2021-03-01 Fujii Hironori <hironori.fu...@sony.com>
+
+ [GTK] Web inspector related tests very slow or timeout in debug mode
+ https://bugs.webkit.org/show_bug.cgi?id=208000
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/gtk/TestExpectations: Unmarked tests for Bug 149916 and Bug 208000.
+
2021-03-01 Lauro Moura <lmo...@igalia.com>
[GLIB] Gardening three common timeouts
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (273723 => 273724)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2021-03-02 05:00:55 UTC (rev 273723)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2021-03-02 06:59:14 UTC (rev 273724)
@@ -1634,63 +1634,6 @@
webkit.org/b/116958 http/tests/navigation/slowmetaredirect-basic.html [ Pass Slow ]
webkit.org/b/116958 http/tests/navigation/slowtimerredirect-basic.html [ Pass Slow ]
-webkit.org/b/149916 http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html [ Pass Slow ]
-webkit.org/b/149916 inspector/console/clearMessages.html [ Pass Slow ]
-webkit.org/b/149916 inspector/console/command-line-api.html [ Pass Slow ]
-webkit.org/b/149916 inspector/console/console-api.html [ Pass Timeout ]
-webkit.org/b/149916 inspector/console/console-table.html [ Pass Slow ]
-webkit.org/b/149916 inspector/console/js-isLikelyStackTrace.html [ Pass Slow ]
-webkit.org/b/149916 inspector/console/messageRepeatCountUpdated.html [ Pass Slow ]
-webkit.org/b/149916 inspector/console/messagesCleared.html [ Pass Slow ]
-webkit.org/b/149916 inspector/controller/runtime-controller.html [ Pass Slow ]
-webkit.org/b/149916 inspector/css/createStyleSheet.html [ Pass Slow Failure ]
-webkit.org/b/149916 [ Release ] inspector/css/css-property.html [ Failure Pass ]
-webkit.org/b/149916 inspector/css/get-system-fonts.html [ Pass Slow ]
-webkit.org/b/149916 inspector/css/manager-preferredInspectorStyleSheetForFrame.html [ Pass Slow ]
-webkit.org/b/149916 inspector/css/matched-style-properties.html [ Pass Slow ]
-webkit.org/b/149916 inspector/css/pseudo-element-matches-for-pseudo-element-node.html [ Pass Slow ]
-webkit.org/b/149916 inspector/css/stylesheet-events-basic.html [ Pass Slow ]
-webkit.org/b/149916 inspector/css/stylesheet-events-imports.html [ Pass Slow ]
-webkit.org/b/149916 inspector/css/stylesheet-events-inspector-stylesheet.html [ Pass Slow ]
-webkit.org/b/149916 inspector/css/stylesheet-events-multiple-documents.html [ Pass Slow ]
-webkit.org/b/149916 inspector/css/stylesheet-with-mutations.html [ Pass Slow ]
-webkit.org/b/149916 inspector/heap/garbageCollected.html [ Pass Slow ]
-webkit.org/b/149916 inspector/heap/gc.html [ Pass Slow ]
-webkit.org/b/149916 inspector/network/client-blocked-load.html [ Pass Slow ]
-webkit.org/b/149916 inspector/page/filter-cookies-for-domain.html [ Pass Slow ]
-webkit.org/b/149916 inspector/page/main-frame-resource.html [ Pass Slow ]
-webkit.org/b/149916 inspector/protocol/inspector-backend-invocation-return-value.html [ Pass Slow ]
-webkit.org/b/149916 inspector/runtime/parse.html [ Pass Timeout ]
-webkit.org/b/149916 inspector/unit-tests/array-utilities.html [ Pass Slow ]
-webkit.org/b/149916 inspector/unit-tests/inspector-test-dispatch-event-to-frontend.html [ Pass Slow ]
-webkit.org/b/149916 inspector/unit-tests/object.html [ Pass Slow ]
-
-webkit.org/b/149916 inspector/animation/lifecycle-web-animation.html [ Pass Slow ]
-webkit.org/b/149916 inspector/debugger/probe-manager-add-remove-actions.html [ Pass Slow ]
-webkit.org/b/149916 inspector/debugger/search-scripts.html [ Pass Slow ]
-webkit.org/b/149916 inspector/dom/domutilities-xpath.html [ Pass Slow ]
-webkit.org/b/149916 inspector/dom/pseudo-element-dynamic.html [ Pass Slow ]
-webkit.org/b/149916 [ Release ] inspector/formatting/formatting-html.html [ Pass Slow ]
-webkit.org/b/149916 inspector/model/remote-object/immutable.html [ Pass Slow ]
-webkit.org/b/149916 inspector/model/remote-object/map-large.html [ Pass Slow ]
-webkit.org/b/149916 inspector/model/remote-object/map.html [ Pass Slow ]
-webkit.org/b/149916 inspector/model/remote-object/number.html [ Pass Slow ]
-webkit.org/b/149916 [ Release ] inspector/model/scope-chain-node.html [ Pass Slow ]
-webkit.org/b/149916 inspector/model/script-resource-relationship.html [ Pass Slow ]
-webkit.org/b/149916 inspector/model/stack-trace.html [ Pass Slow ]
-webkit.org/b/149916 inspector/runtime/change-execution-context-identifier.html [ Pass Slow ]
-webkit.org/b/149916 inspector/runtime/evaluate-emulateUserGesture-userIsInteracting.html [ Pass Slow ]
-webkit.org/b/149916 inspector/unit-tests/breakpoint-log-message-lexer.html [ Pass Slow ]
-webkit.org/b/149916 inspector/unit-tests/css-completions.html [ Pass Slow ]
-webkit.org/b/149916 inspector/unit-tests/diagnostic-controller.html [ Pass Slow ]
-webkit.org/b/149916 inspector/unit-tests/objectStore/basic.html [ Slow Pass ]
-webkit.org/b/149916 inspector/unit-tests/objectStore/delete.html [ Slow Pass ]
-webkit.org/b/149916 inspector/unit-tests/objectStore/deleteObject.html [ Slow Pass ]
-webkit.org/b/149916 inspector/unit-tests/objectStore/put.html [ Slow Pass ]
-webkit.org/b/149916 inspector/unit-tests/objectStore/putObject.html [ Slow Pass ]
-webkit.org/b/149916 inspector/view/basics.html [ Pass Slow ]
-webkit.org/b/149916 inspector/worker/debugger-scripts.html [ Pass Slow ]
-
webkit.org/b/186781 inspector/view/asynchronous-layout.html [ Timeout Pass ]
Bug(GTK) http/tests/misc/large-js-program.php [ Pass Slow ]
@@ -1822,25 +1765,6 @@
webkit.org/b/207711 [ Debug ] imported/w3c/web-platform-tests/web-animations/timing-model/animations/update-playback-rate-fast.html [ Timeout ]
webkit.org/b/207711 imported/blink/storage/indexeddb/blob-valid-after-deletion.html [ Failure Pass Timeout ]
-# Web inspector related tests are very slow or timeout in debug.
-webkit.org/b/208000 [ Debug ] http/tests/inspector [ Slow ]
-webkit.org/b/208000 [ Debug ] inspector [ Slow ]
-webkit.org/b/208000 [ Debug ] http/tests/inspector/network/contentextensions/blocked-websocket-crash.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] http/tests/inspector/page/loading-iframe-document-node.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/console/queryHolders.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/css/modify-css-property-race.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/css/pseudo-element-matches.html [ Failure Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/formatting/formatting-html.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/formatting/source-map-css-1.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/formatting/source-map-html-1.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/formatting/source-map-html-2.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/formatting/source-map-_javascript_-1.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/model/scope-chain-node.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/unit-tests/editing-support.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/unit-tests/server-timing-entry.html [ Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/unit-tests/throttler.html [ Failure Timeout ]
-webkit.org/b/208000 [ Debug ] inspector/unit-tests/url-utilities.html [ Timeout ]
# Timing out due to missing functionality.
webkit.org/b/212202 webkit.org/b/168189 fast/scrolling/arrow-key-scroll-in-rtl-document.html [ Skip ] # Failure Timeout.
Modified: trunk/Source/WebKit/ChangeLog (273723 => 273724)
--- trunk/Source/WebKit/ChangeLog 2021-03-02 05:00:55 UTC (rev 273723)
+++ trunk/Source/WebKit/ChangeLog 2021-03-02 06:59:14 UTC (rev 273724)
@@ -1,3 +1,19 @@
+2021-03-01 Fujii Hironori <hironori.fu...@sony.com>
+
+ [GTK] Web inspector related tests very slow or timeout in debug mode
+ https://bugs.webkit.org/show_bug.cgi?id=208000
+
+ Reviewed by Carlos Garcia Campos.
+
+ setTimeout was very slow in the inspector page because it was
+ throttled by 1 second due to that the page is hidden. Mac port
+ disables HiddenPageDOMTimerThrottlingEnabled for the inspector
+ page under testing. Do the same for GTK port.
+
+ * UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:
+ (WebKit::WebInspectorProxy::platformCreateFrontendPage):
+ setHiddenPageDOMTimerThrottlingEnabled(false) if under test.
+
2021-03-01 Chris Dumez <cdu...@apple.com>
Have WebProcessProxy::requestTermination() call processDidTerminateOrFailedToLaunch()
Modified: trunk/Source/WebKit/UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp (273723 => 273724)
--- trunk/Source/WebKit/UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp 2021-03-02 05:00:55 UTC (rev 273723)
+++ trunk/Source/WebKit/UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp 2021-03-02 06:59:14 UTC (rev 273724)
@@ -172,6 +172,8 @@
preferences->setAllowTopNavigationToDataURLs(true);
preferences->setJavaScriptRuntimeFlags({
});
+ if (m_underTest)
+ preferences->setHiddenPageDOMTimerThrottlingEnabled(false);
auto pageGroup = WebPageGroup::create(WebKit::defaultInspectorPageGroupIdentifierForPage(inspectedPage()));
auto websiteDataStore = inspectorWebsiteDataStore();
auto& processPool = WebKit::defaultInspectorProcessPool(inspectionLevel());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
