Title: [105551] trunk/Tools
Revision
105551
Author
[email protected]
Date
2012-01-20 15:47:02 -0800 (Fri, 20 Jan 2012)

Log Message

run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
https://bugs.webkit.org/show_bug.cgi?id=76748

Reviewed by Ryosuke Niwa.

It crawls the whole subtree and then doesn't use the data. Cutting this out
saves 4 seconds warm and 17 seconds cold on my Mac Pro.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (105550 => 105551)


--- trunk/Tools/ChangeLog	2012-01-20 23:36:53 UTC (rev 105550)
+++ trunk/Tools/ChangeLog	2012-01-20 23:47:02 UTC (rev 105551)
@@ -1,3 +1,16 @@
+2012-01-20  Ojan Vafai  <[email protected]>
+
+        run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
+        https://bugs.webkit.org/show_bug.cgi?id=76748
+
+        Reviewed by Ryosuke Niwa.
+
+        It crawls the whole subtree and then doesn't use the data. Cutting this out
+        saves 4 seconds warm and 17 seconds cold on my Mac Pro.
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+        (run):
+
 2012-01-20  Adam Barth  <[email protected]>
 
         Another tiny tweak to the garden-o-matic CSS.  This makes things line

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (105550 => 105551)


--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2012-01-20 23:36:53 UTC (rev 105550)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2012-01-20 23:47:02 UTC (rev 105551)
@@ -64,6 +64,9 @@
         manager = Manager(port, options, printer)
         manager.print_config()
 
+        if options.lint_test_files:
+            return manager.lint()
+
         printer.print_update("Collecting tests ...")
         try:
             manager.collect_tests(args)
@@ -72,9 +75,6 @@
                 return -1
             raise
 
-        if options.lint_test_files:
-            return manager.lint()
-
         printer.print_update("Checking build ...")
         if not port.check_build(manager.needs_servers()):
             _log.error("Build check failed")
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to