Title: [273156] trunk
- Revision
- 273156
- Author
- hironori.fu...@sony.com
- Date
- 2021-02-19 12:09:37 -0800 (Fri, 19 Feb 2021)
Log Message
A number of offscreencanvas tests are asserting isMainThread trying to access strictCSSParserContext
https://bugs.webkit.org/show_bug.cgi?id=222156
Reviewed by Carlos Garcia Campos.
Source/WebCore:
strictCSSParserContext() can be used only in the main thread.
It can't be used in parseColorWorkerSafe().
* css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseColorWorkerSafe): Use
CSSParserContext(HTMLStandardMode) instead of
strictCSSParserContext().
LayoutTests:
* platform/glib/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (273155 => 273156)
--- trunk/LayoutTests/ChangeLog 2021-02-19 20:01:31 UTC (rev 273155)
+++ trunk/LayoutTests/ChangeLog 2021-02-19 20:09:37 UTC (rev 273156)
@@ -1,3 +1,12 @@
+2021-02-19 Fujii Hironori <hironori.fu...@sony.com>
+
+ A number of offscreencanvas tests are asserting isMainThread trying to access strictCSSParserContext
+ https://bugs.webkit.org/show_bug.cgi?id=222156
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/glib/TestExpectations:
+
2021-02-19 Aditya Keerthi <akeer...@apple.com>
[iOS][FCR] Enable the new appearance by default
Modified: trunk/LayoutTests/platform/glib/TestExpectations (273155 => 273156)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-02-19 20:01:31 UTC (rev 273155)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-02-19 20:09:37 UTC (rev 273156)
@@ -664,35 +664,6 @@
webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/filter/offscreencanvas.filter.w.html [ Slow ]
webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w.html [ Slow ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.invalidstring.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.invalidtype.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/shadows/2d.shadow.attributes.shadowColor.invalid.worker.html [ Crash ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# End of OffscreenCanvas-related bugs
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Source/WebCore/ChangeLog (273155 => 273156)
--- trunk/Source/WebCore/ChangeLog 2021-02-19 20:01:31 UTC (rev 273155)
+++ trunk/Source/WebCore/ChangeLog 2021-02-19 20:09:37 UTC (rev 273156)
@@ -1,3 +1,18 @@
+2021-02-19 Fujii Hironori <hironori.fu...@sony.com>
+
+ A number of offscreencanvas tests are asserting isMainThread trying to access strictCSSParserContext
+ https://bugs.webkit.org/show_bug.cgi?id=222156
+
+ Reviewed by Carlos Garcia Campos.
+
+ strictCSSParserContext() can be used only in the main thread.
+ It can't be used in parseColorWorkerSafe().
+
+ * css/parser/CSSParser.cpp:
+ (WebCore::CSSParser::parseColorWorkerSafe): Use
+ CSSParserContext(HTMLStandardMode) instead of
+ strictCSSParserContext().
+
2021-02-19 Patrick Angle <pan...@apple.com>
Web Inspector: Implement Grid Overlay "Show line names" drawing
Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (273155 => 273156)
--- trunk/Source/WebCore/css/parser/CSSParser.cpp 2021-02-19 20:01:31 UTC (rev 273155)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp 2021-02-19 20:09:37 UTC (rev 273156)
@@ -117,7 +117,7 @@
CSSParserTokenRange range(tokenizer.tokenRange());
range.consumeWhitespace();
- return CSSPropertyParserHelpers::consumeColorWorkerSafe(range, strictCSSParserContext());
+ return CSSPropertyParserHelpers::consumeColorWorkerSafe(range, CSSParserContext(HTMLStandardMode));
}
Color CSSParser::parseSystemColor(StringView string)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
