Title: [105534] trunk/Tools
- Revision
- 105534
- Author
- [email protected]
- Date
- 2012-01-20 12:22:24 -0800 (Fri, 20 Jan 2012)
Log Message
Follow-up to previous patch: don't produce NaN when the revision number
is missing.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js (105533 => 105534)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js 2012-01-20 20:22:18 UTC (rev 105533)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js 2012-01-20 20:22:24 UTC (rev 105534)
@@ -142,6 +142,8 @@
var revision = 0;
Object.keys(model.state.resultsByBuilder).forEach(function(builderName) {
var results = model.state.resultsByBuilder[builderName];
+ if (!results.revision)
+ return;
var testedRevision = parseInt(results.revision);
revision = revision ? Math.min(revision, testedRevision) : testedRevision;
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js (105533 => 105534)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js 2012-01-20 20:22:18 UTC (rev 105533)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js 2012-01-20 20:22:24 UTC (rev 105534)
@@ -242,7 +242,7 @@
test("latestRevisionWithNoBuildersInFlight", 1, function() {
var unmock = model.state.resultsByBuilder;
model.state.resultsByBuilder = {
- 'Mr. Beasley': {revision: '5'},
+ 'Mr. Beasley': { },
'Mr Dixon': {revision: '2'},
'Mr. Sabatini': {revision: '4'},
'Bob': {revision: '6'}
Modified: trunk/Tools/ChangeLog (105533 => 105534)
--- trunk/Tools/ChangeLog 2012-01-20 20:22:18 UTC (rev 105533)
+++ trunk/Tools/ChangeLog 2012-01-20 20:22:24 UTC (rev 105534)
@@ -1,5 +1,13 @@
2012-01-20 Adam Barth <[email protected]>
+ Follow-up to previous patch: don't produce NaN when the revision number
+ is missing.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
+
+2012-01-20 Adam Barth <[email protected]>
+
Garden-o-matic should tell me which revisions have been checked by all the bots
https://bugs.webkit.org/show_bug.cgi?id=76722
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
