Title: [105530] trunk/Tools
- Revision
- 105530
- Author
- [email protected]
- Date
- 2012-01-20 11:44:14 -0800 (Fri, 20 Jan 2012)
Log Message
Garden-o-matic should tell me which revisions have been checked by all the bots
https://bugs.webkit.org/show_bug.cgi?id=76722
Reviewed by Dimitri Glazkov.
This information helps me know when it's safe for me to roll a
candidate revision.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js (105529 => 105530)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2012-01-20 19:23:16 UTC (rev 105529)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2012-01-20 19:44:14 UTC (rev 105530)
@@ -26,6 +26,7 @@
(function() {
var g_info = null;
+var g_revisionHint = null;
var g_updateTimerId = 0;
var g_buildersFailing = null;
@@ -36,6 +37,9 @@
function update()
{
+ if (g_revisionHint)
+ g_revisionHint.dismiss();
+
// FIXME: This should be a button with a progress element.
var numberOfTestsAnalyzed = 0;
var updating = new ui.notifications.Info('Loading commit data ...');
@@ -45,6 +49,7 @@
builders.buildersFailingStepRequredForTestCoverage(g_losingTestCoverageBuilders.update.bind(g_losingTestCoverageBuilders));
base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
+
updating.update('Analyzing test failures ...');
model.analyzeUnexpectedFailures(function(failureAnalysis) {
@@ -56,7 +61,11 @@
else
$('#onebar').removeClass('partytime');
g_unexpectedFailuresController.purge();
+
updating.dismiss();
+
+ g_revisionHint = new ui.notifications.Info('Latest revision processed by every bot: ' + model.latestRevisionWithNoBuildersInFlight());
+ g_info.add(g_revisionHint);
});
});
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js (105529 => 105530)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js 2012-01-20 19:23:16 UTC (rev 105529)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js 2012-01-20 19:44:14 UTC (rev 105530)
@@ -137,6 +137,17 @@
return builders;
};
+model.latestRevisionWithNoBuildersInFlight = function()
+{
+ var revision = 0;
+ Object.keys(model.state.resultsByBuilder).forEach(function(builderName) {
+ var results = model.state.resultsByBuilder[builderName];
+ var testedRevision = parseInt(results.revision);
+ revision = revision ? Math.min(revision, testedRevision) : testedRevision;
+ });
+ return revision;
+}
+
model.updateResultsByBuilder = function(callback)
{
results.fetchResultsByBuilder(Object.keys(config.kBuilders), function(resultsByBuilder) {
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js (105529 => 105530)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js 2012-01-20 19:23:16 UTC (rev 105529)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js 2012-01-20 19:44:14 UTC (rev 105530)
@@ -239,4 +239,16 @@
model.state.resultsByBuilder = unmock;
});
+test("latestRevisionWithNoBuildersInFlight", 1, function() {
+ var unmock = model.state.resultsByBuilder;
+ model.state.resultsByBuilder = {
+ 'Mr. Beasley': {revision: '5'},
+ 'Mr Dixon': {revision: '2'},
+ 'Mr. Sabatini': {revision: '4'},
+ 'Bob': {revision: '6'}
+ };
+ equals(model.latestRevisionWithNoBuildersInFlight(), 2);
+ model.state.resultsByBuilder = unmock;
+});
+
})();
Modified: trunk/Tools/ChangeLog (105529 => 105530)
--- trunk/Tools/ChangeLog 2012-01-20 19:23:16 UTC (rev 105529)
+++ trunk/Tools/ChangeLog 2012-01-20 19:44:14 UTC (rev 105530)
@@ -1,3 +1,17 @@
+2012-01-20 Adam Barth <[email protected]>
+
+ Garden-o-matic should tell me which revisions have been checked by all the bots
+ https://bugs.webkit.org/show_bug.cgi?id=76722
+
+ Reviewed by Dimitri Glazkov.
+
+ This information helps me know when it's safe for me to roll a
+ candidate revision.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
+
2012-01-20 Tor Arne Vestbø <[email protected]>
build-webkit: Don't spit out congratulations message on Ctrl+C
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
