Title: [273055] trunk/Source/WebKit
- Revision
- 273055
- Author
- katherine_che...@apple.com
- Date
- 2021-02-17 17:57:23 -0800 (Wed, 17 Feb 2021)
Log Message
Add additions to LocalConnection.mm
https://bugs.webkit.org/show_bug.cgi?id=222029
<rdar://problem/69031303>
Reviewed by Jiewen Tan.
* UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h:
* UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm:
* UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
(WebKit::LocalConnection::createCredentialPrivateKey const):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (273054 => 273055)
--- trunk/Source/WebKit/ChangeLog 2021-02-18 01:46:51 UTC (rev 273054)
+++ trunk/Source/WebKit/ChangeLog 2021-02-18 01:57:23 UTC (rev 273055)
@@ -1,3 +1,16 @@
+2021-02-17 Kate Cheney <katherine_che...@apple.com>
+
+ Add additions to LocalConnection.mm
+ https://bugs.webkit.org/show_bug.cgi?id=222029
+ <rdar://problem/69031303>
+
+ Reviewed by Jiewen Tan.
+
+ * UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h:
+ * UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm:
+ * UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
+ (WebKit::LocalConnection::createCredentialPrivateKey const):
+
2021-02-17 Fujii Hironori <hironori.fu...@sony.com>
Unreviewed, reverting r273019.
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h (273054 => 273055)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h 2021-02-18 01:46:51 UTC (rev 273054)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h 2021-02-18 01:57:23 UTC (rev 273055)
@@ -37,6 +37,7 @@
SOFT_LINK_CLASS_FOR_HEADER(WebKit, ASCPlatformPublicKeyCredentialLoginChoice);
SOFT_LINK_CLASS_FOR_HEADER(WebKit, ASCSecurityKeyPublicKeyCredentialLoginChoice);
SOFT_LINK_CLASS_FOR_HEADER(WebKit, ASCAppleIDCredential);
+SOFT_LINK_CLASS_FOR_HEADER(WebKit, ASCWebKitSPISupport);
SOFT_LINK_CONSTANT_FOR_HEADER(WebKit, AuthenticationServicesCore, ASCAuthorizationErrorDomain, NSErrorDomain);
#define ASCAuthorizationErrorDomain WebKit::get_AuthenticationServicesCore_ASCAuthorizationErrorDomain()
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm (273054 => 273055)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm 2021-02-18 01:46:51 UTC (rev 273054)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm 2021-02-18 01:57:23 UTC (rev 273055)
@@ -37,6 +37,7 @@
SOFT_LINK_CLASS_FOR_SOURCE(WebKit, AuthenticationServicesCore, ASCPlatformPublicKeyCredentialLoginChoice);
SOFT_LINK_CLASS_FOR_SOURCE(WebKit, AuthenticationServicesCore, ASCSecurityKeyPublicKeyCredentialLoginChoice);
SOFT_LINK_CLASS_FOR_SOURCE(WebKit, AuthenticationServicesCore, ASCAppleIDCredential);
+SOFT_LINK_CLASS_FOR_SOURCE(WebKit, AuthenticationServicesCore, ASCWebKitSPISupport);
SOFT_LINK_CONSTANT_FOR_SOURCE(WebKit, AuthenticationServicesCore, ASCAuthorizationErrorDomain, NSErrorDomain);
SOFT_LINK_CONSTANT_FOR_SOURCE(WebKit, AuthenticationServicesCore, ASCPINValidationResultKey, NSString*);
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm (273054 => 273055)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm 2021-02-18 01:46:51 UTC (rev 273054)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm 2021-02-18 01:57:23 UTC (rev 273055)
@@ -36,6 +36,12 @@
#import "AppAttestInternalSoftLink.h"
#import "LocalAuthenticationSoftLink.h"
+#if USE(APPLE_INTERNAL_SDK)
+#import <WebKitAdditions/LocalConnectionAdditions.h>
+#else
+#define LOCAL_CONNECTION_ADDITIONS
+#endif
+
namespace WebKit {
using namespace WebCore;
@@ -133,6 +139,7 @@
(id)kSecAttrLabel: secAttrLabel,
(id)kSecAttrApplicationTag: secAttrApplicationTag,
}};
+ LOCAL_CONNECTION_ADDITIONS
CFErrorRef errorRef = nullptr;
auto credentialPrivateKey = adoptCF(SecKeyCreateRandomKey((__bridge CFDictionaryRef)attributes, &errorRef));
auto retainError = adoptCF(errorRef);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
