Title: [272825] trunk/Source/_javascript_Core
- Revision
- 272825
- Author
- mark....@apple.com
- Date
- 2021-02-12 17:27:47 -0800 (Fri, 12 Feb 2021)
Log Message
Remove some unused methods in MarkedBlock and PreciseAllocation.
https://bugs.webkit.org/show_bug.cgi?id=221864
Reviewed by Yusuke Suzuki.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::Handle::visitWeakSet): Deleted.
(JSC::MarkedBlock::Handle::reapWeakSet): Deleted.
* heap/PreciseAllocation.cpp:
(JSC::PreciseAllocation::shrink): Deleted.
(JSC::PreciseAllocation::visitWeakSet): Deleted.
(JSC::PreciseAllocation::reapWeakSet): Deleted.
* heap/PreciseAllocation.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (272824 => 272825)
--- trunk/Source/_javascript_Core/ChangeLog 2021-02-13 00:32:09 UTC (rev 272824)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-02-13 01:27:47 UTC (rev 272825)
@@ -1,3 +1,19 @@
+2021-02-12 Mark Lam <mark....@apple.com>
+
+ Remove some unused methods in MarkedBlock and PreciseAllocation.
+ https://bugs.webkit.org/show_bug.cgi?id=221864
+
+ Reviewed by Yusuke Suzuki.
+
+ * heap/MarkedBlock.h:
+ (JSC::MarkedBlock::Handle::visitWeakSet): Deleted.
+ (JSC::MarkedBlock::Handle::reapWeakSet): Deleted.
+ * heap/PreciseAllocation.cpp:
+ (JSC::PreciseAllocation::shrink): Deleted.
+ (JSC::PreciseAllocation::visitWeakSet): Deleted.
+ (JSC::PreciseAllocation::reapWeakSet): Deleted.
+ * heap/PreciseAllocation.h:
+
2021-02-12 Michael Saboff <msab...@apple.com>
[ARM64e] Harden Mach exception handling
Modified: trunk/Source/_javascript_Core/heap/MarkedBlock.h (272824 => 272825)
--- trunk/Source/_javascript_Core/heap/MarkedBlock.h 2021-02-13 00:32:09 UTC (rev 272824)
+++ trunk/Source/_javascript_Core/heap/MarkedBlock.h 2021-02-13 01:27:47 UTC (rev 272825)
@@ -1,7 +1,7 @@
/*
* Copyright (C) 1999-2000 Harri Porten (por...@kde.org)
* Copyright (C) 2001 Peter Kelly (p...@post.com)
- * Copyright (C) 2003-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2003-2021 Apple Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -151,9 +151,6 @@
void shrink();
- void visitWeakSet(SlotVisitor&);
- void reapWeakSet();
-
// While allocating from a free list, MarkedBlock temporarily has bogus
// cell liveness data. To restore accurate cell liveness data, call one
// of these functions:
@@ -498,16 +495,6 @@
m_weakSet.shrink();
}
-inline void MarkedBlock::Handle::visitWeakSet(SlotVisitor& visitor)
-{
- return m_weakSet.visit(visitor);
-}
-
-inline void MarkedBlock::Handle::reapWeakSet()
-{
- m_weakSet.reap();
-}
-
inline size_t MarkedBlock::Handle::cellSize()
{
return m_atomsPerCell * atomSize;
Modified: trunk/Source/_javascript_Core/heap/PreciseAllocation.cpp (272824 => 272825)
--- trunk/Source/_javascript_Core/heap/PreciseAllocation.cpp 2021-02-13 00:32:09 UTC (rev 272824)
+++ trunk/Source/_javascript_Core/heap/PreciseAllocation.cpp 2021-02-13 01:27:47 UTC (rev 272825)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2016-2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -195,21 +195,6 @@
sweep();
}
-void PreciseAllocation::shrink()
-{
- m_weakSet.shrink();
-}
-
-void PreciseAllocation::visitWeakSet(SlotVisitor& visitor)
-{
- m_weakSet.visit(visitor);
-}
-
-void PreciseAllocation::reapWeakSet()
-{
- return m_weakSet.reap();
-}
-
void PreciseAllocation::flip()
{
ASSERT(heap()->collectionScope() == CollectionScope::Full);
Modified: trunk/Source/_javascript_Core/heap/PreciseAllocation.h (272824 => 272825)
--- trunk/Source/_javascript_Core/heap/PreciseAllocation.h 2021-02-13 00:32:09 UTC (rev 272824)
+++ trunk/Source/_javascript_Core/heap/PreciseAllocation.h 2021-02-13 01:27:47 UTC (rev 272825)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2016-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -80,11 +80,6 @@
unsigned indexInSpace() { return m_indexInSpace; }
void setIndexInSpace(unsigned indexInSpace) { m_indexInSpace = indexInSpace; }
- void shrink();
-
- void visitWeakSet(SlotVisitor&);
- void reapWeakSet();
-
void clearNewlyAllocated() { m_isNewlyAllocated = false; }
void flip();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
