Title: [105370] trunk/Source/WebCore
Revision
105370
Author
commit-qu...@webkit.org
Date
2012-01-18 18:02:04 -0800 (Wed, 18 Jan 2012)

Log Message

Save two ID checks on CSS Min/Width property validation
https://bugs.webkit.org/show_bug.cgi?id=76565

The same validation is done again in the next case statement. Check for
CSSValueIntrinsic and CSSValueMinIntrinsic was done twice when the value
is a number.

Patch by Thiago Marcos P. Santos <tmpsan...@gmail.com> on 2012-01-18
Reviewed by Andreas Kling.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (105369 => 105370)


--- trunk/Source/WebCore/ChangeLog	2012-01-19 01:54:40 UTC (rev 105369)
+++ trunk/Source/WebCore/ChangeLog	2012-01-19 02:02:04 UTC (rev 105370)
@@ -1,3 +1,17 @@
+2012-01-18  Thiago Marcos P. Santos  <tmpsan...@gmail.com>
+
+        Save two ID checks on CSS Min/Width property validation
+        https://bugs.webkit.org/show_bug.cgi?id=76565
+
+        The same validation is done again in the next case statement. Check for
+        CSSValueIntrinsic and CSSValueMinIntrinsic was done twice when the value
+        is a number.
+
+        Reviewed by Andreas Kling.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseValue):
+
 2012-01-18  Dana Jansens  <dan...@chromium.org>
 
         [chromium] Use region reported painted opaque for draw culling

Modified: trunk/Source/WebCore/css/CSSParser.cpp (105369 => 105370)


--- trunk/Source/WebCore/css/CSSParser.cpp	2012-01-19 01:54:40 UTC (rev 105369)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-01-19 02:02:04 UTC (rev 105370)
@@ -1315,7 +1315,7 @@
     case CSSPropertyMaxWidth:            // <length> | <percentage> | none | inherit
     case CSSPropertyWebkitMaxLogicalWidth:
     case CSSPropertyWebkitMaxLogicalHeight:
-        if (id == CSSValueNone || id == CSSValueIntrinsic || id == CSSValueMinIntrinsic) {
+        if (id == CSSValueNone) {
             validPrimitive = true;
             break;
         }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to