Title: [271487] trunk/Source/WebCore
- Revision
- 271487
- Author
- [email protected]
- Date
- 2021-01-14 09:17:47 -0800 (Thu, 14 Jan 2021)
Log Message
Use AVAudioSessionModeDefault in AVAudioSessionCaptureDeviceManager::createAudioSession
https://bugs.webkit.org/show_bug.cgi?id=220618
<rdar://problem/73185920>
Reviewed by Eric Carlson.
Manually tested.
* platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
(WebCore::AVAudioSessionCaptureDeviceManager::createAudioSession):
AVAudioSessionModeDefault is less disruptive than video chat mode.
In particular, if the page is playing audio, the potential audio level bump when activating
this session will be largely less noticeable.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (271486 => 271487)
--- trunk/Source/WebCore/ChangeLog 2021-01-14 17:17:32 UTC (rev 271486)
+++ trunk/Source/WebCore/ChangeLog 2021-01-14 17:17:47 UTC (rev 271487)
@@ -1,3 +1,19 @@
+2021-01-14 Youenn Fablet <[email protected]>
+
+ Use AVAudioSessionModeDefault in AVAudioSessionCaptureDeviceManager::createAudioSession
+ https://bugs.webkit.org/show_bug.cgi?id=220618
+ <rdar://problem/73185920>
+
+ Reviewed by Eric Carlson.
+
+ Manually tested.
+
+ * platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
+ (WebCore::AVAudioSessionCaptureDeviceManager::createAudioSession):
+ AVAudioSessionModeDefault is less disruptive than video chat mode.
+ In particular, if the page is playing audio, the potential audio level bump when activating
+ this session will be largely less noticeable.
+
2021-01-14 Zalan Bujtas <[email protected]>
[LFC][IFC][Quirk] Let's adopt a less quirky behavior for line breaks on non-empty lines
Modified: trunk/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm (271486 => 271487)
--- trunk/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm 2021-01-14 17:17:32 UTC (rev 271486)
+++ trunk/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm 2021-01-14 17:17:47 UTC (rev 271487)
@@ -107,9 +107,8 @@
NSError *error = nil;
auto options = AVAudioSessionCategoryOptionAllowBluetooth | AVAudioSessionCategoryOptionMixWithOthers;
- [m_audioSession setCategory:AVAudioSessionCategoryPlayAndRecord mode:AVAudioSessionModeVideoChat options:options error:&error];
- if (error)
- RELEASE_LOG_ERROR(WebRTC, "Failed to set audio session category with error: %@.", error.localizedDescription);
+ [m_audioSession setCategory:AVAudioSessionCategoryPlayAndRecord mode:AVAudioSessionModeDefault options:options error:&error];
+ RELEASE_LOG_ERROR_IF(error, WebRTC, "Failed to set audio session category with error: %@.", error.localizedDescription);
}
AVAudioSessionCaptureDeviceManager::~AVAudioSessionCaptureDeviceManager()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
