Title: [271477] trunk/Source/WebKit
- Revision
- 271477
- Author
- [email protected]
- Date
- 2021-01-13 17:37:59 -0800 (Wed, 13 Jan 2021)
Log Message
REGRESSION(r270961): Flipgrid can no longer capture video
https://bugs.webkit.org/show_bug.cgi?id=220609
<rdar://73168009>
Reviewed by Darin Adler.
Add back line in RemoteAudio::setStorage() that was initializing m_buffer and that was
dropped by mistake in the refactoring in r270961. This was causing
RemoteCaptureSampleManager::RemoteAudio::audioSamplesAvailable() to return early because
m_buffer was not initialized.
No new tests, unsure how to test this.
* WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
(WebKit::RemoteCaptureSampleManager::RemoteAudio::setStorage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (271476 => 271477)
--- trunk/Source/WebKit/ChangeLog 2021-01-14 01:17:14 UTC (rev 271476)
+++ trunk/Source/WebKit/ChangeLog 2021-01-14 01:37:59 UTC (rev 271477)
@@ -1,3 +1,21 @@
+2021-01-13 Chris Dumez <[email protected]>
+
+ REGRESSION(r270961): Flipgrid can no longer capture video
+ https://bugs.webkit.org/show_bug.cgi?id=220609
+ <rdar://73168009>
+
+ Reviewed by Darin Adler.
+
+ Add back line in RemoteAudio::setStorage() that was initializing m_buffer and that was
+ dropped by mistake in the refactoring in r270961. This was causing
+ RemoteCaptureSampleManager::RemoteAudio::audioSamplesAvailable() to return early because
+ m_buffer was not initialized.
+
+ No new tests, unsure how to test this.
+
+ * WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
+ (WebKit::RemoteCaptureSampleManager::RemoteAudio::setStorage):
+
2021-01-13 John Wilander <[email protected]>
PCM: Output logs by default, including to Web Inspector
Modified: trunk/Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp (271476 => 271477)
--- trunk/Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp 2021-01-14 01:17:14 UTC (rev 271476)
+++ trunk/Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp 2021-01-14 01:37:59 UTC (rev 271477)
@@ -121,6 +121,7 @@
{
m_description = description;
m_ringBuffer = makeUnique<CARingBuffer>(makeUniqueRef<ReadOnlySharedRingBufferStorage>(handle), description, numberOfFrames);
+ m_buffer = makeUnique<WebAudioBufferList>(description, numberOfFrames);
}
void RemoteCaptureSampleManager::RemoteAudio::audioSamplesAvailable(MediaTime time, uint64_t numberOfFrames)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
