Title: [271227] trunk/Source/ThirdParty/libwebrtc
- Revision
- 271227
- Author
- [email protected]
- Date
- 2021-01-07 00:10:47 -0800 (Thu, 07 Jan 2021)
Log Message
Remove non-inclusive language from libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=220101
<rdar://problem/72727968>
Reviewed by Beth Dakin.
Remove logging erroneously added in https://trac.webkit.org/changeset/271150.
Remove non-inclusive language from Source/webrtc/rtc_base/message_digest.h as done in
https://webrtc-review.googlesource.com/c/src/+/200701.
* Source/webrtc/rtc_base/message_digest.h:
* Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm:
(-[RTCVideoDecoderH264 init]):
(-[RTCVideoDecoderH264 decodeData:size:timeStamp:]):
* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 initWithCodecInfo:]):
(-[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]):
(-[RTCVideoEncoderH264 frameWasEncoded:flags:sampleBuffer:codecSpecificInfo:width:height:renderTimeMs:timestamp:rotation:isKeyFrameRequired:]):
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (271226 => 271227)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-01-07 07:52:55 UTC (rev 271226)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-01-07 08:10:47 UTC (rev 271227)
@@ -1,3 +1,24 @@
+2021-01-07 Youenn Fablet <[email protected]>
+
+ Remove non-inclusive language from libwebrtc
+ https://bugs.webkit.org/show_bug.cgi?id=220101
+ <rdar://problem/72727968>
+
+ Reviewed by Beth Dakin.
+
+ Remove logging erroneously added in https://trac.webkit.org/changeset/271150.
+ Remove non-inclusive language from Source/webrtc/rtc_base/message_digest.h as done in
+ https://webrtc-review.googlesource.com/c/src/+/200701.
+
+ * Source/webrtc/rtc_base/message_digest.h:
+ * Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm:
+ (-[RTCVideoDecoderH264 init]):
+ (-[RTCVideoDecoderH264 decodeData:size:timeStamp:]):
+ * Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+ (-[RTCVideoEncoderH264 initWithCodecInfo:]):
+ (-[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]):
+ (-[RTCVideoEncoderH264 frameWasEncoded:flags:sampleBuffer:codecSpecificInfo:width:height:renderTimeMs:timestamp:rotation:isKeyFrameRequired:]):
+
2021-01-05 Youenn Fablet <[email protected]>
Remove non-inclusive language from libwebrtc
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/message_digest.h (271226 => 271227)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/message_digest.h 2021-01-07 07:52:55 UTC (rev 271226)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/message_digest.h 2021-01-07 08:10:47 UTC (rev 271227)
@@ -45,7 +45,8 @@
static MessageDigest* Create(const std::string& alg);
};
-// A whitelist of approved digest algorithms from RFC 4572 (FIPS 180).
+// A check that an algorithm is in a list of approved digest algorithms
+// from RFC 4572 (FIPS 180).
bool IsFips180DigestAlgorithm(const std::string& alg);
// Functions to create hashes.
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm (271226 => 271227)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm 2021-01-07 07:52:55 UTC (rev 271226)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm 2021-01-07 08:10:47 UTC (rev 271227)
@@ -82,7 +82,6 @@
if (self) {
_memoryPool = CMMemoryPoolCreate(nil);
}
- RTC_LOG(LS_ERROR) << "H264 decode init";
return self;
}
@@ -110,7 +109,6 @@
size:(size_t)size
timeStamp:(uint32_t)timeStamp {
- RTC_LOG(LS_ERROR) << "H264 decodeData";
if (_error != noErr) {
RTC_LOG(LS_WARNING) << "Last frame decode failed.";
_error = noErr;
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (271226 => 271227)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm 2021-01-07 07:52:55 UTC (rev 271226)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm 2021-01-07 08:10:47 UTC (rev 271227)
@@ -377,8 +377,6 @@
_isKeyFrameRequired = false;
_isH264LowLatencyEncoderEnabled = true;
- RTC_LOG(LS_ERROR) << "H264 encode initWithCodecInfo";
-
return self;
}
@@ -429,9 +427,6 @@
- (NSInteger)encode:(RTCVideoFrame *)frame
codecSpecificInfo:(nullable id<RTCCodecSpecificInfo>)codecSpecificInfo
frameTypes:(NSArray<NSNumber *> *)frameTypes {
-
- RTC_LOG(LS_ERROR) << "H264 encode new frame";
-
if (!_callback || ![self hasCompressionSession]) {
return WEBRTC_VIDEO_CODEC_UNINITIALIZED;
}
@@ -884,7 +879,6 @@
timestamp:(uint32_t)timestamp
rotation:(RTCVideoRotation)rotation
isKeyFrameRequired:(bool)isKeyFrameRequired {
- RTC_LOG(LS_ERROR) << "H264 encoded frame " << status;
if (status != noErr) {
RTC_LOG(LS_ERROR) << "H264 encode failed with code: " << status;
if (isKeyFrameRequired)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
