Title: [270615] trunk/Source/_javascript_Core
Revision
270615
Author
commit-qu...@webkit.org
Date
2020-12-09 23:51:45 -0800 (Wed, 09 Dec 2020)

Log Message

Fix redundant assert
https://bugs.webkit.org/show_bug.cgi?id=219725

Patch by Dmitry Bezhetskov <dbezhets...@igalia.com> on 2020-12-09
Reviewed by Ross Kirsling.

* runtime/JSArrayBufferPrototype.cpp:
(JSC::arrayBufferSlice):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (270614 => 270615)


--- trunk/Source/_javascript_Core/ChangeLog	2020-12-10 07:23:13 UTC (rev 270614)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-12-10 07:51:45 UTC (rev 270615)
@@ -1,3 +1,13 @@
+2020-12-09  Dmitry Bezhetskov  <dbezhets...@igalia.com>
+
+        Fix redundant assert
+        https://bugs.webkit.org/show_bug.cgi?id=219725
+
+        Reviewed by Ross Kirsling.
+
+        * runtime/JSArrayBufferPrototype.cpp:
+        (JSC::arrayBufferSlice):
+
 2020-12-08  Ross Kirsling  <ross.kirsl...@sony.com>
 
         Unreviewed debug test fix following r270552.

Modified: trunk/Source/_javascript_Core/runtime/JSArrayBufferPrototype.cpp (270614 => 270615)


--- trunk/Source/_javascript_Core/runtime/JSArrayBufferPrototype.cpp	2020-12-10 07:23:13 UTC (rev 270614)
+++ trunk/Source/_javascript_Core/runtime/JSArrayBufferPrototype.cpp	2020-12-10 07:51:45 UTC (rev 270615)
@@ -171,7 +171,6 @@
         firstIndex = static_cast<unsigned>(std::max<double>(byteLength + relativeStart, 0));
     else
         firstIndex = static_cast<unsigned>(std::min<double>(relativeStart, byteLength));
-    ASSERT(firstIndex >= 0);
     ASSERT(firstIndex <= byteLength);
 
     unsigned finalIndex = 0;
@@ -184,7 +183,6 @@
             finalIndex = static_cast<unsigned>(std::min<double>(relativeEnd, byteLength));
     } else
         finalIndex = thisObject->impl()->byteLength();
-    ASSERT(finalIndex >= 0);
     ASSERT(finalIndex <= byteLength);
 
     // 14. Let newLen be max(final - first, 0).
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to