Title: [270537] trunk/Source/_javascript_Core
Revision
270537
Author
ticaiol...@gmail.com
Date
2020-12-08 06:51:53 -0800 (Tue, 08 Dec 2020)

Log Message

[ESNext] op_put_private_name is wrong
https://bugs.webkit.org/show_bug.cgi?id=219616

Reviewed by Tadeu Zagallo.

Since `m_property` is a JSCell pointer, we need to use both `loadp`
and `bpneq` on `op_put_private_name`.

* llint/LowLevelInterpreter64.asm:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (270536 => 270537)


--- trunk/Source/_javascript_Core/ChangeLog	2020-12-08 14:37:12 UTC (rev 270536)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-12-08 14:51:53 UTC (rev 270537)
@@ -1,3 +1,15 @@
+2020-12-08  Caio Lima  <ticaiol...@gmail.com>
+
+        [ESNext] op_put_private_name is wrong
+        https://bugs.webkit.org/show_bug.cgi?id=219616
+
+        Reviewed by Tadeu Zagallo.
+
+        Since `m_property` is a JSCell pointer, we need to use both `loadp`
+        and `bpneq` on `op_put_private_name`.
+
+        * llint/LowLevelInterpreter64.asm:
+
 2020-12-07  Dmitry Bezhetskov  <dbezhets...@igalia.com>
 
         [WASM-References] Add support for table.copy

Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (270536 => 270537)


--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2020-12-08 14:37:12 UTC (rev 270536)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2020-12-08 14:51:53 UTC (rev 270537)
@@ -1792,8 +1792,8 @@
     loadi OpPutPrivateName::Metadata::m_oldStructureID[t5], t2
     bineq t2, JSCell::m_structureID[t0], .opPutPrivateNameSlow
 
-    loadi OpPutPrivateName::Metadata::m_property[t5], t3
-    bineq t3, t1, .opPutPrivateNameSlow
+    loadp OpPutPrivateName::Metadata::m_property[t5], t3
+    bpneq t3, t1, .opPutPrivateNameSlow
 
     # At this point, we have:
     # t0 -> object base
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to