Title: [268792] trunk
Revision
268792
Author
[email protected]
Date
2020-10-21 05:26:45 -0700 (Wed, 21 Oct 2020)

Log Message

[css-flexbox] flex-basis not animatable
https://bugs.webkit.org/show_bug.cgi?id=180435
LayoutTests/imported/w3c:

<rdar://problem/59363784>

Reviewed by Antoine Quint.

* web-platform-tests/css/css-flexbox/animation/flex-basis-composition-expected.txt: Replaced FAIL expectations with PASS.
* web-platform-tests/css/css-flexbox/animation/flex-basis-interpolation-expected.txt: Ditto.
* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt: Ditto.
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt: Ditto.
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: Ditto.

Source/WebCore:

Reviewed by Antoine Quint.

Make flex-basis property animatable as per spec. This allows us to pass ~100 flexbox animation subtests.

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Mark flex-basis as animatable.

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (268791 => 268792)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-10-21 11:32:10 UTC (rev 268791)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-10-21 12:26:45 UTC (rev 268792)
@@ -1,3 +1,17 @@
+2020-10-20  Sergio Villar Senin  <[email protected]>
+
+        [css-flexbox] flex-basis not animatable
+        https://bugs.webkit.org/show_bug.cgi?id=180435
+        <rdar://problem/59363784>
+
+        Reviewed by Antoine Quint.
+
+        * web-platform-tests/css/css-flexbox/animation/flex-basis-composition-expected.txt: Replaced FAIL expectations with PASS.
+        * web-platform-tests/css/css-flexbox/animation/flex-basis-interpolation-expected.txt: Ditto.
+        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt: Ditto.
+        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt: Ditto.
+        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: Ditto.
+
 2020-10-21  Antti Koivisto  <[email protected]>
 
         Import web-platform-tests/css/selectors/is-where-basic.html

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/flex-basis-composition-expected.txt (268791 => 268792)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/flex-basis-composition-expected.txt	2020-10-21 11:32:10 UTC (rev 268791)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/flex-basis-composition-expected.txt	2020-10-21 12:26:45 UTC (rev 268792)
@@ -1,27 +1,27 @@
 
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (-0.3) should be [120px] assert_equals: expected "120px " but got "50px "
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (0) should be [150px] assert_equals: expected "150px " but got "50px "
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (0.5) should be [200px] assert_equals: expected "200px " but got "50px "
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (1) should be [250px] assert_equals: expected "250px " but got "50px "
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (1.5) should be [300px] assert_equals: expected "300px " but got "50px "
-FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (-0.5) should be [114px] assert_equals: expected "114px " but got "100px "
-FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (0) should be [110px] assert_equals: expected "110px " but got "100px "
-FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (0.5) should be [106px] assert_equals: expected "106px " but got "100px "
-FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (1) should be [102px] assert_equals: expected "102px " but got "100px "
-FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (1.5) should be [98px] assert_equals: expected "98px " but got "100px "
-FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (-0.3) should be [calc(130px + 4%)] assert_equals: expected "calc ( 4 % + 130px ) " but got "10 % "
-FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (0) should be [calc(100px + 10%)] assert_equals: expected "calc ( 10 % + 100px ) " but got "10 % "
-FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (0.5) should be [calc(50px + 20%)] assert_equals: expected "calc ( 20 % + 50px ) " but got "10 % "
-FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (1) should be [30%] assert_equals: expected "30 % " but got "10 % "
-FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (1.5) should be [calc(-50px + 40%)] assert_equals: expected "calc ( 40 % - 50px ) " but got "10 % "
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (-0.3) should be [135px] assert_equals: expected "135px " but got "50px "
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (0) should be [150px] assert_equals: expected "150px " but got "50px "
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (0.5) should be [175px] assert_equals: expected "175px " but got "50px "
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (1) should be [200px] assert_equals: expected "200px " but got "50px "
-FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (1.5) should be [225px] assert_equals: expected "225px " but got "50px "
+FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (-0.3) should be [120px] assert_equals: expected "120px " but got "70px "
+FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (0) should be [150px] assert_equals: expected "150px " but got "100px "
+FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (0.5) should be [200px] assert_equals: expected "200px " but got "150px "
+FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (1) should be [250px] assert_equals: expected "250px " but got "200px "
+FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to add [200px] at (1.5) should be [300px] assert_equals: expected "300px " but got "250px "
+FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (-0.5) should be [114px] assert_equals: expected "114px " but got "14px "
+FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (0) should be [110px] assert_equals: expected "110px " but got "10px "
+FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (0.5) should be [106px] assert_equals: expected "106px " but got "6px "
+FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (1) should be [102px] assert_equals: expected "102px " but got "2px "
+FAIL Compositing: property <flex-basis> underlying [100px] from add [10px] to add [2px] at (1.5) should be [98px] assert_equals: expected "98px " but got "- 2px "
+FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (-0.3) should be [calc(130px + 4%)] assert_equals: expected "calc ( 4 % + 130px ) " but got "100px "
+FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (0) should be [calc(100px + 10%)] assert_equals: expected "calc ( 10 % + 100px ) " but got "100px "
+FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (0.5) should be [calc(50px + 20%)] assert_equals: expected "calc ( 20 % + 50px ) " but got "calc ( ( 100px * 0.5 ) + ( 20 % * 0.5 ) ) "
+FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (1) should be [30%] assert_equals: expected "30 % " but got "20 % "
+FAIL Compositing: property <flex-basis> underlying [10%] from add [100px] to add [20%] at (1.5) should be [calc(-50px + 40%)] assert_equals: expected "calc ( 40 % - 50px ) " but got "20 % "
+FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (-0.3) should be [135px] assert_equals: expected "135px " but got "70px "
+FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (0) should be [150px] assert_equals: expected "150px " but got "100px "
+FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (0.5) should be [175px] assert_equals: expected "175px " but got "150px "
+PASS Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (1) should be [200px]
+FAIL Compositing: property <flex-basis> underlying [50px] from add [100px] to replace [200px] at (1.5) should be [225px] assert_equals: expected "225px " but got "250px "
 FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (-0.3) should be [200px] assert_equals: expected "200px " but got "100px "
 FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (0) should be [200px] assert_equals: expected "200px " but got "100px "
-FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (0.5) should be [auto] assert_equals: expected "auto " but got "100px "
-FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (1) should be [auto] assert_equals: expected "auto " but got "100px "
-FAIL Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (1.5) should be [auto] assert_equals: expected "auto " but got "100px "
+PASS Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (0.5) should be [auto]
+PASS Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (1) should be [auto]
+PASS Compositing: property <flex-basis> underlying [100px] from add [100px] to add [auto] at (1.5) should be [auto]
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/flex-basis-interpolation-expected.txt (268791 => 268792)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/flex-basis-interpolation-expected.txt	2020-10-21 11:32:10 UTC (rev 268791)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/animation/flex-basis-interpolation-expected.txt	2020-10-21 12:26:45 UTC (rev 268792)
@@ -1,10 +1,10 @@
 
-FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%] assert_equals: expected "0.7 % " but got "2 % "
-FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (0) should be [1%] assert_equals: expected "1 % " but got "2 % "
-FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%] assert_equals: expected "1.3 % " but got "2 % "
-FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%] assert_equals: expected "1.6 % " but got "2 % "
+PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%]
+PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (0) should be [1%]
+PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%]
+PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%]
 PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (1) should be [2%]
-FAIL CSS Transitions: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%] assert_equals: expected "2.5 % " but got "2 % "
+PASS CSS Transitions: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%]
 PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%]
 PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (0) should be [1%]
 PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%]
@@ -11,18 +11,18 @@
 PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%]
 PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (1) should be [2%]
 PASS CSS Transitions with transition: all: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%]
-FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%] assert_equals: expected "0.7 % " but got "1 % "
+PASS CSS Animations: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%]
 PASS CSS Animations: property <flex-basis> from neutral to [2%] at (0) should be [1%]
-FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%] assert_equals: expected "1.3 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%] assert_equals: expected "1.6 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%] assert_equals: expected "2.5 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%] assert_equals: expected "0.7 % " but got "1 % "
-PASS Web Animations: property <flex-basis> from neutral to [2%] at (0) should be [1%]
-FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%] assert_equals: expected "1.3 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%] assert_equals: expected "1.6 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from neutral to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%] assert_equals: expected "2.5 % " but got "1 % "
+PASS CSS Animations: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%]
+PASS CSS Animations: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%]
+PASS CSS Animations: property <flex-basis> from neutral to [2%] at (1) should be [2%]
+PASS CSS Animations: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%]
+PASS Web Animations: property <flex-basis> from neutral to [2%] at (-0.3) should be [0.7%]
+FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0) should be [1%] assert_equals: expected "1 % " but got "0.7 % "
+FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0.3) should be [1.3%] assert_equals: expected "1.3 % " but got "1.09 % "
+FAIL Web Animations: property <flex-basis> from neutral to [2%] at (0.6) should be [1.6%] assert_equals: expected "1.6 % " but got "1.64 % "
+PASS Web Animations: property <flex-basis> from neutral to [2%] at (1) should be [2%]
+FAIL Web Animations: property <flex-basis> from neutral to [2%] at (1.5) should be [2.5%] assert_equals: expected "2.5 % " but got "2 % "
 PASS CSS Transitions: property <flex-basis> from [initial] to [2%] at (-0.3) should be [2%]
 PASS CSS Transitions: property <flex-basis> from [initial] to [2%] at (0) should be [2%]
 PASS CSS Transitions: property <flex-basis> from [initial] to [2%] at (0.3) should be [2%]
@@ -37,26 +37,26 @@
 PASS CSS Transitions with transition: all: property <flex-basis> from [initial] to [2%] at (0.6) should be [2%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [initial] to [2%] at (1) should be [2%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%]
-FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (-0.3) should be [initial] assert_equals: expected "auto " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (0) should be [initial] assert_equals: expected "auto " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (0.3) should be [initial] assert_equals: expected "auto " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (0.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (0.6) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (-0.3) should be [initial] assert_equals: expected "auto " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (0) should be [initial] assert_equals: expected "auto " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (0.3) should be [initial] assert_equals: expected "auto " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (0.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (0.6) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%] assert_equals: expected "3.3 % " but got "2 % "
-FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0) should be [3%] assert_equals: expected "3 % " but got "2 % "
-FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%] assert_equals: expected "2.7 % " but got "2 % "
-FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%] assert_equals: expected "2.4 % " but got "2 % "
+PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (-0.3) should be [initial]
+PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (0) should be [initial]
+PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (0.3) should be [initial]
+PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (0.5) should be [2%]
+PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (0.6) should be [2%]
+PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (1) should be [2%]
+PASS CSS Animations: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%]
+PASS Web Animations: property <flex-basis> from [initial] to [2%] at (-0.3) should be [initial]
+PASS Web Animations: property <flex-basis> from [initial] to [2%] at (0) should be [initial]
+PASS Web Animations: property <flex-basis> from [initial] to [2%] at (0.3) should be [initial]
+PASS Web Animations: property <flex-basis> from [initial] to [2%] at (0.5) should be [2%]
+PASS Web Animations: property <flex-basis> from [initial] to [2%] at (0.6) should be [2%]
+PASS Web Animations: property <flex-basis> from [initial] to [2%] at (1) should be [2%]
+PASS Web Animations: property <flex-basis> from [initial] to [2%] at (1.5) should be [2%]
+PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%]
+PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0) should be [3%]
+PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%]
+PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%]
 PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (1) should be [2%]
-FAIL CSS Transitions: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%] assert_equals: expected "1.5 % " but got "2 % "
+PASS CSS Transitions: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (0) should be [3%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%]
@@ -63,18 +63,18 @@
 PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (1) should be [2%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%]
-FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%] assert_equals: expected "3.3 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (0) should be [3%] assert_equals: expected "3 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%] assert_equals: expected "2.7 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%] assert_equals: expected "2.4 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%] assert_equals: expected "1.5 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%] assert_equals: expected "3.3 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0) should be [3%] assert_equals: expected "3 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%] assert_equals: expected "2.7 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%] assert_equals: expected "2.4 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%] assert_equals: expected "1.5 % " but got "1 % "
+PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%]
+PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (0) should be [3%]
+PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%]
+PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%]
+PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (1) should be [2%]
+PASS CSS Animations: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%]
+FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (-0.3) should be [3.3%] assert_equals: expected "3.3 % " but got "0.7 % "
+FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0) should be [3%] assert_equals: expected "3 % " but got "0.7 % "
+FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0.3) should be [2.7%] assert_equals: expected "2.7 % " but got "1.09 % "
+FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (0.6) should be [2.4%] assert_equals: expected "2.4 % " but got "1.64 % "
+PASS Web Animations: property <flex-basis> from [inherit] to [2%] at (1) should be [2%]
+FAIL Web Animations: property <flex-basis> from [inherit] to [2%] at (1.5) should be [1.5%] assert_equals: expected "1.5 % " but got "2 % "
 PASS CSS Transitions: property <flex-basis> from [unset] to [2%] at (-0.3) should be [2%]
 PASS CSS Transitions: property <flex-basis> from [unset] to [2%] at (0) should be [2%]
 PASS CSS Transitions: property <flex-basis> from [unset] to [2%] at (0.3) should be [2%]
@@ -89,26 +89,26 @@
 PASS CSS Transitions with transition: all: property <flex-basis> from [unset] to [2%] at (0.6) should be [2%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [unset] to [2%] at (1) should be [2%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%]
-FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (-0.3) should be [unset] assert_equals: expected "auto " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (0) should be [unset] assert_equals: expected "auto " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (0.3) should be [unset] assert_equals: expected "auto " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (0.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (0.6) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (-0.3) should be [unset] assert_equals: expected "auto " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (0) should be [unset] assert_equals: expected "auto " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (0.3) should be [unset] assert_equals: expected "auto " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (0.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (0.6) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (1) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%] assert_equals: expected "2 % " but got "1 % "
-FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "100px "
-FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (0) should be [0px] assert_equals: expected "0px " but got "100px "
-FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px] assert_equals: expected "40px " but got "100px "
-FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px] assert_equals: expected "60px " but got "100px "
+PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (-0.3) should be [unset]
+PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (0) should be [unset]
+PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (0.3) should be [unset]
+PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (0.5) should be [2%]
+PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (0.6) should be [2%]
+PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (1) should be [2%]
+PASS CSS Animations: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%]
+PASS Web Animations: property <flex-basis> from [unset] to [2%] at (-0.3) should be [unset]
+PASS Web Animations: property <flex-basis> from [unset] to [2%] at (0) should be [unset]
+PASS Web Animations: property <flex-basis> from [unset] to [2%] at (0.3) should be [unset]
+PASS Web Animations: property <flex-basis> from [unset] to [2%] at (0.5) should be [2%]
+PASS Web Animations: property <flex-basis> from [unset] to [2%] at (0.6) should be [2%]
+PASS Web Animations: property <flex-basis> from [unset] to [2%] at (1) should be [2%]
+PASS Web Animations: property <flex-basis> from [unset] to [2%] at (1.5) should be [2%]
+FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "- 30px "
+PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (0) should be [0px]
+PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px]
+PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px]
 PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (1) should be [100px]
-FAIL CSS Transitions: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px] assert_equals: expected "150px " but got "100px "
+PASS CSS Transitions: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px]
 FAIL CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "- 30px "
 PASS CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (0) should be [0px]
 PASS CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px]
@@ -115,24 +115,24 @@
 PASS CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px]
 PASS CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (1) should be [100px]
 PASS CSS Transitions with transition: all: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px]
-FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (0) should be [0px] assert_equals: expected "0px " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px] assert_equals: expected "40px " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px] assert_equals: expected "60px " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (1) should be [100px] assert_equals: expected "100px " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px] assert_equals: expected "150px " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (0) should be [0px] assert_equals: expected "0px " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px] assert_equals: expected "40px " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px] assert_equals: expected "60px " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (1) should be [100px] assert_equals: expected "100px " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px] assert_equals: expected "150px " but got "1 % "
-FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "100 % "
-FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (0) should be [0%] assert_equals: expected "0 % " but got "100 % "
-FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%] assert_equals: expected "40 % " but got "100 % "
-FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%] assert_equals: expected "60 % " but got "100 % "
+FAIL CSS Animations: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "- 30px "
+PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (0) should be [0px]
+PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px]
+PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px]
+PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (1) should be [100px]
+PASS CSS Animations: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px]
+FAIL Web Animations: property <flex-basis> from [0px] to [100px] at (-0.3) should be [0px] assert_equals: expected "0px " but got "- 30px "
+PASS Web Animations: property <flex-basis> from [0px] to [100px] at (0) should be [0px]
+PASS Web Animations: property <flex-basis> from [0px] to [100px] at (0.4) should be [40px]
+PASS Web Animations: property <flex-basis> from [0px] to [100px] at (0.6) should be [60px]
+PASS Web Animations: property <flex-basis> from [0px] to [100px] at (1) should be [100px]
+PASS Web Animations: property <flex-basis> from [0px] to [100px] at (1.5) should be [150px]
+FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "- 30 % "
+PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (0) should be [0%]
+PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%]
+PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%]
 PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (1) should be [100%]
-FAIL CSS Transitions: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%] assert_equals: expected "150 % " but got "100 % "
+PASS CSS Transitions: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%]
 FAIL CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "- 30 % "
 PASS CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (0) should be [0%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%]
@@ -139,16 +139,16 @@
 PASS CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (1) should be [100%]
 PASS CSS Transitions with transition: all: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%]
-FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (0) should be [0%] assert_equals: expected "0 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%] assert_equals: expected "40 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%] assert_equals: expected "60 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (1) should be [100%] assert_equals: expected "100 % " but got "1 % "
-FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%] assert_equals: expected "150 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (0) should be [0%] assert_equals: expected "0 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%] assert_equals: expected "40 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%] assert_equals: expected "60 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (1) should be [100%] assert_equals: expected "100 % " but got "1 % "
-FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%] assert_equals: expected "150 % " but got "1 % "
+FAIL CSS Animations: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "- 30 % "
+PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (0) should be [0%]
+PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%]
+PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%]
+PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (1) should be [100%]
+PASS CSS Animations: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%]
+FAIL Web Animations: property <flex-basis> from [0%] to [100%] at (-0.3) should be [0%] assert_equals: expected "0 % " but got "- 30 % "
+PASS Web Animations: property <flex-basis> from [0%] to [100%] at (0) should be [0%]
+PASS Web Animations: property <flex-basis> from [0%] to [100%] at (0.4) should be [40%]
+PASS Web Animations: property <flex-basis> from [0%] to [100%] at (0.6) should be [60%]
+PASS Web Animations: property <flex-basis> from [0%] to [100%] at (1) should be [100%]
+PASS Web Animations: property <flex-basis> from [0%] to [100%] at (1.5) should be [150%]
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt (268791 => 268792)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2020-10-21 11:32:10 UTC (rev 268791)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2020-10-21 12:26:45 UTC (rev 268792)
@@ -112,6 +112,21 @@
 PASS filter (type: filterList) has testAccumulation function
 FAIL filter: same ordered filter functions assert_equals: The value should be blur(30px) brightness(0) at 0ms expected "blur(30px) brightness(0)" but got "blur(20px) brightness(0.1)"
 PASS filter: mismatched ordered filter functions
+PASS flex-basis (type: lengthPercentageOrCalc) has testAccumulation function
+FAIL flex-basis: length assert_equals: The value should be 20px at 0ms expected "20px" but got "10px"
+FAIL flex-basis: length of rem assert_equals: The value should be 20px at 0ms expected "20px" but got "10px"
+FAIL flex-basis: percentage assert_equals: The value should be 130% at 0ms expected "130%" but got "70%"
+FAIL flex-basis: units "%" onto "px" assert_equals: The value should be calc(10% + 10px) at 0ms expected "calc(10% + 10px)" but got "10%"
+FAIL flex-basis: units "px" onto "%" assert_equals: The value should be calc(10% + 10px) at 0ms expected "calc(10% + 10px)" but got "10px"
+FAIL flex-basis: units "rem" onto "%" assert_equals: The value should be calc(10% + 20px) at 0ms expected "calc(10% + 20px)" but got "20px"
+FAIL flex-basis: units "%" onto "rem" assert_equals: The value should be calc(10% + 20px) at 0ms expected "calc(10% + 20px)" but got "10%"
+FAIL flex-basis: units "rem" onto "em" assert_equals: The value should be 40px at 0ms expected "40px" but got "20px"
+FAIL flex-basis: units "em" onto "rem" assert_equals: The value should be 40px at 0ms expected "40px" but got "20px"
+FAIL flex-basis: units "calc" onto "px" assert_equals: The value should be calc(20% + 30px) at 0ms expected "calc(20% + 30px)" but got "calc(20% + 20px)"
+FAIL flex-basis: calc assert_equals: The value should be calc(30% + 30px) at 0ms expected "calc(30% + 30px)" but got "calc(20% + 20px)"
+PASS flex-basis (type: discrete) has testAccumulation function
+PASS flex-basis: "10px" onto "auto"
+PASS flex-basis: "auto" onto "10px"
 PASS flex-grow (type: positiveNumber) has testAccumulation function
 FAIL flex-grow: positive number assert_equals: The value should be 2.2 at 0ms expected "2.2" but got "1.100000023841858"
 PASS flex-shrink (type: positiveNumber) has testAccumulation function

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt (268791 => 268792)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2020-10-21 11:32:10 UTC (rev 268791)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2020-10-21 12:26:45 UTC (rev 268792)
@@ -112,6 +112,21 @@
 PASS filter (type: filterList) has testAddition function
 FAIL filter: blur on blur assert_equals: The value should be blur(10px) blur(20px) at 0ms expected "blur(10px) blur(20px)" but got "blur(20px)"
 FAIL filter: different filter functions assert_equals: The value should be blur(10px) brightness(0.8) at 0ms expected "blur(10px) brightness(0.8)" but got "brightness(0.8)"
+PASS flex-basis (type: lengthPercentageOrCalc) has testAddition function
+FAIL flex-basis: length assert_equals: The value should be 20px at 0ms expected "20px" but got "10px"
+FAIL flex-basis: length of rem assert_equals: The value should be 20px at 0ms expected "20px" but got "10px"
+FAIL flex-basis: percentage assert_equals: The value should be 130% at 0ms expected "130%" but got "70%"
+FAIL flex-basis: units "%" onto "px" assert_equals: The value should be calc(10% + 10px) at 0ms expected "calc(10% + 10px)" but got "10%"
+FAIL flex-basis: units "px" onto "%" assert_equals: The value should be calc(10% + 10px) at 0ms expected "calc(10% + 10px)" but got "10px"
+FAIL flex-basis: units "rem" onto "%" assert_equals: The value should be calc(10% + 20px) at 0ms expected "calc(10% + 20px)" but got "20px"
+FAIL flex-basis: units "%" onto "rem" assert_equals: The value should be calc(10% + 20px) at 0ms expected "calc(10% + 20px)" but got "10%"
+FAIL flex-basis: units "rem" onto "em" assert_equals: The value should be 40px at 0ms expected "40px" but got "20px"
+FAIL flex-basis: units "em" onto "rem" assert_equals: The value should be 40px at 0ms expected "40px" but got "20px"
+FAIL flex-basis: units "calc" onto "px" assert_equals: The value should be calc(20% + 30px) at 0ms expected "calc(20% + 30px)" but got "calc(20% + 20px)"
+FAIL flex-basis: calc assert_equals: The value should be calc(30% + 30px) at 0ms expected "calc(30% + 30px)" but got "calc(20% + 20px)"
+PASS flex-basis (type: discrete) has testAddition function
+PASS flex-basis: "10px" onto "auto"
+PASS flex-basis: "auto" onto "10px"
 PASS flex-grow (type: positiveNumber) has testAddition function
 FAIL flex-grow: positive number assert_equals: The value should be 2.2 at 0ms expected "2.2" but got "1.100000023841858"
 PASS flex-shrink (type: positiveNumber) has testAddition function

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt (268791 => 268792)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt	2020-10-21 11:32:10 UTC (rev 268791)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt	2020-10-21 12:26:45 UTC (rev 268792)
@@ -133,6 +133,19 @@
 FAIL filter: interpolate different length of filter-function-list with drop-shadow function assert_equals: The value should be blur(5px) drop-shadow(rgba(0, 0, 255, 0.4) 5px 5px 5px) at 500ms expected "blur(5px) drop-shadow(rgba(0, 0, 255, 0.4) 5px 5px 5px)" but got "blur(10px) drop-shadow(rgba(0, 0, 255, 0.8) 10px 10px 10px)"
 PASS filter: interpolate from none
 FAIL filter: url function (interpoalte as discrete) assert_equals: The value should be blur(0px) url("#f1") at 499ms expected "blur(0px) url(\"#f1\")" but got "blur(4.989999771118164px) url(\"#f1\")"
+PASS flex-basis (type: lengthPercentageOrCalc) has testInterpolation function
+PASS flex-basis supports animating as a length
+PASS flex-basis supports animating as a length of rem
+PASS flex-basis supports animating as a percentage
+FAIL flex-basis supports animating as combination units "px" and "%" assert_equals: The value should be calc(10% + 5px) at 500ms expected "calc(10% + 5px)" but got "calc((10px * 0.5) + (20% * 0.5))"
+FAIL flex-basis supports animating as combination units "%" and "em" assert_equals: The value should be calc(5% + 10px) at 500ms expected "calc(5% + 10px)" but got "calc((10% * 0.5) + (20px * 0.5))"
+PASS flex-basis supports animating as combination units "em" and "rem"
+FAIL flex-basis supports animating as combination units "px" and "calc" assert_equals: The value should be calc(10% + 10px) at 500ms expected "calc(10% + 10px)" but got "calc((10px * 0.5) + ((20% + 10px) * 0.5))"
+FAIL flex-basis supports animating as a calc assert_equals: The value should be calc(15% + 15px) at 500ms expected "calc(15% + 15px)" but got "calc(((10% + 10px) * 0.5) + ((20% + 10px + 10px) * 0.5))"
+PASS flex-basis (type: discrete) has testInterpolation function
+PASS flex-basis uses discrete animation when animating between "auto" and "10px" with linear easing
+PASS flex-basis uses discrete animation when animating between "auto" and "10px" with effect easing
+PASS flex-basis uses discrete animation when animating between "auto" and "10px" with keyframe easing
 PASS flex-grow (type: positiveNumber) has testInterpolation function
 FAIL flex-grow supports animating as a positive number assert_equals: The value should be 1.3 at 500ms expected "1.3" but got "1.2999999523162842"
 PASS flex-shrink (type: positiveNumber) has testInterpolation function

Modified: trunk/Source/WebCore/ChangeLog (268791 => 268792)


--- trunk/Source/WebCore/ChangeLog	2020-10-21 11:32:10 UTC (rev 268791)
+++ trunk/Source/WebCore/ChangeLog	2020-10-21 12:26:45 UTC (rev 268792)
@@ -1,3 +1,15 @@
+2020-10-20  Sergio Villar Senin  <[email protected]>
+
+        [css-flexbox] flex-basis not animatable
+        https://bugs.webkit.org/show_bug.cgi?id=180435
+
+        Reviewed by Antoine Quint.
+
+        Make flex-basis property animatable as per spec. This allows us to pass ~100 flexbox animation subtests.
+
+        * animation/CSSPropertyAnimation.cpp:
+        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Mark flex-basis as animatable.
+
 2020-10-21  Youenn Fablet  <[email protected]>
 
         [iOS] Disable audio capture in the background for non Safari applications

Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (268791 => 268792)


--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2020-10-21 11:32:10 UTC (rev 268791)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2020-10-21 12:26:45 UTC (rev 268792)
@@ -1870,6 +1870,7 @@
         new PropertyWrapper<TextDecorationThickness>(CSSPropertyTextDecorationThickness, &RenderStyle::textDecorationThickness, &RenderStyle::setTextDecorationThickness),
         new PropertyWrapper<TextUnderlineOffset>(CSSPropertyTextUnderlineOffset, &RenderStyle::textUnderlineOffset, &RenderStyle::setTextUnderlineOffset),
 
+        new LengthPropertyWrapper(CSSPropertyFlexBasis, &RenderStyle::flexBasis, &RenderStyle::setFlexBasis),
         new PropertyWrapper<float>(CSSPropertyFlexGrow, &RenderStyle::flexGrow, &RenderStyle::setFlexGrow),
         new PropertyWrapper<float>(CSSPropertyFlexShrink, &RenderStyle::flexShrink, &RenderStyle::setFlexShrink),
         new PropertyWrapper<int>(CSSPropertyOrder, &RenderStyle::order, &RenderStyle::setOrder),
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to