Title: [268246] trunk/Source/WebKit
- Revision
- 268246
- Author
- cfleiz...@apple.com
- Date
- 2020-10-08 21:02:48 -0700 (Thu, 08 Oct 2020)
Log Message
AX: Website Warning page is inaccessible
https://bugs.webkit.org/show_bug.cgi?id=217489
Reviewed by Zalan Bujtas.
If we have a safe browsing window, we need to use that instead of the content view.
* UIProcess/Cocoa/WKSafeBrowsingWarning.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::accessibilityAttributeValue):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (268245 => 268246)
--- trunk/Source/WebKit/ChangeLog 2020-10-09 03:13:50 UTC (rev 268245)
+++ trunk/Source/WebKit/ChangeLog 2020-10-09 04:02:48 UTC (rev 268246)
@@ -1,3 +1,16 @@
+2020-10-08 Chris Fleizach <cfleiz...@apple.com>
+
+ AX: Website Warning page is inaccessible
+ https://bugs.webkit.org/show_bug.cgi?id=217489
+
+ Reviewed by Zalan Bujtas.
+
+ If we have a safe browsing window, we need to use that instead of the content view.
+
+ * UIProcess/Cocoa/WKSafeBrowsingWarning.h:
+ * UIProcess/Cocoa/WebViewImpl.mm:
+ (WebKit::WebViewImpl::accessibilityAttributeValue):
+
2020-10-08 Alex Christensen <achristen...@webkit.org>
REGRESSION (r267763): SHOULD NEVER BE REACHED in WebKit::contentRuleListsFromIdentifier
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h (268245 => 268246)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h 2020-10-09 03:13:50 UTC (rev 268245)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h 2020-10-09 04:02:48 UTC (rev 268246)
@@ -61,7 +61,7 @@
@end
#if PLATFORM(MAC)
-@interface WKSafeBrowsingWarning : WKSafeBrowsingBox<NSTextViewDelegate>
+@interface WKSafeBrowsingWarning : WKSafeBrowsingBox<NSTextViewDelegate, NSAccessibilityGroup>
#else
@interface WKSafeBrowsingWarning : UIScrollView<UITextViewDelegate>
#endif
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (268245 => 268246)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2020-10-09 03:13:50 UTC (rev 268245)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2020-10-09 04:02:48 UTC (rev 268246)
@@ -3731,7 +3731,9 @@
if ([attribute isEqualToString:NSAccessibilityChildrenAttribute]) {
id child = nil;
- if (m_remoteAccessibilityChild)
+ if (m_safeBrowsingWarning)
+ child = m_safeBrowsingWarning.get();
+ else if (m_remoteAccessibilityChild)
child = m_remoteAccessibilityChild.get();
if (!child)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
