Title: [267592] trunk
Revision
267592
Author
[email protected]
Date
2020-09-25 14:26:29 -0700 (Fri, 25 Sep 2020)

Log Message

Add an experimental feature flag for CSS individual transform properties
https://bugs.webkit.org/show_bug.cgi?id=216271
<rdar://problem/68914539>

Reviewed by Dean Jackson.

Source/WebCore:

* page/Settings.yaml:

Source/WebKit:

* Shared/WebPreferencesExperimental.yaml:

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences setCSSIndividualTransformPropertiesEnabled:]):
(-[WebPreferences cssIndividualTransformPropertiesEnabled]):
(-[WebPreferences CSSIndividualTransformPropertiesEnabled]):
* WebView/WebPreferencesExperimental.yaml:
* WebView/WebPreferencesPrivate.h:

Source/WebKitLegacy/win:

* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::CSSIndividualTransformPropertiesEnabled):
(WebPreferences::setCSSIndividualTransformPropertiesEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
* DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (267591 => 267592)


--- trunk/Source/WebCore/ChangeLog	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebCore/ChangeLog	2020-09-25 21:26:29 UTC (rev 267592)
@@ -1,3 +1,13 @@
+2020-09-25  Antoine Quint  <[email protected]>
+
+        Add an experimental feature flag for CSS individual transform properties
+        https://bugs.webkit.org/show_bug.cgi?id=216271
+        <rdar://problem/68914539>
+
+        Reviewed by Dean Jackson.
+
+        * page/Settings.yaml:
+
 2020-09-25  Chris Dumez  <[email protected]>
 
         Get rid of AudioNode::RefType

Modified: trunk/Source/WebCore/page/Settings.yaml (267591 => 267592)


--- trunk/Source/WebCore/page/Settings.yaml	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebCore/page/Settings.yaml	2020-09-25 21:26:29 UTC (rev 267592)
@@ -1120,3 +1120,6 @@
 # Clients should use per-navigation "allowsContentJavaScript" policies instead
 scriptMarkupEnabled:
   initial: true
+
+cssIndividualTransformPropertiesEnabled:
+  initial: false

Modified: trunk/Source/WebKit/ChangeLog (267591 => 267592)


--- trunk/Source/WebKit/ChangeLog	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKit/ChangeLog	2020-09-25 21:26:29 UTC (rev 267592)
@@ -1,3 +1,13 @@
+2020-09-25  Antoine Quint  <[email protected]>
+
+        Add an experimental feature flag for CSS individual transform properties
+        https://bugs.webkit.org/show_bug.cgi?id=216271
+        <rdar://problem/68914539>
+
+        Reviewed by Dean Jackson.
+
+        * Shared/WebPreferencesExperimental.yaml:
+
 2020-09-25  Per Arne Vollan  <[email protected]>
 
         [macOS] Deny access to diagnosticd in the WebContent process

Modified: trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml (267591 => 267592)


--- trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml	2020-09-25 21:26:29 UTC (rev 267592)
@@ -544,3 +544,9 @@
   humanReadableName: "Disable Media Experience PID Inheritance"
   humanReadableDescription: "Disable Media Experience PID Inheritance"
   condition: HAVE(CELESTIAL)
+
+CSSIndividualTransformPropertiesEnabled:
+  type: bool
+  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
+  humanReadableName: "CSS Individual Transform Properties"
+  humanReadableDescription: "Support for the translate, scale and rotate CSS properties"

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (267591 => 267592)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2020-09-25 21:26:29 UTC (rev 267592)
@@ -1,3 +1,19 @@
+2020-09-25  Antoine Quint  <[email protected]>
+
+        Add an experimental feature flag for CSS individual transform properties
+        https://bugs.webkit.org/show_bug.cgi?id=216271
+        <rdar://problem/68914539>
+
+        Reviewed by Dean Jackson.
+
+        * WebView/WebPreferenceKeysPrivate.h:
+        * WebView/WebPreferences.mm:
+        (-[WebPreferences setCSSIndividualTransformPropertiesEnabled:]):
+        (-[WebPreferences cssIndividualTransformPropertiesEnabled]):
+        (-[WebPreferences CSSIndividualTransformPropertiesEnabled]):
+        * WebView/WebPreferencesExperimental.yaml:
+        * WebView/WebPreferencesPrivate.h:
+
 2020-09-24  Darin Adler  <[email protected]>
 
         Add CSSConditionRule and CSSGroupingRule

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (267591 => 267592)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h	2020-09-25 21:26:29 UTC (rev 267592)
@@ -287,8 +287,8 @@
 #define WebKitReadableByteStreamAPIEnabledPreferenceKey @"WebKitReadableByteStreamAPIEnabled"
 #define WebKitTransformStreamAPIEnabledPreferenceKey @"WebKitTransformStreamAPIEnabled"
 #define WebKitMediaRecorderEnabledPreferenceKey @"WebKitMediaRecorderEnabled"
+#define WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey @"WebKitCSSIndividualTransformPropertiesEnabled"
 
-
 // The preference keys below this point are deprecated and have no effect. They should
 // be removed when it is considered safe to do so.
 #define WebKitShadowDOMEnabledPreferenceKey @"WebKitShadowDOMEnabled"

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (267591 => 267592)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2020-09-25 21:26:29 UTC (rev 267592)
@@ -3206,6 +3206,16 @@
     [self _setBoolValue:webSQLEnabled forKey:WebKitWebSQLEnabledPreferenceKey];
 }
 
+- (void)setCSSIndividualTransformPropertiesEnabled:(BOOL)flag
+{
+    [self _setBoolValue:flag forKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
+}
+
+- (BOOL)cssIndividualTransformPropertiesEnabled
+{
+    return [self _boolValueForKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
+}
+
 @end
 
 @implementation WebPreferences (WebInternal)
@@ -3580,6 +3590,16 @@
     [self _setBoolValue:flag forKey:WebKitMediaRecorderEnabledPreferenceKey];
 }
 
+- (BOOL)CSSIndividualTransformPropertiesEnabled
+{
+    return [self _boolValueForKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
+}
+
+- (void)setCSSIndividualTransformPropertiesEnabled:(BOOL)flag
+{
+    [self _setBoolValue:flag forKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
+}
+
 @end
 
 @implementation WebPreferences (WebPrivateObsolete)

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesExperimental.yaml (267591 => 267592)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesExperimental.yaml	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesExperimental.yaml	2020-09-25 21:26:29 UTC (rev 267592)
@@ -591,3 +591,9 @@
   humanReadableDescription: "Use NSURLSession WebSocket API"
   webcoreBinding: RuntimeEnabledFeatures
   condition: HAVE(NSURLSESSION_WEBSOCKET)
+
+CSSIndividualTransformPropertiesEnabled:
+  type: bool
+  defaultValue: false
+  humanReadableName: "CSS Individual Transform Properties"
+  humanReadableDescription: "Support for the translate, scale and rotate CSS properties"

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (267591 => 267592)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h	2020-09-25 21:26:29 UTC (rev 267592)
@@ -642,6 +642,7 @@
 @property (nonatomic) BOOL transformStreamAPIEnabled;
 @property (nonatomic) BOOL mediaRecorderEnabled;
 @property (nonatomic, setter=_setMediaRecorderEnabled:) BOOL _mediaRecorderEnabled;
+@property (nonatomic) BOOL CSSIndividualTransformPropertiesEnabled;
 @end
 
 @interface WebPreferences (WebPrivateDeprecated)

Modified: trunk/Source/WebKitLegacy/win/ChangeLog (267591 => 267592)


--- trunk/Source/WebKitLegacy/win/ChangeLog	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/win/ChangeLog	2020-09-25 21:26:29 UTC (rev 267592)
@@ -1,3 +1,21 @@
+2020-09-25  Antoine Quint  <[email protected]>
+
+        Add an experimental feature flag for CSS individual transform properties
+        https://bugs.webkit.org/show_bug.cgi?id=216271
+        <rdar://problem/68914539>
+
+        Reviewed by Dean Jackson.
+
+        * Interfaces/IWebPreferencesPrivate.idl:
+        * WebPreferenceKeysPrivate.h:
+        * WebPreferences.cpp:
+        (WebPreferences::initializeDefaultSettings):
+        (WebPreferences::CSSIndividualTransformPropertiesEnabled):
+        (WebPreferences::setCSSIndividualTransformPropertiesEnabled):
+        * WebPreferences.h:
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
 2020-09-17  Sam Weinig  <[email protected]>
 
         Remove runtime setting for enabling/disabling the UserTiming and ResourceTiming APIs

Modified: trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl (267591 => 267592)


--- trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl	2020-09-25 21:26:29 UTC (rev 267592)
@@ -256,6 +256,8 @@
     HRESULT setAspectRatioOfImgFromWidthAndHeightEnabled([in] BOOL enabled);
     HRESULT setWebSQLEnabled([in] BOOL enabled);
     HRESULT webSQLEnabled([out, retval] BOOL* enabled);
+    HRESULT CSSIndividualTransformPropertiesEnabled([out, retval] BOOL* enabled);
+    HRESULT setCSSIndividualTransformPropertiesEnabled([in] BOOL enabled);
 }
 
 [uuid(04D4AAE1-5D01-4CCD-B46E-C022F10A6826)]

Modified: trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h (267591 => 267592)


--- trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h	2020-09-25 21:26:29 UTC (rev 267592)
@@ -227,3 +227,5 @@
 #define WebKitAspectRatioOfImgFromWidthAndHeightEnabledPreferenceKey "WebKitAspectRatioOfImgFromWidthAndHeightEnabled"
 
 #define WebKitWebSQLEnabledPreferenceKey "WebKitWebSQLEnabled"
+
+#define WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey "WebKitCSSIndividualTransformPropertiesEnabled"

Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (267591 => 267592)


--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp	2020-09-25 21:26:29 UTC (rev 267592)
@@ -343,6 +343,8 @@
 
     CFDictionaryAddValue(defaults, CFSTR(WebKitWebSQLEnabledPreferenceKey), kCFBooleanFalse);
 
+    CFDictionaryAddValue(defaults, CFSTR(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey), kCFBooleanFalse);
+
     defaultSettings = defaults;
 #endif
 }
@@ -2466,3 +2468,17 @@
     setBoolValue(WebKitWebAudioEnabledPreferenceKey, enabled);
     return S_OK;
 }
+
+HRESULT WebPreferences::CSSIndividualTransformPropertiesEnabled(_Out_ BOOL* enabled)
+{
+    if (!enabled)
+        return E_POINTER;
+    *enabled = boolValueForKey(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey);
+    return S_OK;
+}
+
+HRESULT WebPreferences::setCSSIndividualTransformPropertiesEnabled(BOOL enabled)
+{
+    setBoolValue(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey, enabled);
+    return S_OK;
+}

Modified: trunk/Source/WebKitLegacy/win/WebPreferences.h (267591 => 267592)


--- trunk/Source/WebKitLegacy/win/WebPreferences.h	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.h	2020-09-25 21:26:29 UTC (rev 267592)
@@ -297,6 +297,8 @@
     virtual HRESULT STDMETHODCALLTYPE setAspectRatioOfImgFromWidthAndHeightEnabled(BOOL);
     virtual HRESULT STDMETHODCALLTYPE webSQLEnabled(_Out_ BOOL*);
     virtual HRESULT STDMETHODCALLTYPE setWebSQLEnabled(BOOL);
+    virtual HRESULT STDMETHODCALLTYPE CSSIndividualTransformPropertiesEnabled(_Out_ BOOL*);
+    virtual HRESULT STDMETHODCALLTYPE setCSSIndividualTransformPropertiesEnabled(BOOL);
 
     // IWebPreferencesPrivate8
     virtual HRESULT STDMETHODCALLTYPE allowTopNavigationToDataURLs(_Out_ BOOL*);

Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (267591 => 267592)


--- trunk/Source/WebKitLegacy/win/WebView.cpp	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp	2020-09-25 21:26:29 UTC (rev 267592)
@@ -5304,6 +5304,11 @@
         return hr;
     settings.setCSSOMViewSmoothScrollingEnabled(!!enabled);
 
+    hr = prefsPrivate->CSSIndividualTransformPropertiesEnabled(&enabled);
+    if (FAILED(hr))
+        return hr;
+    settings.setCSSIndividualTransformPropertiesEnabled(!!enabled);
+
     hr = preferences->privateBrowsingEnabled(&enabled);
     if (FAILED(hr))
         return hr;

Modified: trunk/Tools/ChangeLog (267591 => 267592)


--- trunk/Tools/ChangeLog	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Tools/ChangeLog	2020-09-25 21:26:29 UTC (rev 267592)
@@ -1,3 +1,16 @@
+2020-09-25  Antoine Quint  <[email protected]>
+
+        Add an experimental feature flag for CSS individual transform properties
+        https://bugs.webkit.org/show_bug.cgi?id=216271
+        <rdar://problem/68914539>
+
+        Reviewed by Dean Jackson.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (enableExperimentalFeatures):
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (enableExperimentalFeatures):
+
 2020-09-25  Wenson Hsieh  <[email protected]>
 
         REGRESSION (r267516): `--use-gpu-process` no longer enables GPU process when running layout tests

Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (267591 => 267592)


--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2020-09-25 21:26:29 UTC (rev 267592)
@@ -837,6 +837,7 @@
     [preferences setLinkPreloadResponsiveImagesEnabled:YES];
     [preferences setAspectRatioOfImgFromWidthAndHeightEnabled:YES];
     [preferences setCSSOMViewSmoothScrollingEnabled:YES];
+    [preferences setCSSIndividualTransformPropertiesEnabled:YES];
 }
 
 // Called before each test.

Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (267591 => 267592)


--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2020-09-25 20:36:50 UTC (rev 267591)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2020-09-25 21:26:29 UTC (rev 267592)
@@ -804,6 +804,7 @@
     // FIXME: WebGL2
     // FIXME: WebRTC
     prefsPrivate->setCSSOMViewSmoothScrollingEnabled(TRUE);
+    prefsPrivate->setCSSIndividualTransformPropertiesEnabled(TRUE);
 }
 
 static void resetWebPreferencesToConsistentValues(IWebPreferences* preferences)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to