Log Message
Root node with stateless wheel event isn't always scrollable https://bugs.webkit.org/show_bug.cgi?id=216875
Reviewed by Simon Fraser. Root nodes are not always capable of handling wheel event. When it is a stateless wheel event which does not trigger rubber-band, we should check the scroll content of the root node. * page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::canHandleWheelEvent const): Stateless wheel event doesn't trigger rubber-band, should check the scroll content.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (267526 => 267527)
--- trunk/Source/WebCore/ChangeLog 2020-09-24 11:54:00 UTC (rev 267526)
+++ trunk/Source/WebCore/ChangeLog 2020-09-24 12:52:35 UTC (rev 267527)
@@ -1,3 +1,17 @@
+2020-09-24 Cathie Chen <[email protected]>
+
+ Root node with stateless wheel event isn't always scrollable
+ https://bugs.webkit.org/show_bug.cgi?id=216875
+
+ Reviewed by Simon Fraser.
+
+ Root nodes are not always capable of handling wheel event. When it is a stateless wheel event which
+ does not trigger rubber-band, we should check the scroll content of the root node.
+
+ * page/scrolling/ScrollingTreeScrollingNode.cpp:
+ (WebCore::ScrollingTreeScrollingNode::canHandleWheelEvent const): Stateless wheel event
+ doesn't trigger rubber-band, should check the scroll content.
+
2020-09-24 Commit Queue <[email protected]>
Unreviewed, reverting r267495 and r267512.
Modified: trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp (267526 => 267527)
--- trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp 2020-09-24 11:54:00 UTC (rev 267526)
+++ trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp 2020-09-24 12:52:35 UTC (rev 267527)
@@ -144,9 +144,10 @@
return true;
// We always rubber-band the latched node, or the root node.
- if (isLatchedNode() || isRootNode())
+ // The stateless wheel event doesn't trigger rubber-band.
+ if (isLatchedNode() || (isRootNode() && !wheelEvent.isNonGestureEvent()))
return true;
-
+
return eventCanScrollContents(wheelEvent);
}
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
