Title: [265025] trunk/Tools
Revision
265025
Author
d...@apple.com
Date
2020-07-28 18:30:31 -0700 (Tue, 28 Jul 2020)

Log Message

run-minibrowser doesn't respect webkit configuration
https://bugs.webkit.org/show_bug.cgi?id=214857
<rdar://problem/66187636>

Reviewed by Jonathan Bedard.

* Scripts/webkitpy/minibrowser/run_webkit_app.py:
(main): Don't force a Release configuration if none was given.
* Scripts/webkitpy/port/config.py:
(Config.flag_for_configuration): Look at the default configuration if we didn't
pass one in.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (265024 => 265025)


--- trunk/Tools/ChangeLog	2020-07-28 23:59:16 UTC (rev 265024)
+++ trunk/Tools/ChangeLog	2020-07-29 01:30:31 UTC (rev 265025)
@@ -1,3 +1,17 @@
+2020-07-28  Dean Jackson  <d...@apple.com>
+
+        run-minibrowser doesn't respect webkit configuration
+        https://bugs.webkit.org/show_bug.cgi?id=214857
+        <rdar://problem/66187636>
+
+        Reviewed by Jonathan Bedard.
+
+        * Scripts/webkitpy/minibrowser/run_webkit_app.py:
+        (main): Don't force a Release configuration if none was given.
+        * Scripts/webkitpy/port/config.py:
+        (Config.flag_for_configuration): Look at the default configuration if we didn't
+        pass one in.
+
 2020-07-28  Kate Cheney  <katherine_che...@apple.com>
 
         Migrate App-Bound Domains code from WebKit Additions

Modified: trunk/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py (265024 => 265025)


--- trunk/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py	2020-07-28 23:59:16 UTC (rev 265024)
+++ trunk/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py	2020-07-29 01:30:31 UTC (rev 265025)
@@ -48,9 +48,6 @@
                                help='Website URL to load')
     options, args = option_parser.parse_known_args(argv)
 
-    if not options.configuration:
-        options.configuration = "Release"
-
     if not options.platform:
         options.platform = "mac"
 

Modified: trunk/Tools/Scripts/webkitpy/port/config.py (265024 => 265025)


--- trunk/Tools/Scripts/webkitpy/port/config.py	2020-07-28 23:59:16 UTC (rev 265024)
+++ trunk/Tools/Scripts/webkitpy/port/config.py	2020-07-29 01:30:31 UTC (rev 265025)
@@ -105,6 +105,8 @@
         return self._build_directories[configuration]
 
     def flag_for_configuration(self, configuration):
+        if not configuration:
+            configuration = self.default_configuration()
         return self._FLAGS_FROM_CONFIGURATIONS[configuration]
 
     def default_configuration(self):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to