Title: [264929] trunk/Source/_javascript_Core
- Revision
- 264929
- Author
- ticaiol...@gmail.com
- Date
- 2020-07-27 10:26:11 -0700 (Mon, 27 Jul 2020)
Log Message
DoesGC failures in debug mode in 32bits
https://bugs.webkit.org/show_bug.cgi?id=214449
Reviewed by Mark Lam.
Adding the DoesGC update code into OSRExit::compileExit for 32-bits.
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::compileExit):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (264928 => 264929)
--- trunk/Source/_javascript_Core/ChangeLog 2020-07-27 17:03:58 UTC (rev 264928)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-07-27 17:26:11 UTC (rev 264929)
@@ -1,3 +1,15 @@
+2020-07-27 Caio Lima <ticaiol...@gmail.com>
+
+ DoesGC failures in debug mode in 32bits
+ https://bugs.webkit.org/show_bug.cgi?id=214449
+
+ Reviewed by Mark Lam.
+
+ Adding the DoesGC update code into OSRExit::compileExit for 32-bits.
+
+ * dfg/DFGOSRExit.cpp:
+ (JSC::DFG::OSRExit::compileExit):
+
2020-07-24 Mark Lam <mark....@apple.com>
pluginElementCustomGetOwnPropertySlot() should support VMInquiry requests.
Modified: trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp (264928 => 264929)
--- trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp 2020-07-27 17:03:58 UTC (rev 264928)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp 2020-07-27 17:26:11 UTC (rev 264929)
@@ -550,7 +550,6 @@
}
}
-#if USE(JSVALUE64)
if constexpr (validateDFGDoesGC) {
if (Options::validateDoesGC()) {
// We're about to exit optimized code. So, there's no longer any optimized
@@ -564,7 +563,6 @@
jit.store32(CCallHelpers::TrustedImm32(DoesGCCheck::encode(true, DoesGCCheck::Special::DFGOSRExit)), vm.heap.addressOfDoesGC());
}
}
-#endif
// Need to ensure that the stack pointer accounts for the worst-case stack usage at exit. This
// could toast some stack that the DFG used. We need to do it before storing to stack offsets
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
