Title: [264801] trunk
Revision
264801
Author
keith_mil...@apple.com
Date
2020-07-23 15:33:57 -0700 (Thu, 23 Jul 2020)

Log Message

iOS simulator does not support WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=191064

Reviewed by Yusuke Suzuki.

Source/WTF:

Now that it seems we can JIT in the Simulator we should enable
WebAssembly there. This just means enabling FTL/B3 so WASM gets
enabled.

* wtf/PlatformEnable.h:
* wtf/PlatformEnableCocoa.h:

LayoutTests:

Remove simulator only expectations/failures now that WebAssembly is available in the simulator.

* platform/ios-simulator/TestExpectations:
* platform/ios-simulator/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any-expected.txt:
* platform/ios-simulator/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.worker-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel-expected.txt:

Modified Paths

Removed Paths

  • trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/xhr/
  • trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/

Diff

Modified: trunk/LayoutTests/ChangeLog (264800 => 264801)


--- trunk/LayoutTests/ChangeLog	2020-07-23 22:28:51 UTC (rev 264800)
+++ trunk/LayoutTests/ChangeLog	2020-07-23 22:33:57 UTC (rev 264801)
@@ -1,3 +1,17 @@
+2020-07-23  Keith Miller  <keith_mil...@apple.com>
+
+        iOS simulator does not support WebAssembly
+        https://bugs.webkit.org/show_bug.cgi?id=191064
+
+        Reviewed by Yusuke Suzuki.
+
+        Remove simulator only expectations/failures now that WebAssembly is available in the simulator.
+
+        * platform/ios-simulator/TestExpectations:
+        * platform/ios-simulator/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any-expected.txt:
+        * platform/ios-simulator/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.worker-expected.txt:
+        * platform/ios-wk2/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel-expected.txt:
+
 2020-07-23  Ryan Haddad  <ryanhad...@apple.com>
 
         [ iOS wk2 ] imported/w3c/web-platform-tests/web-share/share-without-user-gesture.https.html is a constant timeout

Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (264800 => 264801)


--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2020-07-23 22:28:51 UTC (rev 264800)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2020-07-23 22:33:57 UTC (rev 264801)
@@ -41,30 +41,6 @@
 # we explicitly disallow this because this font is too slow.
 fast/text/initial-advance-in-intermediate-run-complex.html [ ImageOnlyFailure ]
 
-# Simulator doesn't support WebAssembly.
-http/tests/security/contentSecurityPolicy/WebAssembly-allowed.html [ Failure ]
-http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-about-blank-iframe.html [ Failure ]
-http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-external-script.html [ Failure ]
-http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-subframe.html [ Failure ]
-http/tests/security/contentSecurityPolicy/WebAssembly-blocked.html [ Failure ]
-imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.html [ Failure ]
-imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.serviceworker.html [ Failure ]
-imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-success.any.worker.html [ Failure ]
-wasm/iframe-postmessage.html [ Skip ]
-wasm/iframe-parent-postmessage.html [ Skip ]
-wasm/window-postmessage.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/encodeInto.any.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/encodeInto.any.worker.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.worker.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.worker.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.worker.html [ Skip ]
-imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel.html [ Skip ]
-imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.html [ Skip ]
-imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.worker.html [ Skip ]
-
 # These tests seem to fail due pixel rounding errors in the absolute positioned elements used as reference.
 webkit.org/b/170176 fast/inline-block/baseline-vertical-01.html [ ImageOnlyFailure ]
 webkit.org/b/170176 fast/inline-block/baseline-vertical-02.html [ ImageOnlyFailure ]

Modified: trunk/Source/WTF/ChangeLog (264800 => 264801)


--- trunk/Source/WTF/ChangeLog	2020-07-23 22:28:51 UTC (rev 264800)
+++ trunk/Source/WTF/ChangeLog	2020-07-23 22:33:57 UTC (rev 264801)
@@ -1,3 +1,17 @@
+2020-07-23  Keith Miller  <keith_mil...@apple.com>
+
+        iOS simulator does not support WebAssembly
+        https://bugs.webkit.org/show_bug.cgi?id=191064
+
+        Reviewed by Yusuke Suzuki.
+
+        Now that it seems we can JIT in the Simulator we should enable
+        WebAssembly there. This just means enabling FTL/B3 so WASM gets
+        enabled.
+
+        * wtf/PlatformEnable.h:
+        * wtf/PlatformEnableCocoa.h:
+
 2020-07-23  Aditya Keerthi  <akeer...@apple.com>
 
         [macOS] Datalist dropdown scrollbar position does not match visible region

Modified: trunk/Source/WTF/wtf/PlatformEnable.h (264800 => 264801)


--- trunk/Source/WTF/wtf/PlatformEnable.h	2020-07-23 22:28:51 UTC (rev 264800)
+++ trunk/Source/WTF/wtf/PlatformEnable.h	2020-07-23 22:33:57 UTC (rev 264801)
@@ -610,13 +610,6 @@
 #define ENABLE_FTL_JIT 0
 #endif
 
-/* FIXME: This should be turned into an #error invariant */
-/* The FTL is disabled on the iOS simulator, mostly for simplicity. */
-#if PLATFORM(IOS_FAMILY_SIMULATOR)
-#undef ENABLE_FTL_JIT
-#define ENABLE_FTL_JIT 0
-#endif
-
 /* If possible, try to enable a disassembler. This is optional. We proceed in two
    steps: first we try to find some disassembler that we can use, and then we
    decide if the high-level disassembler API can be enabled. */

Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (264800 => 264801)


--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2020-07-23 22:28:51 UTC (rev 264800)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2020-07-23 22:33:57 UTC (rev 264801)
@@ -204,7 +204,7 @@
 #define ENABLE_FILTERS_LEVEL_2 1
 #endif
 
-#if !defined(ENABLE_FTL_JIT) && !USE(JSVALUE32_64) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+#if !defined(ENABLE_FTL_JIT) && !USE(JSVALUE32_64)
 #define ENABLE_FTL_JIT 1
 #endif
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to