Title: [264083] releases/WebKitGTK/webkit-2.28/Source/WebCore
- Revision
- 264083
- Author
- carlo...@webkit.org
- Date
- 2020-07-08 03:07:20 -0700 (Wed, 08 Jul 2020)
Log Message
Merge r260886 - [GStreamer] Switch to audiointerleave
https://bugs.webkit.org/show_bug.cgi?id=211124
Patch by Philippe Normand <pnorm...@igalia.com> on 2020-04-29
Reviewed by Xabier Rodriguez-Calvar.
The audiointerleave element is a drop-in replacement of
interleave. It should behave a bit better in live.
No new tests, existing webaudio tests cover this change.
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcChangeState):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog (264082 => 264083)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-07-08 10:07:15 UTC (rev 264082)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-07-08 10:07:20 UTC (rev 264083)
@@ -1,3 +1,19 @@
+2020-04-29 Philippe Normand <pnorm...@igalia.com>
+
+ [GStreamer] Switch to audiointerleave
+ https://bugs.webkit.org/show_bug.cgi?id=211124
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ The audiointerleave element is a drop-in replacement of
+ interleave. It should behave a bit better in live.
+
+ No new tests, existing webaudio tests cover this change.
+
+ * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
+ (webKitWebAudioSrcConstructed):
+ (webKitWebAudioSrcChangeState):
+
2020-04-30 Philippe Normand <pnorm...@igalia.com>
Unreviewed, GStreamer build warning fix after r260755.
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp (264082 => 264083)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2020-07-08 10:07:15 UTC (rev 264082)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2020-07-08 10:07:20 UTC (rev 264083)
@@ -211,10 +211,10 @@
ASSERT(priv->provider);
ASSERT(priv->sampleRate);
- priv->interleave = gst_element_factory_make("interleave", nullptr);
+ priv->interleave = gst_element_factory_make("audiointerleave", nullptr);
if (!priv->interleave) {
- GST_ERROR_OBJECT(src, "Failed to create interleave");
+ GST_ERROR_OBJECT(src, "Failed to create audiointerleave");
return;
}
@@ -398,8 +398,8 @@
switch (transition) {
case GST_STATE_CHANGE_NULL_TO_READY:
if (!src->priv->interleave) {
- gst_element_post_message(element, gst_missing_element_message_new(element, "interleave"));
- GST_ELEMENT_ERROR(src, CORE, MISSING_PLUGIN, (nullptr), ("no interleave"));
+ gst_element_post_message(element, gst_missing_element_message_new(element, "audiointerleave"));
+ GST_ELEMENT_ERROR(src, CORE, MISSING_PLUGIN, (nullptr), ("no audiointerleave"));
return GST_STATE_CHANGE_FAILURE;
}
src->priv->numberOfSamples = 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
