Title: [264015] trunk/Source/WTF
- Revision
- 264015
- Author
- [email protected]
- Date
- 2020-07-07 06:56:37 -0700 (Tue, 07 Jul 2020)
Log Message
[GTK] WebProcess hangs when browsing GitHub
https://bugs.webkit.org/show_bug.cgi?id=213970
Reviewed by Sergio Villar Senin.
Use a lower priority for LayerFlushTimer and DisplayRefreshMonitorTimer. We were using a very high priority for
drawing with the idea of keeping a good rendering performance without being affected by other timers. The
problem is that animations can be controlled by timers, so we need to ensure that MainThreadSharedTimer has
higher priority than drawing.
* wtf/glib/RunLoopSourcePriority.h: Use 110 for LayerFlushTimer and DisplayRefreshMonitorTimer.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (264014 => 264015)
--- trunk/Source/WTF/ChangeLog 2020-07-07 11:31:27 UTC (rev 264014)
+++ trunk/Source/WTF/ChangeLog 2020-07-07 13:56:37 UTC (rev 264015)
@@ -1,3 +1,17 @@
+2020-07-07 Carlos Garcia Campos <[email protected]>
+
+ [GTK] WebProcess hangs when browsing GitHub
+ https://bugs.webkit.org/show_bug.cgi?id=213970
+
+ Reviewed by Sergio Villar Senin.
+
+ Use a lower priority for LayerFlushTimer and DisplayRefreshMonitorTimer. We were using a very high priority for
+ drawing with the idea of keeping a good rendering performance without being affected by other timers. The
+ problem is that animations can be controlled by timers, so we need to ensure that MainThreadSharedTimer has
+ higher priority than drawing.
+
+ * wtf/glib/RunLoopSourcePriority.h: Use 110 for LayerFlushTimer and DisplayRefreshMonitorTimer.
+
2020-07-06 Geoffrey Garen <[email protected]>
callOnMainThread should use the same queue as RunLoop::dispatch
Modified: trunk/Source/WTF/wtf/glib/RunLoopSourcePriority.h (264014 => 264015)
--- trunk/Source/WTF/wtf/glib/RunLoopSourcePriority.h 2020-07-07 11:31:27 UTC (rev 264014)
+++ trunk/Source/WTF/wtf/glib/RunLoopSourcePriority.h 2020-07-07 13:56:37 UTC (rev 264015)
@@ -35,7 +35,7 @@
// G_PRIORITY_HIGH = -100
// We don't use those macros here to avoid having to include glib header only
// for this. But we should take into account that GLib uses G_PRIORITY_DEFAULT
-// for timeout sourcea and G_PRIORITY_DEFAULT_IDLE for idle sources.
+// for timeout sources and G_PRIORITY_DEFAULT_IDLE for idle sources.
// Changes in these priorities can have a huge impact in performance, and in
// the correctness too, so be careful when changing them.
enum RunLoopSourcePriority {
@@ -61,10 +61,10 @@
CompositingThreadUpdateTimer = 110,
// Layer flush.
- LayerFlushTimer = -100,
+ LayerFlushTimer = 110,
// DisplayRefreshMonitor timer, should have the same value as the LayerFlushTimer.
- DisplayRefreshMonitorTimer = -100,
+ DisplayRefreshMonitorTimer = 110,
// Rendering timer in the main thread when accelerated compositing is not used.
NonAcceleratedDrawingTimer = 100,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
