Title: [264013] trunk
- Revision
- 264013
- Author
- [email protected]
- Date
- 2020-07-07 04:08:21 -0700 (Tue, 07 Jul 2020)
Log Message
[GStreamer] OGV/VP8 video not playing on minibrowser (neither epiphany)
https://bugs.webkit.org/show_bug.cgi?id=205916
Patch by Philippe Normand <[email protected]> on 2020-07-07
Reviewed by Xabier Rodriguez-Calvar.
Tools:
* buildstream/elements/sdk/gst-plugins-base.bst: Vendor upstreamed GStreamer patch. It is
merged in the 1.16 branch and scheduled for 1.16.3 release but we don't know when/if it will
happen.
* buildstream/patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch: Added.
LayoutTests:
* platform/glib/TestExpectations: Update WPT expectations
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (264012 => 264013)
--- trunk/LayoutTests/ChangeLog 2020-07-07 08:03:42 UTC (rev 264012)
+++ trunk/LayoutTests/ChangeLog 2020-07-07 11:08:21 UTC (rev 264013)
@@ -1,3 +1,12 @@
+2020-07-07 Philippe Normand <[email protected]>
+
+ [GStreamer] OGV/VP8 video not playing on minibrowser (neither epiphany)
+ https://bugs.webkit.org/show_bug.cgi?id=205916
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/glib/TestExpectations: Update WPT expectations
+
2020-07-06 Lauro Moura <[email protected]>
[GTK][WPE] Imported semantics tests gardening after r263987
Modified: trunk/LayoutTests/platform/glib/TestExpectations (264012 => 264013)
--- trunk/LayoutTests/platform/glib/TestExpectations 2020-07-07 08:03:42 UTC (rev 264012)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2020-07-07 11:08:21 UTC (rev 264013)
@@ -143,9 +143,7 @@
webkit.org/b/211995 fast/images/animated-image-mp4.html [ Failure ]
webkit.org/b/213947 media/vp9.html [ Failure ]
-# These two are affected by a broken ogv that can't be read by the Gstreamer from SDK.
-webkit.org/b/205916 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cues-cuechange.html [ Skip ]
-webkit.org/b/205916 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cues-cuechange-dynamically-created-track-element.html [ Skip ]
+webkit.org/b/214038 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cues-cuechange.html [ Missing Failure ]
webkit.org/b/214031 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video-poster-shown-preload-auto.html [ ImageOnlyFailure ]
Modified: trunk/Tools/ChangeLog (264012 => 264013)
--- trunk/Tools/ChangeLog 2020-07-07 08:03:42 UTC (rev 264012)
+++ trunk/Tools/ChangeLog 2020-07-07 11:08:21 UTC (rev 264013)
@@ -1,3 +1,15 @@
+2020-07-07 Philippe Normand <[email protected]>
+
+ [GStreamer] OGV/VP8 video not playing on minibrowser (neither epiphany)
+ https://bugs.webkit.org/show_bug.cgi?id=205916
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * buildstream/elements/sdk/gst-plugins-base.bst: Vendor upstreamed GStreamer patch. It is
+ merged in the 1.16 branch and scheduled for 1.16.3 release but we don't know when/if it will
+ happen.
+ * buildstream/patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch: Added.
+
2020-07-07 Yury Semikhatsky <[email protected]>
[GTK][MiniBrowser] occasional crashes when closing while download in progress
Modified: trunk/Tools/buildstream/elements/sdk/gst-plugins-base.bst (264012 => 264013)
--- trunk/Tools/buildstream/elements/sdk/gst-plugins-base.bst 2020-07-07 08:03:42 UTC (rev 264012)
+++ trunk/Tools/buildstream/elements/sdk/gst-plugins-base.bst 2020-07-07 11:08:21 UTC (rev 264013)
@@ -11,6 +11,9 @@
path: patches/gst-plugins-base-0002-glupload-fix-segfault.patch
- kind: patch
path: patches/gst-plugins-base-0003-glbasefilter-add-support-for-changing-the-display.patch
+- kind: patch
+ path: patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch
+
build-depends:
- freedesktop-sdk.bst:public-stacks/buildsystem-meson.bst
depends:
Added: trunk/Tools/buildstream/patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch (0 => 264013)
--- trunk/Tools/buildstream/patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch (rev 0)
+++ trunk/Tools/buildstream/patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch 2020-07-07 11:08:21 UTC (rev 264013)
@@ -0,0 +1,32 @@
+From 2e40379e7ace9c43d9edebe9556b37b541c67da7 Mon Sep 17 00:00:00 2001
+From: Philippe Normand <[email protected]>
+Date: Mon, 13 Jan 2020 09:06:02 +0000
+Subject: [PATCH] oggstream: Workaround for broken PAR in VP8 BOS
+
+Similarily to the Theora mapping, process 0:N, N:0 and 0:0 pixel aspect ratios
+as 1:1.
+
+Fixes #719
+---
+ ext/ogg/gstoggstream.c | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/ext/ogg/gstoggstream.c b/ext/ogg/gstoggstream.c
+index cdb6fa6ad..3894ae741 100644
+--- a/ext/ogg/gstoggstream.c
++++ b/ext/ogg/gstoggstream.c
+@@ -677,6 +677,11 @@ setup_vp8_mapper (GstOggStream * pad, ogg_packet * packet)
+ pad->n_header_packets = 2;
+ pad->frame_size = 1;
+
++ /* PAR of 0:N, N:0 and 0:0 is not explicitely allowed, but the best we can do
++ * here is to map to 1:1 so that caps negotiation doesn't break downstream. */
++ if (par_n == 0 || par_d == 0)
++ par_n = par_d = 1;
++
+ pad->caps = gst_caps_new_simple ("video/x-vp8",
+ "width", G_TYPE_INT, width,
+ "height", G_TYPE_INT, height,
+--
+2.26.2
+
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
