- Revision
- 263718
- Author
- commit-qu...@webkit.org
- Date
- 2020-06-29 18:59:29 -0700 (Mon, 29 Jun 2020)
Log Message
Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
https://bugs.webkit.org/show_bug.cgi?id=213578
Patch by Guowei Yang <guowei_y...@apple.com> on 2020-06-29
.:
Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.
* Source/cmake/WebKitFeatures.cmake: added definition of
CoreImage-accelerated filter rendering feature flag,
ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
Source/WebCore:
Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.
No tests are required because this is just a feature flag set up
* page/Settings.yaml: added default settings for the feature flag.
Default value of the feature switch is off
Source/WebKit:
Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.
* Shared/WebPreferences.yaml: added feature flag definition
Source/WTF:
Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.
* wtf/PlatformEnableCocoa.h: Added definition of a feature flag,
ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
* wtf/PlatformUse.h: Added compiler guard #define USE_CORE_IMAGE 1
to indicate whether CoreImage code is visible to the compiler
Modified Paths
Diff
Modified: trunk/ChangeLog (263717 => 263718)
--- trunk/ChangeLog 2020-06-30 01:49:46 UTC (rev 263717)
+++ trunk/ChangeLog 2020-06-30 01:59:29 UTC (rev 263718)
@@ -1,3 +1,17 @@
+2020-06-29 Guowei Yang <guowei_y...@apple.com>
+
+ Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
+ https://bugs.webkit.org/show_bug.cgi?id=213578
+
+ Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
+
+ Preparing to implement CoreImage backed filter rendering
+ Needs Compiler guards and experimental feature guard.
+
+ * Source/cmake/WebKitFeatures.cmake: added definition of
+ CoreImage-accelerated filter rendering feature flag,
+ ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
+
2020-06-29 Tetsuharu Ohzeki <tetsuharu.ohz...@gmail.com>
Remove ENABLE_STREAMS_API compilation flag
Modified: trunk/Source/WTF/ChangeLog (263717 => 263718)
--- trunk/Source/WTF/ChangeLog 2020-06-30 01:49:46 UTC (rev 263717)
+++ trunk/Source/WTF/ChangeLog 2020-06-30 01:59:29 UTC (rev 263718)
@@ -1,3 +1,18 @@
+2020-06-29 Guowei Yang <guowei_y...@apple.com>
+
+ Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
+ https://bugs.webkit.org/show_bug.cgi?id=213578
+
+ Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
+
+ Preparing to implement CoreImage backed filter rendering
+ Needs Compiler guards and experimental feature guard.
+
+ * wtf/PlatformEnableCocoa.h: Added definition of a feature flag,
+ ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
+ * wtf/PlatformUse.h: Added compiler guard #define USE_CORE_IMAGE 1
+ to indicate whether CoreImage code is visible to the compiler
+
2020-06-29 Tetsuharu Ohzeki <tetsuharu.ohz...@gmail.com>
Remove ENABLE_STREAMS_API compilation flag
Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (263717 => 263718)
--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-06-30 01:49:46 UTC (rev 263717)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-06-30 01:59:29 UTC (rev 263718)
@@ -47,6 +47,10 @@
#define ENABLE_ACCESSIBILITY_ISOLATED_TREE 1
#endif
+#if !defined(ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER)
+#define ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER 1
+#endif
+
#if !defined(ENABLE_AIRPLAY_PICKER) && (PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST))
#define ENABLE_AIRPLAY_PICKER 1
#endif
Modified: trunk/Source/WTF/wtf/PlatformUse.h (263717 => 263718)
--- trunk/Source/WTF/wtf/PlatformUse.h 2020-06-30 01:49:46 UTC (rev 263717)
+++ trunk/Source/WTF/wtf/PlatformUse.h 2020-06-30 01:59:29 UTC (rev 263718)
@@ -58,6 +58,10 @@
#define USE_CA 1
#endif
+#if PLATFORM(COCOA)
+#define USE_CORE_IMAGE 1
+#endif
+
#if PLATFORM(GTK) || PLATFORM(WPE)
#define USE_GLIB 1
#endif
Modified: trunk/Source/WebCore/ChangeLog (263717 => 263718)
--- trunk/Source/WebCore/ChangeLog 2020-06-30 01:49:46 UTC (rev 263717)
+++ trunk/Source/WebCore/ChangeLog 2020-06-30 01:59:29 UTC (rev 263718)
@@ -1,3 +1,18 @@
+2020-06-29 Guowei Yang <guowei_y...@apple.com>
+
+ Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
+ https://bugs.webkit.org/show_bug.cgi?id=213578
+
+ Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
+
+ Preparing to implement CoreImage backed filter rendering
+ Needs Compiler guards and experimental feature guard.
+
+ No tests are required because this is just a feature flag set up
+
+ * page/Settings.yaml: added default settings for the feature flag.
+ Default value of the feature switch is off
+
2020-06-29 Stephan Szabo <stephan.sz...@sony.com>
Fix build when !ENABLE(ACCESSIBILITY) after r263673
Modified: trunk/Source/WebCore/page/Settings.yaml (263717 => 263718)
--- trunk/Source/WebCore/page/Settings.yaml 2020-06-30 01:49:46 UTC (rev 263717)
+++ trunk/Source/WebCore/page/Settings.yaml 2020-06-30 01:59:29 UTC (rev 263718)
@@ -419,6 +419,10 @@
initial: false
onChange: setNeedsRelayoutAllFrames
+coreImageAcceleratedFilterRenderEnabled:
+ initial: false
+ onChange: setNeedsRelayoutAllFrames
+
legacyOverflowScrollingTouchEnabled:
initial: true
onChange: setNeedsRelayoutAllFrames
Modified: trunk/Source/WebKit/ChangeLog (263717 => 263718)
--- trunk/Source/WebKit/ChangeLog 2020-06-30 01:49:46 UTC (rev 263717)
+++ trunk/Source/WebKit/ChangeLog 2020-06-30 01:59:29 UTC (rev 263718)
@@ -1,3 +1,15 @@
+2020-06-29 Guowei Yang <guowei_y...@apple.com>
+
+ Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
+ https://bugs.webkit.org/show_bug.cgi?id=213578
+
+ Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
+
+ Preparing to implement CoreImage backed filter rendering
+ Needs Compiler guards and experimental feature guard.
+
+ * Shared/WebPreferences.yaml: added feature flag definition
+
2020-06-29 Peng Liu <peng.l...@apple.com>
Video spills over PiP screen a little when using Picture in Picture
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (263717 => 263718)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-06-30 01:49:46 UTC (rev 263717)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-06-30 01:59:29 UTC (rev 263718)
@@ -2060,3 +2060,11 @@
type: bool
defaultValue: true
condition: ENABLE(MEDIA_STREAM)
+
+CoreImageAcceleratedFilterRenderEnabled:
+ type: bool
+ defaultValue: false
+ humanReadableName: "CoreImage-Accelerated Filter Rendering"
+ humanReadableDescription: "Accelerated CSS and SVG filter rendering using CoreImage"
+ category: experimental
+ condition: ENABLE(CORE_IMAGE_ACCELERATED_FILTER_RENDER)
Modified: trunk/Source/cmake/WebKitFeatures.cmake (263717 => 263718)
--- trunk/Source/cmake/WebKitFeatures.cmake 2020-06-30 01:49:46 UTC (rev 263717)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2020-06-30 01:59:29 UTC (rev 263718)
@@ -97,6 +97,7 @@
WEBKIT_OPTION_DEFINE(ENABLE_3D_TRANSFORMS "Toggle 3D transforms support" PRIVATE ON)
WEBKIT_OPTION_DEFINE(ENABLE_ACCELERATED_2D_CANVAS "Toggle Accelerated 2D Canvas support" PRIVATE OFF)
+ WEBKIT_OPTION_DEFINE(ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER "Toggle Accelerated CSS/SVG Filter Rendering using CoreImage" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_ACCESSIBILITY "Whether to enable support for accessibility" PRIVATE ON)
WEBKIT_OPTION_DEFINE(ENABLE_ACCESSIBILITY_ISOLATED_TREE "Toggle accessibility isolated tree support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_API_TESTS "Enable public API unit tests" PRIVATE OFF)
