Title: [104408] trunk/Source/WebCore
- Revision
- 104408
- Author
- [email protected]
- Date
- 2012-01-08 13:33:43 -0800 (Sun, 08 Jan 2012)
Log Message
Remove unused security functions from V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=75797
Reviewed by Eric Seidel.
This functions have no callers. They can be removed.
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
* bindings/v8/specialization/V8BindingState.cpp:
* bindings/v8/specialization/V8BindingState.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (104407 => 104408)
--- trunk/Source/WebCore/ChangeLog 2012-01-08 21:31:02 UTC (rev 104407)
+++ trunk/Source/WebCore/ChangeLog 2012-01-08 21:33:43 UTC (rev 104408)
@@ -1,3 +1,17 @@
+2012-01-08 Adam Barth <[email protected]>
+
+ Remove unused security functions from V8 bindings
+ https://bugs.webkit.org/show_bug.cgi?id=75797
+
+ Reviewed by Eric Seidel.
+
+ This functions have no callers. They can be removed.
+
+ * bindings/v8/ScriptController.cpp:
+ * bindings/v8/ScriptController.h:
+ * bindings/v8/specialization/V8BindingState.cpp:
+ * bindings/v8/specialization/V8BindingState.h:
+
2012-01-08 Pratik Solanki <[email protected]>
Assertion failure under SharedBuffer::append() when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
Modified: trunk/Source/WebCore/bindings/v8/ScriptController.cpp (104407 => 104408)
--- trunk/Source/WebCore/bindings/v8/ScriptController.cpp 2012-01-08 21:31:02 UTC (rev 104407)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.cpp 2012-01-08 21:33:43 UTC (rev 104408)
@@ -102,11 +102,6 @@
return !v8::Context::InContext() || V8BindingSecurity::canAccessFrame(V8BindingState::Only(), frame, true);
}
-bool ScriptController::isSafeScript(Frame* target)
-{
- return V8BindingSecurity::canAccessFrame(V8BindingState::Only(), target, true);
-}
-
ScriptController::ScriptController(Frame* frame)
: m_frame(frame)
, m_sourceURL(0)
Modified: trunk/Source/WebCore/bindings/v8/ScriptController.h (104407 => 104408)
--- trunk/Source/WebCore/bindings/v8/ScriptController.h 2012-01-08 21:31:02 UTC (rev 104407)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.h 2012-01-08 21:33:43 UTC (rev 104408)
@@ -147,9 +147,6 @@
// V8Proxy::retrieveFrameForEnteredContext() for more information.
static Frame* retrieveFrameForCurrentContext();
- // Check whether it is safe to access a frame in another domain.
- static bool isSafeScript(Frame*);
-
// Pass command-line flags to the JS engine.
static void setFlags(const char* string, int length);
Modified: trunk/Source/WebCore/bindings/v8/specialization/V8BindingState.cpp (104407 => 104408)
--- trunk/Source/WebCore/bindings/v8/specialization/V8BindingState.cpp 2012-01-08 21:31:02 UTC (rev 104407)
+++ trunk/Source/WebCore/bindings/v8/specialization/V8BindingState.cpp 2012-01-08 21:33:43 UTC (rev 104408)
@@ -84,9 +84,4 @@
V8Proxy::reportUnsafeAccessTo(target);
}
-bool State<V8Binding>::allowsAccessFromFrame(Frame* frame)
-{
- return ScriptController::isSafeScript(frame);
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/v8/specialization/V8BindingState.h (104407 => 104408)
--- trunk/Source/WebCore/bindings/v8/specialization/V8BindingState.h 2012-01-08 21:31:02 UTC (rev 104407)
+++ trunk/Source/WebCore/bindings/v8/specialization/V8BindingState.h 2012-01-08 21:33:43 UTC (rev 104408)
@@ -55,9 +55,6 @@
Frame* activeFrame();
Frame* firstFrame();
- // FIXME: This should be shared in BindingSecurity
- bool allowsAccessFromFrame(Frame*);
-
private:
explicit State() {}
~State();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
