Title: [104195] trunk/Tools
- Revision
- 104195
- Author
- [email protected]
- Date
- 2012-01-05 12:28:48 -0800 (Thu, 05 Jan 2012)
Log Message
Remove some unnecessary code from old-run-webkit-tests
Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
WebKitTestRunner.
Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
Windows
Reviewed by Eric Seidel.
* Scripts/old-run-webkit-tests:
(top level):
(openDumpTool):
Removed calls to setPathForRunningWebKitApp.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (104194 => 104195)
--- trunk/Tools/ChangeLog 2012-01-05 20:18:59 UTC (rev 104194)
+++ trunk/Tools/ChangeLog 2012-01-05 20:28:48 UTC (rev 104195)
@@ -1,5 +1,22 @@
2012-01-05 Adam Roben <[email protected]>
+ Remove some unnecessary code from old-run-webkit-tests
+
+ Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
+ WebKitTestRunner.
+
+ Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
+ Windows
+
+ Reviewed by Eric Seidel.
+
+ * Scripts/old-run-webkit-tests:
+ (top level):
+ (openDumpTool):
+ Removed calls to setPathForRunningWebKitApp.
+
+2012-01-05 Adam Roben <[email protected]>
+
Teach NRWT to use run-safari to open results.html on Apple's Windows port
NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
Modified: trunk/Tools/Scripts/old-run-webkit-tests (104194 => 104195)
--- trunk/Tools/Scripts/old-run-webkit-tests 2012-01-05 20:18:59 UTC (rev 104194)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2012-01-05 20:28:48 UTC (rev 104195)
@@ -547,7 +547,6 @@
if (isCygwin()) {
# Collect supported features list
- setPathForRunningWebKitApp(\%ENV);
my $supportedFeaturesCommand = "\"$dumpTool\" --print-supported-features 2>&1";
$supportedFeaturesResult = `$supportedFeaturesCommand 2>&1`;
}
@@ -1509,8 +1508,6 @@
$CLEAN_ENV{HOMEDRIVE} = $ENV{'HOMEDRIVE'};
$CLEAN_ENV{HOMEPATH} = $ENV{'HOMEPATH'};
$CLEAN_ENV{_NT_SYMBOL_PATH} = $ENV{_NT_SYMBOL_PATH};
-
- setPathForRunningWebKitApp(\%CLEAN_ENV);
}
# Port specifics
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
