Title: [259855] trunk/Source/WebKit
- Revision
- 259855
- Author
- csaave...@igalia.com
- Date
- 2020-04-10 03:31:01 -0700 (Fri, 10 Apr 2020)
Log Message
[GTK] Drop deprecated Drag and Drop API use
https://bugs.webkit.org/show_bug.cgi?id=210327
Reviewed by Adrian Perez de Castro.
Use gtk_drag_begin_with_coordinates(), even if we let it guess the
coordinates itself from the event, as gtk_drag_begin() is
deprecated.
* UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::startDrag):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (259854 => 259855)
--- trunk/Source/WebKit/ChangeLog 2020-04-10 10:25:30 UTC (rev 259854)
+++ trunk/Source/WebKit/ChangeLog 2020-04-10 10:31:01 UTC (rev 259855)
@@ -1,3 +1,17 @@
+2020-04-10 Claudio Saavedra <csaave...@igalia.com>
+
+ [GTK] Drop deprecated Drag and Drop API use
+ https://bugs.webkit.org/show_bug.cgi?id=210327
+
+ Reviewed by Adrian Perez de Castro.
+
+ Use gtk_drag_begin_with_coordinates(), even if we let it guess the
+ coordinates itself from the event, as gtk_drag_begin() is
+ deprecated.
+
+ * UIProcess/gtk/DragAndDropHandler.cpp:
+ (WebKit::DragAndDropHandler::startDrag):
+
2020-04-09 David Kilzer <ddkil...@apple.com>
Add WARN_UNUSED_RETURN to decode methods in Source/WebKit/Platform/IPC
Modified: trunk/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp (259854 => 259855)
--- trunk/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp 2020-04-10 10:25:30 UTC (rev 259854)
+++ trunk/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp 2020-04-10 10:31:01 UTC (rev 259855)
@@ -118,8 +118,8 @@
GRefPtr<GtkTargetList> targetList = PasteboardHelper::singleton().targetListForSelectionData(*m_draggingSelectionData);
GUniquePtr<GdkEvent> currentEvent(gtk_get_current_event());
- GdkDragContext* context = gtk_drag_begin(m_page.viewWidget(), targetList.get(), dragOperationToGdkDragActions(dragOperation),
- GDK_BUTTON_PRIMARY, currentEvent.get());
+ GdkDragContext* context = gtk_drag_begin_with_coordinates(m_page.viewWidget(), targetList.get(), dragOperationToGdkDragActions(dragOperation),
+ GDK_BUTTON_PRIMARY, currentEvent.get(), -1, -1);
m_dragContext = context;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
