Title: [259665] trunk/Source/WebKit
- Revision
- 259665
- Author
- [email protected]
- Date
- 2020-04-07 13:07:46 -0700 (Tue, 07 Apr 2020)
Log Message
Web Automation: Automation.inspectBrowsingContext should bring Web Inspector to front automatically
https://bugs.webkit.org/show_bug.cgi?id=210137
Reviewed by Joseph Pecoraro.
* UIProcess/Automation/mac/WebAutomationSessionMac.mm:
(WebKit::WebAutomationSession::inspectBrowsingContext):
Previously, calling connect() would preload Web Inspector but not show its window. This
made it awkward to use the 'safari:automaticInspection' capability without subsequently
evaluating a `debugger;` statement to bring Web Inspector to front.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (259664 => 259665)
--- trunk/Source/WebKit/ChangeLog 2020-04-07 20:03:20 UTC (rev 259664)
+++ trunk/Source/WebKit/ChangeLog 2020-04-07 20:07:46 UTC (rev 259665)
@@ -1,3 +1,16 @@
+2020-04-07 Brian Burg <[email protected]>
+
+ Web Automation: Automation.inspectBrowsingContext should bring Web Inspector to front automatically
+ https://bugs.webkit.org/show_bug.cgi?id=210137
+
+ Reviewed by Joseph Pecoraro.
+
+ * UIProcess/Automation/mac/WebAutomationSessionMac.mm:
+ (WebKit::WebAutomationSession::inspectBrowsingContext):
+ Previously, calling connect() would preload Web Inspector but not show its window. This
+ made it awkward to use the 'safari:automaticInspection' capability without subsequently
+ evaluating a `debugger;` statement to bring Web Inspector to front.
+
2020-04-07 Kate Cheney <[email protected]>
Return app-bound sessions for instances where WKAppBoundDomains is
Modified: trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm (259664 => 259665)
--- trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm 2020-04-07 20:03:20 UTC (rev 259664)
+++ trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm 2020-04-07 20:07:46 UTC (rev 259665)
@@ -57,7 +57,7 @@
// Don't bring the inspector to front since this may be done automatically.
// We just want it loaded so it can pause if a breakpoint is hit during a command.
if (page->inspector()) {
- page->inspector()->connect();
+ page->inspector()->show();
// Start collecting profile information immediately so the entire session is captured.
if (optionalEnableAutoCapturing && *optionalEnableAutoCapturing)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
