Log Message
Update JSTests to assume ICU 60+ https://bugs.webkit.org/show_bug.cgi?id=210085
Reviewed by Yusuke Suzuki. * stress/intl-collator.js: * stress/intl-constructors-with-proxy.js: * stress/intl-datetimeformat.js: * stress/intl-default-locale.js: * stress/intl-numberformat-format-to-parts.js: * stress/intl-numberformat.js: Ensure a test case doesn't depend on behavior changed in ICU 64. * stress/intl-object.js: * stress/intl-pluralrules.js: Correct two invalid test cases. * test262/config.yaml: Remove skips.
Modified Paths
- trunk/JSTests/ChangeLog
- trunk/JSTests/stress/intl-collator.js
- trunk/JSTests/stress/intl-constructors-with-proxy.js
- trunk/JSTests/stress/intl-datetimeformat.js
- trunk/JSTests/stress/intl-default-locale.js
- trunk/JSTests/stress/intl-numberformat-format-to-parts.js
- trunk/JSTests/stress/intl-numberformat.js
- trunk/JSTests/stress/intl-object.js
- trunk/JSTests/stress/intl-pluralrules.js
- trunk/JSTests/test262/config.yaml
Diff
Modified: trunk/JSTests/ChangeLog (259657 => 259658)
--- trunk/JSTests/ChangeLog 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/ChangeLog 2020-04-07 19:35:54 UTC (rev 259658)
@@ -1,3 +1,21 @@
+2020-04-07 Ross Kirsling <[email protected]>
+
+ Update JSTests to assume ICU 60+
+ https://bugs.webkit.org/show_bug.cgi?id=210085
+
+ Reviewed by Yusuke Suzuki.
+
+ * stress/intl-collator.js:
+ * stress/intl-constructors-with-proxy.js:
+ * stress/intl-datetimeformat.js:
+ * stress/intl-default-locale.js:
+ * stress/intl-numberformat-format-to-parts.js:
+ * stress/intl-numberformat.js: Ensure a test case doesn't depend on behavior changed in ICU 64.
+ * stress/intl-object.js:
+ * stress/intl-pluralrules.js: Correct two invalid test cases.
+ * test262/config.yaml:
+ Remove skips.
+
2020-04-07 Yusuke Suzuki <[email protected]>
[JSC] ScopedArgumentsTable should handle OOM in tolerant manner
Modified: trunk/JSTests/stress/intl-collator.js (259657 => 259658)
--- trunk/JSTests/stress/intl-collator.js 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/stress/intl-collator.js 2020-04-07 19:35:54 UTC (rev 259658)
@@ -1,5 +1,3 @@
-//@ skip if $hostOS == "windows"
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error(`expected ${expected} but got ${actual}`);
Modified: trunk/JSTests/stress/intl-constructors-with-proxy.js (259657 => 259658)
--- trunk/JSTests/stress/intl-constructors-with-proxy.js 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/stress/intl-constructors-with-proxy.js 2020-04-07 19:35:54 UTC (rev 259658)
@@ -1,5 +1,3 @@
-//@ skip if $hostOS == "windows"
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error('bad value: ' + actual);
Modified: trunk/JSTests/stress/intl-datetimeformat.js (259657 => 259658)
--- trunk/JSTests/stress/intl-datetimeformat.js 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/stress/intl-datetimeformat.js 2020-04-07 19:35:54 UTC (rev 259658)
@@ -1,5 +1,3 @@
-//@ skip if $hostOS == "windows"
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error(`expected ${expected} but got ${actual}`);
Modified: trunk/JSTests/stress/intl-default-locale.js (259657 => 259658)
--- trunk/JSTests/stress/intl-default-locale.js 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/stress/intl-default-locale.js 2020-04-07 19:35:54 UTC (rev 259658)
@@ -1,5 +1,3 @@
-//@ skip if $hostOS == "windows"
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error(`expected ${expected} but got ${actual}`);
Modified: trunk/JSTests/stress/intl-numberformat-format-to-parts.js (259657 => 259658)
--- trunk/JSTests/stress/intl-numberformat-format-to-parts.js 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/stress/intl-numberformat-format-to-parts.js 2020-04-07 19:35:54 UTC (rev 259658)
@@ -1,5 +1,3 @@
-//@ skip if $hostOS == "windows" or $hostOS == "darwin"
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error(`expected ${expected} but got ${actual}`);
Modified: trunk/JSTests/stress/intl-numberformat.js (259657 => 259658)
--- trunk/JSTests/stress/intl-numberformat.js 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/stress/intl-numberformat.js 2020-04-07 19:35:54 UTC (rev 259658)
@@ -1,5 +1,3 @@
-//@ skip if $hostOS == "windows" or $hostOS == "darwin" or $hostOS == "linux"
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error(`expected ${expected} but got ${actual}`);
@@ -341,9 +339,9 @@
shouldBe(Intl.NumberFormat('en', { maximumSignificantDigits: 15 }).format(Number.MAX_VALUE), '179,769,313,486,232,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000');
// Test locales.
-shouldBe(Intl.NumberFormat('en').format(1234.567), '1,234.567');
-shouldBe(Intl.NumberFormat('es').format(1234.567), '1234,567');
-shouldBe(Intl.NumberFormat('de').format(1234.567), '1.234,567');
+shouldBe(Intl.NumberFormat('en').format(12345.678), '12,345.678');
+shouldBe(Intl.NumberFormat('es').format(12345.678), '12.345,678');
+shouldBe(Intl.NumberFormat('de').format(12345.678), '12.345,678');
// Test numbering systems.
shouldBe(Intl.NumberFormat('en-u-nu-latn').format(1234.567), '1,234.567');
Modified: trunk/JSTests/stress/intl-object.js (259657 => 259658)
--- trunk/JSTests/stress/intl-object.js 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/stress/intl-object.js 2020-04-07 19:35:54 UTC (rev 259658)
@@ -1,5 +1,3 @@
-//@ skip if $hostOS == "windows"
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error(`expected ${expected} but got ${actual}`);
Modified: trunk/JSTests/stress/intl-pluralrules.js (259657 => 259658)
--- trunk/JSTests/stress/intl-pluralrules.js 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/stress/intl-pluralrules.js 2020-04-07 19:35:54 UTC (rev 259658)
@@ -1,5 +1,3 @@
-//@ skip if $hostOS == "windows"
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error(`expected ${expected} but got ${actual}`);
@@ -284,14 +282,11 @@
shouldBe(new Intl.PluralRules('en', {type: 'ordinal', maximumSignificantDigits: 2}).select(123), 'other');
shouldBe(new Intl.PluralRules('en', {type: 'ordinal', maximumSignificantDigits: 3}).select(123.4), 'few');
-// These require ICU v59+
-/*
shouldBe(new Intl.PluralRules('en', {minimumFractionDigits: 1}).select(1), 'other');
shouldBe(new Intl.PluralRules('en', {minimumSignificantDigits: 2}).select(1), 'other');
// Plural categories are correctly determined
shouldBe(new Intl.PluralRules('en').resolvedOptions().pluralCategories instanceof Array, true);
-shouldBe(new Intl.PluralRules('ar').resolvedOptions().pluralCategories.join(), 'zero,one,two,few,many,other');
+shouldBe(new Intl.PluralRules('ar').resolvedOptions().pluralCategories.join(), 'few,many,one,two,zero,other');
shouldBe(new Intl.PluralRules('en').resolvedOptions().pluralCategories.join(), 'one,other');
-shouldBe(new Intl.PluralRules('en', {type: 'ordinal'}).resolvedOptions().pluralCategories.join(), 'one,two,few,other');
-*/
+shouldBe(new Intl.PluralRules('en', {type: 'ordinal'}).resolvedOptions().pluralCategories.join(), 'few,one,two,other');
Modified: trunk/JSTests/test262/config.yaml (259657 => 259658)
--- trunk/JSTests/test262/config.yaml 2020-04-07 18:58:34 UTC (rev 259657)
+++ trunk/JSTests/test262/config.yaml 2020-04-07 19:35:54 UTC (rev 259658)
@@ -37,9 +37,6 @@
- Intl.RelativeTimeFormat
- Intl.Segmenter
paths:
- # https://bugs.webkit.org/show_bug.cgi?id=192920
- - test/intl402/NumberFormat/prototype/formatToParts
-
- test/built-ins/DataView/prototype/getBigInt64
- test/built-ins/DataView/prototype/getBigUint64
- test/built-ins/DataView/prototype/setBigInt64
@@ -117,9 +114,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=186691
- test/built-ins/Reflect/ownKeys/return-on-corresponding-order-large-index.js
- # https://bugs.webkit.org/show_bug.cgi?id=192920
- - test/intl402/PluralRules/prototype/resolvedOptions/order.js
- - test/intl402/PluralRules/prototype/resolvedOptions/pluralCategories.js
# https://bugs.webkit.org/show_bug.cgi?id=190800
- test/built-ins/TypedArray/prototype/set/src-typedarray-big-throws.js
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
