Title: [259572] trunk/Source/_javascript_Core
- Revision
- 259572
- Author
- [email protected]
- Date
- 2020-04-06 08:41:48 -0700 (Mon, 06 Apr 2020)
Log Message
[JSC] Put ensureStillAliveHere for Integer TypedArrays in GetByVal
https://bugs.webkit.org/show_bug.cgi?id=210047
Reviewed by Mark Lam.
While r258381 puts ensureStillAliveHere in FTL to keep base alive for float/double TypedArrays,
we need to do the same thing for integer TypedArrays too. This patch places it.
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (259571 => 259572)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-06 15:33:34 UTC (rev 259571)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-06 15:41:48 UTC (rev 259572)
@@ -1,3 +1,16 @@
+2020-04-06 Yusuke Suzuki <[email protected]>
+
+ [JSC] Put ensureStillAliveHere for Integer TypedArrays in GetByVal
+ https://bugs.webkit.org/show_bug.cgi?id=210047
+
+ Reviewed by Mark Lam.
+
+ While r258381 puts ensureStillAliveHere in FTL to keep base alive for float/double TypedArrays,
+ we need to do the same thing for integer TypedArrays too. This patch places it.
+
+ * ftl/FTLLowerDFGToB3.cpp:
+ (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
+
2020-04-05 Gus Caplan <[email protected]> and Ross Kirsling <[email protected]>
DLLLauncherMain print to console instead of opening window on fatal error
Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (259571 => 259572)
--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2020-04-06 15:33:34 UTC (rev 259571)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2020-04-06 15:41:48 UTC (rev 259572)
@@ -4706,6 +4706,8 @@
if (isInt(type)) {
LValue result = loadFromIntTypedArray(pointer, type);
+ // We have to keep base alive since that keeps storage alive.
+ ensureStillAliveHere(base);
bool canSpeculate = true;
setIntTypedArrayLoadResult(result, type, canSpeculate);
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
