Title: [259558] trunk/Source/_javascript_Core
- Revision
- 259558
- Author
- [email protected]
- Date
- 2020-04-05 16:25:16 -0700 (Sun, 05 Apr 2020)
Log Message
Putting "memory" back to ensureStillAliveHere
https://bugs.webkit.org/show_bug.cgi?id=210028
Reviewed by Keith Miller.
We put "memory" back to make ensureStillAliveHere compiler-barrier.
* runtime/EnsureStillAliveHere.h:
(JSC::ensureStillAliveHere):
* runtime/JSCJSValue.h:
(JSC::ensureStillAliveHere):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (259557 => 259558)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-05 23:23:59 UTC (rev 259557)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-05 23:25:16 UTC (rev 259558)
@@ -1,3 +1,17 @@
+2020-04-05 Yusuke Suzuki <[email protected]>
+
+ Putting "memory" back to ensureStillAliveHere
+ https://bugs.webkit.org/show_bug.cgi?id=210028
+
+ Reviewed by Keith Miller.
+
+ We put "memory" back to make ensureStillAliveHere compiler-barrier.
+
+ * runtime/EnsureStillAliveHere.h:
+ (JSC::ensureStillAliveHere):
+ * runtime/JSCJSValue.h:
+ (JSC::ensureStillAliveHere):
+
2020-04-05 Mark Lam <[email protected]>
ARM64 moveConditionallyDouble() for DoubleNotEqualAndOrdered is wrong.
Modified: trunk/Source/_javascript_Core/runtime/EnsureStillAliveHere.h (259557 => 259558)
--- trunk/Source/_javascript_Core/runtime/EnsureStillAliveHere.h 2020-04-05 23:23:59 UTC (rev 259557)
+++ trunk/Source/_javascript_Core/runtime/EnsureStillAliveHere.h 2020-04-05 23:25:16 UTC (rev 259558)
@@ -31,12 +31,12 @@
ALWAYS_INLINE void ensureStillAliveHere(uint64_t value)
{
- asm volatile ("" : : "g"(value) : );
+ asm volatile ("" : : "g"(value) : "memory");
}
ALWAYS_INLINE void ensureStillAliveHere(const void* pointer)
{
- asm volatile ("" : : "g"(pointer) : );
+ asm volatile ("" : : "g"(pointer) : "memory");
}
#else
Modified: trunk/Source/_javascript_Core/runtime/JSCJSValue.h (259557 => 259558)
--- trunk/Source/_javascript_Core/runtime/JSCJSValue.h 2020-04-05 23:23:59 UTC (rev 259557)
+++ trunk/Source/_javascript_Core/runtime/JSCJSValue.h 2020-04-05 23:25:16 UTC (rev 259558)
@@ -642,9 +642,9 @@
ALWAYS_INLINE void ensureStillAliveHere(JSValue value)
{
#if USE(JSVALUE64)
- asm volatile ("" : : "g"(bitwise_cast<uint64_t>(value)) : );
+ asm volatile ("" : : "g"(bitwise_cast<uint64_t>(value)) : "memory");
#else
- asm volatile ("" : : "g"(value.payload()) : );
+ asm volatile ("" : : "g"(value.payload()) : "memory");
#endif
}
#else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
