Title: [259554] trunk/Source/_javascript_Core
- Revision
- 259554
- Author
- [email protected]
- Date
- 2020-04-05 11:23:25 -0700 (Sun, 05 Apr 2020)
Log Message
ensureStillAliveHere can take the value in any location
https://bugs.webkit.org/show_bug.cgi?id=210028
Reviewed by Mark Lam.
It shouldn't matter if the value is on the stack or in a register
because we're not going to do anything with it. Also, there's no
reason to clobber memory.
* runtime/EnsureStillAliveHere.h:
(JSC::ensureStillAliveHere):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (259553 => 259554)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-05 18:21:01 UTC (rev 259553)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-05 18:23:25 UTC (rev 259554)
@@ -1,3 +1,17 @@
+2020-04-05 Keith Miller <[email protected]>
+
+ ensureStillAliveHere can take the value in any location
+ https://bugs.webkit.org/show_bug.cgi?id=210028
+
+ Reviewed by Mark Lam.
+
+ It shouldn't matter if the value is on the stack or in a register
+ because we're not going to do anything with it. Also, there's no
+ reason to clobber memory.
+
+ * runtime/EnsureStillAliveHere.h:
+ (JSC::ensureStillAliveHere):
+
2020-04-05 Zan Dobersek <[email protected]>
Unreviewed, adding missing header inclusions to get
Modified: trunk/Source/_javascript_Core/runtime/EnsureStillAliveHere.h (259553 => 259554)
--- trunk/Source/_javascript_Core/runtime/EnsureStillAliveHere.h 2020-04-05 18:21:01 UTC (rev 259553)
+++ trunk/Source/_javascript_Core/runtime/EnsureStillAliveHere.h 2020-04-05 18:23:25 UTC (rev 259554)
@@ -31,12 +31,12 @@
ALWAYS_INLINE void ensureStillAliveHere(uint64_t value)
{
- asm volatile ("" : : "r"(value) : "memory");
+ asm volatile ("" : : "g"(value) : );
}
ALWAYS_INLINE void ensureStillAliveHere(const void* pointer)
{
- asm volatile ("" : : "r"(pointer) : "memory");
+ asm volatile ("" : : "g"(pointer) : );
}
#else
Modified: trunk/Source/_javascript_Core/runtime/JSCJSValue.h (259553 => 259554)
--- trunk/Source/_javascript_Core/runtime/JSCJSValue.h 2020-04-05 18:21:01 UTC (rev 259553)
+++ trunk/Source/_javascript_Core/runtime/JSCJSValue.h 2020-04-05 18:23:25 UTC (rev 259554)
@@ -642,9 +642,9 @@
ALWAYS_INLINE void ensureStillAliveHere(JSValue value)
{
#if USE(JSVALUE64)
- asm volatile ("" : : "r"(bitwise_cast<uint64_t>(value)) : "memory");
+ asm volatile ("" : : "g"(bitwise_cast<uint64_t>(value)) : );
#else
- asm volatile ("" : : "r"(value.payload()) : "memory");
+ asm volatile ("" : : "g"(value.payload()) : );
#endif
}
#else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
